laise

so in general pet CC should share diminishing returns with players or they have their own?

links are broken =\\ anyway totem immunity, should be fixed in [11708].

partly fixed in [11697].

......... if (missInfo == SPELL_MISS_REFLECT) unitTarget = caster; // Fill base damage struct (unitTarget - is real spell target) SpellNonMeleeDamage damageInfo(caster, unitTarget, m_spellInfo->Id, m_spellSchoolMask); if (missInfo == SPELL_MISS_NONE || missInfo == SPELL_MISS_REFLECT && target->reflectResult == SPELL_MISS_NONE) { for (int32 effectNumber = 0; effectNumber < MAX_EFFECT_INDEX; ++effectNumber) { ..........

not sure if changing target here is correct - might calculate all damage bonuses(done&taken) as if caster is actual target and I'm not sure if it works that way on retail. added second part in [11699], thanks.

Hi,

similar problem here:

Two Chars A + B in a group.

Char A selects "roll"

Char B selects "greed"

Char A rolls and wins, but can't pick up loot. Message is "...still being rolled"

Char B can pick up loot.

Mangos: 11630

USB 0.12.1 (401)

tried with 2 clients, seems to work fine..maybe need really press it at the same time =\\

these macro doesn't work on retail - 4.0

Well currently I don't think mangos has it and maybe its time to decide if we need one?

I think there should be some pattern by which all functions/classes/etc. are written so we won't just throw things where we see fit(yea it works fine but requires more time to understand whats going on)

In general this new model should follow few rules like :

can't contradict any in-game feature and ways it works and possibly have ability to live with threads..

One of the examples for this is http://github.com/cipherCOM/mangos/tree/eventsystem-0.12 (for 0.12, only in basic stage of headers and debug functions -files Event***.h/cpp) which treats any in-game action

as an event so every part of server code regardless if its bg code or deal damage part go by format of having event(EventInfo) and passing it to listener for this specific type of event..

This way allows easier code understanding and developing new features can be faster(won't have to think how it will look like in some parts).

On the other hand switching is going to be hard because all server code needs to be changed to work with new way - this can be done on main branch as series of commits or having different branch and keeping it in sync, merging when finished.

Ofc either way we gonna loose support for most of the patches that are now on forums, even if smaller ones can be modified relatively easy, the larger ones can be a problem. Another problem

is that even if we only move existing code without fully rewriting it, we still may loose its functionality resulting in having more bugs/crashes/etc.

Would like to hear team opinion on that matter (if this change even needed and maybe there are better fitting model than event-like)..

in [10569]. Thanks =)

can you try after [10554]

aurEff->GetBase()

Can you please submit a patch in a diff format? and how positive checks related to periodic spells?

also what spells (ids) remove stealth, i tested with lifebloom and druid's prowl and it worked..

should be fixed in [10551]

Should be fixed when DynamicObject started to work with ObjectGuids.. [10519],[10521]

in [10523]. Thanks =)

This patch is outdated so it shouldn't be used..

@Laise: my hackfix didnt help , 2 more crashlogs of newer rev 10504:

http://paste2.org/p/996459

http://paste2.org/p/996460

I think the problem is not in empty list or related to list.. DynamicObject is created for each effect and I'm not sure that it is how it should be

already in repo..so accepted

not sure if it should be in accepted or rejected since code is a bit similar to how it is really implemented..outdated anyway

@False.Genesis, can you please post crash dump for latest rev?

outdated now, I think..

note: requires defining procEx for each spell where periodic damage/heal proc is checked or it won't proc at all.

http://paste2.org/p/992416

for [10486]

Wrong fix because - casterGUID is never empty - Even if (caster-> corpse || !caster -> isAlive || !caster-> IsInWorld) ?

"return" is wrong - Then put "break" is also wrong fix ?

ok if casterGUID is magically 0 then it will just compare existing guid with 0 and unless some spell's casterGUID is 0, it won't do anything..

wrong fix because - casterGUID is never empty and if it is - problem somewhere else, "return" is wrong because bounds contain all holders for same spell on current Unit - so why check only first one when you need to find exact same from caster who called delay?

works fine without this patch on latest

currently reflect and immunity checked on spell launch (finish casting), possibly need to move both to actual spell hit. Need someone to confirm if you cast bubble as paladin while some fireball is flying on you - will be immune to it?

hmm..where it can be modified..its not like SetAuraDuration or SendAuraUpdate are messing with map =\\