laise

moved related posts from bug report to leave it clean and here is my version of visible passive auras : http://paste2.org/p/774399

DELETE FROM spell_chain WHERE spell_id IN (31579,31582,31583,53137,53138,30802,30808,30809);
INSERT INTO spell_chain VALUES
(31579, 0, 31579, 1, 0),
(31582, 31579, 31579, 2, 0),
(31583, 31582, 31579, 3, 0),

(53137, 0, 53137, 1, 0),
(53138, 53137, 53137, 2, 0),

(30802, 0, 30802, 1, 0),
(30808, 30802, 30802, 2, 0),
(30809, 30808, 30802, 3, 0);

Heroic presence shouldn't be showed in caster's buffs because you can just cancel passive aura by right-click.

on retail 3.3.3 it is shown.

tested on abominations might and heroic presence, but should work with all raid-wide pasive auras

m_isPassive and totemAura is not needed in check at all, also you forgot - same auras in one raid/party should replace each other & replace lesser rank(self buff like strength on Abomination's Might is left) and you might wanna check Arcane Empowerment after logout =\\

there are already existing spells that allow dots be able to crit such as http://www.wowhead.com/spell=75461 for Flame Shock, maybe http://www.wowhead.com/spell=75445 for Immolate and might be some other exists for Rupture

yea fixed in 9743, thanks for report

works fine on 9737, any custom patches?

in [9737]. Thanks =)

in [9735]. Thanks =)

in [9734] . Thanks =)

works fine on latest revision.

in [9720], Thanks =)

As of the latest revision, this is NOT fixed.

Testers still learn illegit spells when they use mounts and enchanting.

what spells and exact number of revision

should be fixed in [9709]

please test after [9701]

works fine for me , in CalculateSpellDamage if spell is crit , final critical damage is passed to absorb calculation

Thanks =) in [9690]

looks like you have 2 queries - one from old dual spec patch, other from what was accepted

Thanks =) in [9676] or in some later

moved to accepted since it is already in master.

moved to accepted since it is already in master branch.

I think it should, for example the warlock and his armor that increase healing recieve(change in 3.3), it increase leech heal.

warlock armor is different - it has SPELL_AURA_MOD_HEALING_PCT and it is used on all healing spells regardless of their damageClass or type

in [9675]. Thanks =)

I tried to fix with : http://paste2.org/p/726325 but I'm not sure since leech auras have special way to benefit from spell power according to wowwiki, also are you sure that leech heal should get bonus from all other heal increase auras?

should be fixed in [9674]

added in [9671]

Quick Recovery All healing effects on you are increased by 20%. In additon, your finishing moves refund 80% of their Energy cost when they fail to hit. - dont work

works for me on 9664