laise

alternative fix in [10255]. Can't check only last aura since aura remove can trigger different holder remove..

AuraEffect::HandleAuraUntrackable ...wtf... AuraEffect doesn't even exist Oo

Do you have Quartz addon? Install and you will see the difference. Quartz cast bar becomes red on interrupting.

should be fixed in [10241]. Thanks for report

works for me.. tried on mobs in zulgurub under freeze, channeled can't display "interrupted" message anyway after [10189]

should be fixed in [10240]

spells are blocked client side, you can't use stealth spells in shadow dance form, and gives you an empty shapeshift bar for that form.

about not being able to use spells, is this on clean [10198]?

spell that enables it on client was removed from dbc..

without any patches, Shadowdance doesn't work on latest rev(and i mean latest, not any before)?

ok how u expect code to be in db? i mean srsly u cant put c++ scripts there... I tried once to group few similar spells (Spell::SelectMountByAreaAndSkill) but each spell still needed it's own special support - in this case related spell ids for different mounts..maybe spells need to have their own scripts in some way but i don't think it is related in any way to DB

I also believe that MaNGOS devs started this way (hardcoded things I mean),

hardcoded is done only when there is no other visible option to fix something..

and today they don't want to "lose" time by modifying something that works well for everyone.

really? why not look at commit log first?

Unit::RemoveAura+2F8 c:\\documents and settings\\administrator\\desktop\\copy (3) of 335 2 do not touch lol\\src\\game\\unit.cpp line 4670

what is on line 4670 in ur src..

any custom patches? and can u post line content that it falls on?

yea thanks, added in [10181]. I think better use basepoints that are already on trigger aura even if it is just * 1..

interesting ..buuut SendAuraUpdate is not on Aura class...

i think it should be proc-based, although atm we call it after actual damage deal - maybe need to add option for procs on hit but before damage deal and procs after..

also i see it checks for (!damage) after your code with "damage *= " maybe u need to check damage first if it is initialized?

glyph was changed in some of the patches, doesn't need any custom code

On what core rev is this happening?

It's a good job, but there is a visual bug.

When we use spell with stacked auras like lifebloom, the number of stack begin by 1, then we have 3, then 4 stacks.

It must be 1 then 2 and 3.

But after many tests, I concluded that is only a visual bug.

I didn't find the packet that send this data.

I looked the RefreshAuraDuration, but it seems to be in another place.

just tested with lifebloom and lacerate - not happening .. any other spells?

Thanks =) in [10173]

fixed in [10160], Thanks for report =)

As I understand in this case holder would contain only one aura so we can increase duration of aura holder and it will affect duration of all auras in it.

err ..kind of contradicting if you say "will contain one aura " and then "all auras in it".. duration changes are not connected in any way on how much auras are on holder in case when all auras suppose to have same duration, so for this spell will need to reset to full duration and add new duration for each aura.. ofc maybe i will add method for calling duration change from holder but it is wrong to move duration out of auras

Laise, what do you think about moving duration and related stuff to aura holder? Do you have an example when two auras from same spell have not equal durations?

yes, this is related to spells with stun/silence effect that have also another aura (for example periodic dmg) , according to my info from retail, existing talents that reduce duration of stun/silence/whatever effect are applied only to specific aura and not on whole spell, creating situation where stun/silence/whatever fades and periodic remains as it was..I don't remember exact spell ids for that but they do exist

retail still uses original auras that were removed from dbc Q_Q

updated for 10104. Most of proc handling functions are now in its own file, also in new way proc handlers added to aura types in same way as normal aura handlers

should be fixed in [10088]

on retail it just multiplies tick damage x4 after bonus applying