Corrupted Whipper Root bugged

The [B]gameobject_loot_template[/B] entries are totally wrong.

As it currently stands, apparently you can acquire Fel Creep from iron, Darkmoon Faire Banner (2 entries) and Forge (2 entries), lol. Looks like someone was on some happy candy when they did this.

I'll figure out what the records should be, and check the Tainted Vitrol one too (mining). The skinning one looks fine, but I'll go through that thoroughly too, and the other proffs that can be used to achieve the quest objective.

[B]EDIT[/B]: Oops, my bad. This is about the CORRUPTED plants. Seems I may have found another issue. I really need to learn to take in what I read!

Okay, attempt 2 at locating the issue. This time looking at the reported issue, not something my noggin fabricated, lol

We have in the database:

The objects that the player can loot ([B]gameobject_template[/B] table):
[COLOR="#800080"]Corrupted Night Dragon
Corrupted Songflower
Corrupted Whipper Root
Corrupted Windblossom[/COLOR]

The items that can be looted from the above objects ([B]item_template[/B] table):
[COLOR="#008000"]Whipper Root Tuber[/COLOR] from Corrupted Whipper Root
[COLOR="#008000"]Songflower Serenade[/COLOR] from Corrupted Songflower
[COLOR="#008000"]Night Dragon's Breath[/COLOR] from Corrupted Night Dragon
[COLOR="#008000"]Windblossom Berries[/COLOR] from Corrupted Windblossom

But nothing in the [B]gameobject_loot_template[/B] table for either the items or the corrupted objects.

I'll now add these to that table. I need to locate the drop rate, but as a guess, I expect that should be 100%.

[B][SIZE=4][COLOR="#006400"]FIXES:[/COLOR][/SIZE][/B]


[SIZE=3][B][COLOR="#800080"]Corrupted Whipper Root[/COLOR][/B][/SIZE] (gameobject_template: 164888, 173284, 174605, 174606, 174607, 174686)

INSERT INTO `gameobject_loot_template` (`entry`, `item`, `ChanceOrQuestChance`, `groupid`, `mincountOrRef`, `maxcount`, `condition_id`) VALUES ('164888', '11951', '100', '0', '1', '3', '0'),('173284', '11951', '100', '0', '1', '3', '0'),('174605', '11951', '100', '0', '1', '3', '0'),('174606', '11951', '100', '0', '1', '3', '0'),('174607', '11951', '100', '0', '1', '3', '0'),('174686', '11951', '100', '0', '1', '3', '0');

[SIZE=3][B][COLOR="#800080"]Corrupted Night Dragon[/COLOR][/B][/SIZE] (gameobject_template: 164885, 173324, 174608, 174684, 182114)

INSERT INTO `gameobject_loot_template` (`entry`, `item`, `ChanceOrQuestChance`, `groupid`, `mincountOrRef`, `maxcount`, `condition_id`) VALUES ('164885', '11952', '100', '0', '1', '3', '0'),('173324', '11952', '100', '0', '1', '3', '0'),('174608', '11952', '100', '0', '1', '3', '0'),('174684', '11952', '100', '0', '1', '3', '0'),('182114', '11952', '100', '0', '1', '3', '0');

[SIZE=3][B][COLOR="#800080"]Corrupted Windblossom[/COLOR][/B][/SIZE] (gameobject_template: 164887, 173327, 174599, 174600, 174601, 174602, 174603, 174604, 174708, 174709)

INSERT INTO `gameobject_loot_template` (`entry`, `item`, `ChanceOrQuestChance`, `groupid`, `mincountOrRef`, `maxcount`, `condition_id`) VALUES ('164887', '11950', '100', '0', '1', '3', '0'),('173327', '11950', '100', '0', '1', '3', '0'),('174599', '11950', '100', '0', '1', '3', '0'),('174600', '11950', '100', '0', '1', '3', '0'),('174601', '11950', '100', '0', '1', '3', '0'),('174602', '11950', '100', '0', '1', '3', '0'),('174603', '11950', '100', '0', '1', '3', '0'),('174604', '11950', '100', '0', '1', '3', '0'),('174708', '11950', '100', '0', '1', '3', '0'),('174709', '11950', '100', '0', '1', '3', '0');

[SIZE=3][B][COLOR="#800080"]Corrupted Songflower[/COLOR][/B][/SIZE] (gameobject_template: 164886, 171939, 171942, 174594, 174595, 174596, 174598, 174712, 174713)

Ah, this one results in a buff (spell), not an item drop! I'll need to look into how this is implemented, because the gameobject_loot_template table only takes items, as far as I can tell.

I'll create a Pull Request for the others now, then look into the Corrupted Songflower/Songflower Serenade one.

[B][SIZE=4][COLOR="#FF0000"]EDIT 17th Nov, 2014 - THIS IS WRONG[/COLOR][/SIZE][/B]
It should be the Cleansed version of the plants, not the corrupted. That's what happens when you don't test in-game. Bad. bad me :o
Don't bother making up scripts with the cleansed plants, as it still does not work!

[SIZE=3][COLOR="#008000"]Pull Request has now been made with a fix for the Corrupted Whipper Root, Corrupted Night Dragon, and Corrupted Windblossom looting issue.[/COLOR][/SIZE]

I'll now look at the Corrupted Songflower issue.

[B]EDIT:[/B] I'll have to revisit this some other time, unless someone else has the answer. I cannot locate where the Corrupted Sunflower objects are linked to the Songflower Serenade spell (15366). Nothing stands out in the tables, or when searching for the IDs in the mangos database.

From a player: No still doesnt work.. It still says ''Another action in progress''.

So it's still not lootable.

Geez, we must have a Gremlin infestation!!! I tested that and it worked fine, nightmare! :(

Okay, I lied, or going senile.

When attempting to loot it comes up with:
“[COLOR="#B22222"][B]Another action is in progress[/B][/COLOR]”

After applying the salve the corrupted plants are not despawning! Both corrupted and cleansed occupy the same space.

[B]EDIT:[/B] I reckon I have figured out how to get the Corrupted version of the plant to despawn (not reported issue, I know)

It will require a second entry in the [B]dbscripts_on_quest_end [/B]table. In there it already has one entry which spawns the Cleansed plant, but we also need an entry that despawns the Corrupted plant. Of course, I will test this to be sure.

The Corrupted Whipper Root is linked to the dbscripts_on_quest_end table through the quest: Corrupted Whipper Root, thus:

[B]gameobject_template[/B] (entry 173284) [B][COLOR="#008000"]→[/COLOR][/B] [B]gameobject_involvedrelation[/B] (id 173284) [B][COLOR="#008000"]→[/COLOR][/B] [B]quest_template [/B](4443) [B][COLOR="#008000"]→[/COLOR][/B] [B]dbscripts_on_quest_end[/B]

The table [B]dbscripts_on_quest_end[/B] can have many record entries for a quest.

In the [B]dbscripts_on_quest_end[/B] table, the field: command, is used to say what will happen: summon object/creature, despawn self, etc (many things can be done). The following 2 fields are used to specify the GUID of the object to be spawned, and the time it should stay in the game world till it despawns (feilds: datalong, datalong2).

Hopefully with all this research I'll also figure out for why the looting problem occurs.

Okay, now to test this!

NUTS! The despawning is only for creatures!

[B]EDIT again:[/B] Very strange, when interacting with the Cleansed Whipper Root it says in the mangos terminal: [B][COLOR="#0000FF"]Goober ScriptStart ID 4118 on Entry 164883 GUID 48881[/COLOR][/B]

The Entry and GUID is that plant, so where is this ID 4118.
If it's the one from [B]dbscripts_on_quest_end[/B], then that is very, very strange, because that's for the Corrupted Songflower plant and quest!!!

[B][SIZE=4][COLOR="#FF0000"]WRONG, WRONG, WRONG[/COLOR][/SIZE][/B] - re script fix

It should be the Cleansed version of the plants, not the corrupted. That's what happens when you don't test in-game. Bad. bad me :o
Don't bother making up scripts with the cleansed plants, as it still does not work!

I'll revisit this as soon as I can!

Back on this one again...

[B][COLOR="#008000"]NOTE:[/COLOR] [/B]Looting issue due to incorrect value in the [B][COLOR="#800080"]Type [/COLOR][/B]field of the [B]gameobject_template [/B]table. It should be of Type 3 (chest) with the ID of the corresponding [B]gameobject_loot_template [/B]table's entry in field: [B][COLOR="#800080"]data1[/COLOR][/B]

[B]CORRUPTED/CLEANSED WHIPPER ROOT TABLE[/B]
[table="width: 500, class: grid, align: center"]
[tr]
[td]Corrupted[/td]
[td]GUID[/td]
[td]X[/td]
[td]Y[/td]
[td]Z[/td]
[td]Cleansed[/td]
[td]GUID[/td]
[td]Quest / Dbscripts_on_quest_end ID[/td]
[/tr]
[tr]
[td]164888[/td]
[td]48844[/td]
[td]3866.64[/td]
[td]-666.66[/td]
[td]329.73[/td]
[td]164883[/td]
[td]17660/48881[/td]
[td]4117[/td]
[/tr]
[tr]
[td]173284[/td]
[td]48935[/td]
[td]6433.25[/td]
[td]-1266.62[/td]
[td]383.21[/td]
[td]174622[/td]
[td]17662/48882[/td]
[td]4443[/td]
[/tr]
[tr]
[td]174605[/td]
[td]48845[/td]
[td]6666.67[/td]
[td]-1200[/td]
[td]471.33[/td]
[td]174623[/td]
[td]17664/48883[/td]
[td]4444[/td]
[/tr]
[tr]
[td]174606[/td]
[td]48915[/td]
[td]6400[/td]
[td]-699.99[/td]
[td]477.42[/td]
[td]174624[/td]
[td]18176/48884[/td]
[td]4445[/td]
[/tr]
[tr]
[td]174607[/td]
[td]48846[/td]
[td]5333.33[/td]
[td]-833.33[/td]
[td]342.73[/td]
[td]174625[/td]
[td]18178/48885[/td]
[td]4446[/td]
[/tr]
[tr]
[td]174686[/td]
[td]48843[/td]
[td]4824.34[/td]
[td]-316.8[/td]
[td]358.79[/td]
[td]174687[/td]
[td]18180/48886[/td]
[td]4461[/td]
[/tr]
[/table]



[B]CORRECTIONS TO THE PREVIOUS SCRIPT FIX[/B]

-- Delete Corrupted Whipper Root entries
[COLOR="#0000FF"]DELETE FROM gameobject_loot_template where item = 11951;[/COLOR]
-- Delete Corrupted Night Dragon entries
[COLOR="#0000FF"]DELETE FROM gameobject_loot_template where item = 11952;[/COLOR]
-- Delete Corrupted Windblossom entries
[COLOR="#0000FF"]DELETE FROM gameobject_loot_template where item = 11950;[/COLOR]

[B]REMOVE UNWANTED CLEANSED WHIPPER ROOT RECORDS[/B] (there are 2 of each, but only one of each is needed/correct - see above table)
[COLOR="#0000FF"]DELETE FROM gameobject WHERE `guid`='17660';[/COLOR]
[COLOR="#0000FF"]DELETE FROM gameobject WHERE `guid`='17662';[/COLOR]
[COLOR="#0000FF"]DELETE FROM gameobject WHERE `guid`='17664';[/COLOR]
[COLOR="#0000FF"]DELETE FROM gameobject WHERE `guid`='18176';[/COLOR]
[COLOR="#0000FF"]DELETE FROM gameobject WHERE `guid`='18178';[/COLOR]
[COLOR="#0000FF"]DELETE FROM gameobject WHERE `guid`='18180';[/COLOR]

[B]New gameobject_loot_template records for Cleansed Whipper Root[/B]

-- Cleansed Whipper Root (gameobject_template: 164883, 174622, 174623, 174624, 174625, 174687)
[COLOR="#0000FF"]INSERT INTO gameobject_loot_template (`entry`, `item`, `ChanceOrQuestChance`, `groupid`, `mincountOrRef`, `maxcount`, `condition_id`) VALUES ('164883', '11951', '100', '0', '1', '3', '0'),('174622', '11951', '100', '0', '1', '3', '0'),('174623', '11951', '100', '0', '1', '3', '0'),('174624', '11951', '100', '0', '1', '3', '0'),('174625', '11951', '100', '0', '1', '3', '0'),('174687', '11951', '100', '0', '1', '3', '0');[/COLOR]


-- Replace Cleansed Whipper Root [B]gameobject_template[/B] records
-- the plants will now be lootable
[COLOR="#0000FF"]DELETE FROM gameobject_template where name = "Cleansed Whipper Root";[/COLOR]
[COLOR="#0000FF"]INSERT INTO gameobject_template (`entry`, `type`, `displayId`, `name`, `faction`, `flags`, `size`, `data0`, `data1`, `data2`, `data3`, `data4`, `data5`, `data6`, `data7`, `data8`, `data9`, `data10`, `data11`, `data12`, `data13`, `data14`, `data15`, `data16`, `data17`, `data18`, `data19`, `data20`, `data21`, `data22`, `data23`, `mingold`, `maxgold`, `ScriptName`) VALUES ('164883', '3', '3255', 'Cleansed Whipper Root', '0', '0', '2', '43', '164883', '0', '1', '1', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', ''),('174622', '3', '3255', 'Cleansed Whipper Root', '0', '0', '2', '43', '174622', '0', '1', '1', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', ''),('174623', '3', '3255', 'Cleansed Whipper Root', '0', '0', '2', '43', '174623', '0', '1', '1', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', ''),('174624', '3', '3255', 'Cleansed Whipper Root', '0', '0', '2', '43', '174624', '0', '1', '1', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', ''),('174625', '3', '3255', 'Cleansed Whipper Root', '0', '0', '2', '43', '174625', '0', '1', '1', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', ''),('174687', '3', '3255', 'Cleansed Whipper Root', '0', '0', '2', '43', '174687', '0', '1', '1', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '');[/COLOR]

[B]INCORRECT GUID USED FOR SPAWNING CLEANSED WHIPPER ROOT[/B]
[COLOR="#0000FF"]UPDATE dbscripts_on_quest_end SET datalong = 48882 WHERE id = 4443;[/COLOR]

[B][COLOR="#FF0000"]STILL TO SOLVE[/COLOR][/B]
The corrupted version of the plant does not despawn after applying the salve. It should despawn then respawn after a good bit of time.

It looks like the despawning will need to be scripted via the ScriptName field in the gameobject_template table :-(
Ideally it would be better to have been as a result of completing the quest, but there is no way to despawn an object. You can only despawn creatures that way :-(

[B][COLOR="#FF0000"]PROBLEM:[/COLOR][/B] The usual way to respawn the game objects does not appear to work very well, if at all.

This is still not working. Any update here?

@hikari - Any ideas ?

I just got back from helping a friend move house. A few days of insanity, finishing with a good many drinks :)

I'll test this again tomorrow with a nice fresh and non affected head :)

The DB scripts (above) and Eluna and SD2 scripts are in place (ready for PR'ing) to make this work , but the last time I looked at this there were issues with the spawning and despawning opf the plants. I'm not certain, but Foereaper may have sorted it. My memory is too fried to remember.

Yes, sadly there is only a Despawn Self database script command for creatures and not for gameobjects, as you already mentioned.
Therefore one has to script the despawn of the plants in either SD2 or Eluna.

But in the long term it would be useful to introduce the Despawn Self command for gameobjects as well, because there are tons of situations and quests, where you need to despawn objects. I encountered already some of them.

Despawning through both SD2 and Eluna is currently having some issues. See the internal discussion thread about this.

Due to the despawning issue, I will PR a DB fix that includes a % chance of there being loot.

I'll set this to 10%. So there will be a 10% chance that the cleansed plant will have Whipper Root Tuber loot available, and 90% of the time there will be no loot.

Is this to your liking or would you prefer a lower or higher value ?

This is obviously a temporary fix!

[B][SIZE=3]A Pull Request has now been made with the temporary fix:[/SIZE][/B]

[url]https://github.com/mangoszero/database/pull/183[/url]

The chance should be 100% when you're cleaning it. Without the salve you shouldn't be able to get any loot.
So you have to finish the quest, get the salve forever and then you are able to clean and loot those herbs for their buff food.