Loot issue...

This is currently being worked on.... hopefully we'll have a fix in the next few days

Yes. I will release it tonight or tomorrow depending on my workload.

Sweet! I imagine the two most important modes are group-loot and loot-master. FFA should be cake to implement.

All of this has already be done. Just few things that were forgotten by the previous reworking :)

Hello, my last pr bas been merged. Group loot should be fixed properly. Master loot still suffers some issues. :-)

Hello Xenithar,

For Zero (Rel20), group loot methods have been reworked and must be more blizzlike. If it's convenient for everybody, this can be ported to one and maybe two.

(don't forget to clone submodules while cloning again the sources)

[URL="https://github.com/mangoszero/server/commit/abaf96b6aeaa068c910cd30e4c12788b4debf516"]https://github.com/mangoszero/server/commit/abaf96b6aeaa068c910cd30e4c12788b4debf516[/URL]
[URL="https://github.com/mangoszero/server/commit/a17fabbf4da5624396c19f0bbd2646b7eb5dec15"]https://github.com/mangoszero/server/commit/a17fabbf4da5624396c19f0bbd2646b7eb5dec15[/URL]
[URL="https://github.com/mangoszero/server/commit/10f4de8495a9d41d22707971f23684f1f8b9fa32"]https://github.com/mangoszero/server/commit/10f4de8495a9d41d22707971f23684f1f8b9fa32[/URL]
[URL="https://github.com/mangoszero/server/commit/b8e91f1f87f675882fb1774c41abbca65bed2401"]https://github.com/mangoszero/server/commit/b8e91f1f87f675882fb1774c41abbca65bed2401[/URL]
[URL="https://github.com/mangoszero/server/commit/588d766c5704d02e06f6cb02906bcf2164d12086"]https://github.com/mangoszero/server/commit/588d766c5704d02e06f6cb02906bcf2164d12086[/URL]
[URL="https://github.com/mangoszero/server/commit/1fd8f4a8623dfbbabbdebd41dc0bd04b091612a9"]https://github.com/mangoszero/server/commit/1fd8f4a8623dfbbabbdebd41dc0bd04b091612a9[/URL]

If group loot works, does setting the loot level for rolling work? In other words, if I set group loot and choose blue or better, will greens be rotated like whites as it should be, or will we still have to roll on greens?

Also, does any of this fix the "never happened in a million years in official" issue where if I open a chest, the entire group must roll on items? Normally the group would do "/roll 100" and whomever had the highest roll got to open and loot the chest. However, in R19 (not sure about R20 yet) when I open a chest, my entire group gets to roll and win the items inside. Not Blizzlike at all.

[quote=Xenithar]If group loot works, does setting the loot level for rolling work? In other words, if I set group loot and choose blue or better, will greens be rotated like whites as it should be, or will we still have to roll on greens?[/quote]

Yes it should. I did test with blue and epic.

[quote=Xenithar]
Also, does any of this fix the "never happened in a million years in official" issue where if I open a chest, the entire group must roll on items? Normally the group would do "/roll 100" and whomever had the highest roll got to open and loot the chest. However, in R19 (not sure about R20 yet) when I open a chest, my entire group gets to roll and win the items inside. Not Blizzlike at all.[/quote]

Didn't test that, only focused on creatures. Must give a try.

Mind you, the case I was stating was tested in R19 and it happens every time. However, I have not allowed anybody on the R20 server due to bugs that worry me may cause hours of labor lost, such as the pets not spawning. I would HATE to have my mom lose her pet after hours and hours of raising it. Same for my fiance. Therefore, I have not tested this in R20. I am available to connect to another server and test with you if you need my assistance though.

I will validate it. Just need to pop a chest btw :)

How will you validate it without a group? Is there a way we can test group things solo? I have never tried so forgive my ignorance.

Create a second account and invite your normal account to a group with that?

[quote=Xenithar]How will you validate it without a group? Is there a way we can test group things solo? I have never tried so forgive my ignorance.[/quote]

I launch 2 clients with 2 accounts and I group them. I'm not fixing things and hopping it will work, I test quite some scenario's. ;-)

I imagine you do. I just assumed everybody is not an IT geek with an actual lab in his home to test things. I can multibox and control five characters at once if I want to, making things easy to test. I was curious as to whether there was a built-in way to do it. Kind of like spawning a bot to help you in UT or something.

Let me know what your test results are though.

Well, either you say that you fix things, either you dont. But if you do, i think you must do it properly.

Chests are not blizzlike actually. Working on it. And Im not an IT geek... I only have one standard computer, one screen and some times between activities...

You're right, and that is what I instill in my employees. Do it right the first time. And yes, I am fortunate. I have three 98SE systems (all matched hardware), five XP systems (matched), and two Windows 7 Pro systems (again, matched) in my lab. You can play any game from DOS games to modern ones at my place. It was my dream to have this setup when I got a well-paying job, and I have it. Now for more servers!

Now, on to the important things. When you say they're not Blizzlike, does that mean you're having the issue I am experiencing? Members get to roll on chest items?

Thats the visible part. For me visual and looting a chest that other player is already looting are also bugged.

So you can loot the same chest with two players at the same time? Are the contents of the chest the same for both players? This sounds like something I should play with this weekend when I have some time!

[quote=Xenithar]So you can loot the same chest with two players at the same time?
[/quote]

Yes.

[quote=Xenithar]Are the contents of the chest the same for both players?
[/quote]

No.

[quote=Xenithar]This sounds like something I should play with this weekend when I have some time![/quote]

To be honest, I wouldn't.. being 2 to work on such basic issue is too much.

Worflow: players are casting spell 3365 to open the chest (spell_cast_failed to notify that other have it open), then player::sendloot is actually generating the loots (if required) and setting the permissions, dolootrelease actually close the chest.

Remaining to do: Show open chest to other players than the one opening it.

Hello,

Should be fixed by this commit for both chest and group loot: [url]https://github.com/Warkdev/server/commit/9c95b4271669bcd48a1836124c945194b821a560[/url]

You work fast, I admire that. I just now got to sit down and check the forum/tracker. I kind of miss the days of working at a retail store and having loads of time off, but I couldn't afford a $42,000 vehicle back then!

Thanks for your hard work!

That was really simple. When you've sources, it goes quick, when you don't, you waste time. :-)

Don't hesitate to report any other bug related to looting system, now I'm used to it.