Jump to content
  • [Rel20] Release showstoppers! PLEASE READ!


    Foereaper
    • Status: Completed
      Main Category: Core / Mangos Daemon
      Sub-Category: Show Stopper
      Version: 21.3 Milestone: 25 Priority: New
      Related to:
      Implemented Version: 21.14
     Share

    [Rel20] Release showstoppers! PLEASE READ!

    Alright guys, we're just around the corner from releasing Rel20. Currently we have a (few) show stopper(s) that NEEDS to be attended to before a release is possible. For that reason I'd like to ask ALL of you to take part in this discussion and subsequent fixing of the said issues. That means, any side projects, be it script fixing, database work or any of the other normal tasks, will have to be down prioritized until the issues listed here are fixed and Rel20 is released:

    - Loot system issues. Specifically ALL gathering profession loot, soul shards etc. does NOT work when in a group. For gathering, this applies when Master Loot is enabled OR the player is in a raid.
    * Soul shard issue: fixed. https://github.com/mangoszero/server/commit/831b910bd23f4de44edd3ae1f19696c40a416fbf
    * Skinning issue: fixed. https://github.com/mangoszero/server/commit/dfe671396691237bf5311f8572f79dd227819644
    * Herbalism issue: fixed. https://github.com/mangoszero/server/commit/dfe671396691237bf5311f8572f79dd227819644
    * Mining issue: fixed. https://github.com/mangoszero/server/commit/dfe671396691237bf5311f8572f79dd227819644

    Thank you Rainer for the amazing work on the gathering loot issues!

    - Chest loot bug. Causes rolling on green items in chests not to work. Supposed fix causes crashes.
    * Internal testing stage. To be PR'ed.

    - Resting in cities/inns.
    * Fixed: https://github.com/mangoszero/server/commit/095d8bd5ea7a704f6a21db54dbb2b4e30e785029

    If there are any other issues that are URGENT to fix before the said release, please post below so it can be added to the list. If something is less important, please hold till Rel21, which will be started the second Rel20 is good to go, which is hopefully as soon as possible.

     Share


    User Feedback

    Recommended Comments



    Original discussion thread here:

    [URL]https://www.getmangos.eu/developer-area-private-no-public-access-/10236-rel20-release-showstoppers-please-read.html[/URL]

    To recap:

    - Soul Shard issue is fixed. Skinning to be done.
    - Resting issue fixed and under testing. Will update accordingly.

    Edit:

    Resting has been fixed, will push a commit for this now.

    [url]http://prntscr.com/5qkuzd[/url]

    Link to comment
    Share on other sites

    Group loot is indeed broken. I am starting to become concerned that some changes in R20 have broken things in the Unix/Linux world. Can you try this in a VM using Linux? Group loot has been broken for a while. Then there's the realm servers not showing issue. Let's not forget the AHBot, or is that broken everywhere?

    Link to comment
    Share on other sites

    As I posted in the original thread:

    [FONT=Verdana]Group loot seems to work for me? Only one member of the group can loot it here.[/FONT]

    [URL="http://prntscr.com/5qjogk"]Screenshot by Lightshot[/URL]

    I will test with my VM in ~10 min

    Link to comment
    Share on other sites

    Resting fixed and pushed: [url]https://github.com/mangoszero/server/commit/095d8bd5ea7a704f6a21db54dbb2b4e30e785029[/url]

    Issue was introduced here: [url]https://github.com/mangoszero/server/commit/25df692e5f55343c57b9553a94a7e806d84f0895[/url]

    Link to comment
    Share on other sites

    [URL]http://prntscr.com/5qlk5u[/URL]

    As you can see, realm (mangos-linux) is showing up like it is supposed to.

    Edit:

    Group loot also works as it does on Windows, and seems to work like it should:

    [url]http://prntscr.com/5qll4h[/url]

    Link to comment
    Share on other sites

    IsTappedBy does not, however the IsXPOrHonor thing does. That being said, it needs another change in that case, it shouldn't check if either type or xp check, it should check all three things. Will update it again later.

    I will have to do some work related stuff today as well, hopefully someone could debug the skinning issue for me at least, so I would know where it stops when in a group :)

    Link to comment
    Share on other sites

    Use the Debian net installer. It's like a 180MB ISO and it simply installs directly from the repos. The problem, I believe, is that some thread instantly exits when realmd starts. Check the ticket. I am updating it in about a minute.

    Link to comment
    Share on other sites

    Another show-stopper/game-breaker. Druids cannot put a point into the talent "Faerire Fire (Feral)". However, as I have leveled I have been able to train in FF (Feral), despite not having the point or the rank 1 skill. See attached image. I just trained in FF (Feral) r4, and STILL cannot put my point into the talent, preventing me from going down the tree.

    Link to comment
    Share on other sites

    I do not get the desync anymore, it just went back to not working correctly. Players do occasionally get their animations desynced (ie: every time a player stops running they instantly look like they're sitting or laying down or whatever) but not their positions or movement.

    *EDIT*

    Also, the druid issue is strange. I believe we are teaching the player the wrong spell. Apparently I had learned FFF, but I never got yellow text telling me so and the point is not taking. However, when I do ".lookup spell faerie fire (feral)" I see one called "Faerie Fire (Feral) Talent" and it is known. However it does not show in my spellbook. I believe you need to know that to be able to learn higher ranks, but you must also teach the player "Faerie Fire (Feral) Rank 1" or the player cannot use it and it will not show a point in the talent tree. I will test this now.

    *UPDATE*

    This is odd. I unlearned FFF talent R1 and got my talent point back, and I was able to put the point into it and learn this time. However, I then trained my other ranks and it is back to showing that I do not know it and do not have a point in it.

    Link to comment
    Share on other sites

    Normal due to latency or packet-loss. I have seen FAR worse on official servers in loaded cities. Now if you are saying this only happens when looting is set to group loot, that tells me that the loot flag is somehow affecting another part of the engine server-side.

    Link to comment
    Share on other sites

    You're both at 0ms? I saw this every day on official servers, so I am not understanding the issue.

    *UPDATE*

    Reaper, I tried this with my mom, who lives 45min away, and she did not stutter like in your video, and she had 25ms latency.

    Link to comment
    Share on other sites

    Group loot is still not fixed. I just played for 2.5hrs with my fiance and mom at Jintha'Alor and with it set to group loot, it was random who got a corpse and sometimes we were all assigned to it. Sometimes we wouldn't get a corpse for many kills. It was not right. It should be rotational, not random, and it should NEVER allow more than one person to loot a corpse until after the assigned owner loots it.

    Link to comment
    Share on other sites




    Create an account or sign in to comment

    You need to be a member in order to leave a comment

    Create an account

    Sign up for a new account in our community. It's easy!

    Register a new account

    Sign in

    Already have an account? Sign in here.

    Sign In Now

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use