Jump to content
  • Copy ace.dll into the tools folder


    madmax
    • Status: Confirmed
      Main Category: Core / Mangos Daemon
      Sub-Category: Minor
      Version: 21.11 Milestone: 22 Priority: Normal
      Implemented Version: Unset

    Copy ace.dll into the tools folder

    When building the server you only get 1 copy of ace.dll in the root folder, this causes users to report that ace.dll is missing when it is not. We should modify the build process so it copies ace.dll into the tools folder.


    User Feedback

    Recommended Comments

    It might also be possible to remove the ACE dependency from the generators and then there is no need for the dll (except on the actual server).

    Im relatively sure you can use C++11 to replace most of the stuff needed from ace.

    Link to comment
    Share on other sites

    On 15/03/2017 at 5:52 PM, Rochet2 said:

    It might also be possible to remove the ACE dependency from the generators and then there is no need for the dll (except on the actual server).

    Im relatively sure you can use C++11 to replace most of the stuff needed from ace.

    Replace entirely with C++ 11 ? Is there somewhere something explaining this ? What about performance ?

    Although I think that ACE should go away at some point :D

    Link to comment
    Share on other sites

    1 hour ago, Talendrys said:

    Replace entirely with C++ 11 ? Is there somewhere something explaining this ? What about performance ?

    Although I think that ACE should go away at some point :D

    I meant replacing it in the tools. So yes, entirely - in the tools.
    This means that we do not remove ACE completely form the server. JUST the tools. (vmap extractor, mmap extractor, mapextractor ..)

    We just implement the things we use from ACE, but in c++(11) ourselves. I dont think there is anything explaining this stuff, but its not like there needs to be. Simple steps: Remove ace dependency (linking) from tools and then fix the compile errors :)

    Im pretty sure the performance is not relevant. Even if any implementation we make would be 100 times slower, it might not appear at all to the users. Note that we are changing only the tools, not the server, and its only a small part of what the tools do that uses ACE.
     

    Link to comment
    Share on other sites

    1 hour ago, Talendrys said:

    ACE is used for the complete network layer.

    Ask yourself: Does vmap extractor connect to the internet? (and I do not mean that you should answer here)
    Clearly it has other uses in addition to that.

    1 hour ago, Talendrys said:

    The "try, debug & fix" approach you're advising is kind of dangerous

    You make my suggestion sound like the guy fixing this should just remove all code from the functions as that compiles. (This is a playful example, I do not mean that you said this, but that it comes out like this)

    That is not what I meant at all. Obviously someone changing the implementation should have an idea about what they are doing. The point was that you asked for a guide, which doesnt exist, so I gave rough steps for what needs to be done.

    Link to comment
    Share on other sites



    Create an account or sign in to comment

    You need to be a member in order to leave a comment

    Create an account

    Sign up for a new account in our community. It's easy!

    Register a new account

    Sign in

    Already have an account? Sign in here.

    Sign In Now

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use