[Fix][8477] regenerate power

[xdevil1]

This is very important for classes using energy! Another bump from me since in a few days I've seen some other fixes not as major as this one accepted.

[Taur]

This isn't related to the bug that GuruRD discovered. RegenerateAll() isn't called at all when the player the player is dead, so the timer never gets updated when dead. So if someone casts a resurrect spell on you, or you have reincarnate, you can wait 5 minutes before clicking accept and immediately come back to life with +5minutes worth of regenerating health and mana.

So what do you suggest we do to fix this? Is this bug still present?

[nos4r2zod]

This is what I meant should be done:

@@ -4019,6 +4047,7 @@ void Player::ResurrectPlayer(float restore_percent, bool applySickness)
    SetMovement(MOVE_UNROOT);

    m_deathTimer = 0;
+    m_lastRegenerate = getMSTime();

    // set health/powers (0- will be set in caller)
    if(restore_percent>0.0f)

Here is the patch on [8029]

[Trazom]

This is very important for classes using energy! Another bump from me since in a few days I've seen some other fixes not as major as this one accepted.

Please stop bumping. It will not help the patch to be accepted, even worse. Unless you have something useful to add (tested and found no bug, tested and found bug, fixe, ...).

I will update the first post with the latest update from nos4r2zod. Thanks for fix.

[xD5]

i tested this. seems good. but i think there a small bug where it still does not go smooth. its more like 1,2,3,4,5,6,5,6,7,8,9,8,9 something like that.

[Alez]

i tested this. seems good. but i think there a small bug where it still does not go smooth. its more like 1,2,3,4,5,6,5,6,7,8,9,8,9 something like that.

mb lags ?

[Taur]

Tested and in some special cases it makes players no realy die, they die and regen 1 life than states on a dead can cast state...

Happens to me too.. anyone has a solution for this? It happens just after i put this patch..

[pelle]

does this patch work on latest?

[Morphau]

Hello guys,

this bug of not died still exist, please help

[HiddenDweller]

patch works, tried adding a "if (curValue)" to check if player is dead before regenerating health. On the way moved Unit::SetLastManaUse from Unit.h (which isn't a place for functions) to Unit.cpp .

patch is for 8262

link

needs some testing to see if it fixed the dead caster bug

[pelle]

patch is for 2562

what rev ? :rolleyes:

[HiddenDweller]

whoops, meant 8262. I must've drunk something. edited the mistake. It would be funny if I could actually find 2562 and this patch worked

[illustri]

HiddenDweller thanks for the effort, the player 1hp regen bug still persists on my build 8277

[Power2All]

This patch is unstable.

Tested on a server with 500 players, crashes after a while.

Rev: 8342

Crash data: http://www.pastebin.ca/1523024

[TOM_RUS]

This patch is unstable.

Tested on a server with 500 players, crashes after a while.

Rev: 8342

Crash data: http://www.pastebin.ca/1523024

Crash log you posted not related to this patch.

[Power2All]

Indeed, this was a older paste.

I think it was this one, atleast, latest crash info

http://www.pastebin.ca/1523751 (08-09-2009)

http://www.pastebin.ca/1523752 (08-10-2009)

[LordJZ]

Indeed, this was a older paste.

I think it was this one, atleast, latest crash info

http://www.pastebin.ca/1523751 (08-09-2009)

http://www.pastebin.ca/1523752 (08-10-2009)

These dumps tells me that Mangos have freezed and anti-freeze thread crashed the server.

[ApoC]

I started reviewing patch.

[MrGhost]

I started reviewing patch.

Thanks a lot. It's not a big bug, but very annoying

[ApoC]

I looked at the patch and did few changes:

* Kicked out dependency on GetMSTime() in regen code

* Added some defines instead of magic values

* Cleanup

I would be very happy if some body can test and report possible regressions agains original patch. I tested it little bit with rogue nad priest and looks ok.

Patch on Pastebin: http://www.pastebin.ca/1543415

Patch on filebeam: http://filebeam.com/800169cae9d3a1efe73d5833930a539e (gzipped patch file)

Patch on github: git pull git://github.com/apoc/mangos.git regen_fix

My changes on patch you can see here: http://alturl.com/p68f

[xD5]

would this get rid of the nasty "die but not die" bug? will test this tomorrow.

[MrGhost]

Did anybody tried this patch? If not I will try it tonight...

[Revy]

Using it for a few days now. None of the testers have noticed a change in compare to original patch

R.

[illustri]

ApoC 's patch seems to fix the 1hp bug on original patch, using 8451 mangos revision

[pelle]

i can confirm, thanks apoc!