[fix] Ice barrier spell power coef patch 3.0.2

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

it fixes sp coef for ice barrier ( was 10% and since 3.0.2 is 80,53%)

For which repository revision was the patch created?

7643

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=570&highlight=ice+barrier but it's very old

Who has been writing this patch? Please include either forum user names or email addresses.

that would be me

diff --git a/SpellAuras.cpp "b/temp\\\\SpellAuras.cpp"
index 3f9e9a0..e72993d 100644
--- a/SpellAuras.cpp
+++ "b/temp\\\\SpellAuras.cpp"
@@ -5675,13 +5675,20 @@ void Aura::HandleSchoolAbsorb(bool apply, bool Real)
                    }
                    break;
                case SPELLFAMILY_MAGE:
+              {
-                    if(m_spellProto->SpellFamilyFlags == 0x80100 || m_spellProto->SpellFamilyFlags == 0x8 || m_spellProto->SpellFamilyFlags == 0x100000000LL)
+                    if(m_spellProto->SpellFamilyFlags == 0x80100 || m_spellProto->SpellFamilyFlags == 0x8)
                    {
-                        //frost ward, fire ward, ice barrier
+                        //frost ward, fire ward
                        //+10% from +spd bonus
                        DoneActualBenefit = caster->SpellBaseDamageBonus(GetSpellSchoolMask(m_spellProto)) * 0.1f;
                        break;
                    }
+                    if (m_spellProto->SpellFamilyFlags == 0x100000000LL)
+                    {
+                        //ice barrier
+                        //+80,53% from sp ... patch 3.0.2
+                        DoneActualBenefit = caster->SpellBaseDamageBonus(GetSpellSchoolMask(m_spellProto)) * 0.8053f;
+                        break;
+                    }
                    break;
+              }
                case SPELLFAMILY_WARLOCK:
                    if(m_spellProto->SpellFamilyFlags == 0x00)

can anybody write anything here about it or did i just correct dead code??

[Auntie Mangos]

Spell power coeficent should not be hardcoded! Must be from spell_bonus_data DB field.

This is not correct. For Absorb auras every bonuses are hardcoded currently. Try this patch http://getmangos.eu/community/viewtopic.php?id=6037 and you get wat you want

[raftom]

any news ?? anybody tested??

[Wast3d]

Yup corrupt at line 19

[raftom]

Yup corrupt at line 19

lol i forgot bracers {} .... corrected first post and it should works now

[jorooo]

Spell power coeficent should not be hardcoded! Must be from spell_bonus_data DB field.

[raftom]

the only entries i was able to find from wowhead and spell.dbc were these below and 33245 (used by some mobs)

DELETE FROM `spell_bonus_data` WHERE `entry` IN ('11426','13031','13032','13033','27134','33405','43038','43039');

INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES

('11426', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 1)'),

('13031', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 2)'),

('13032', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 3)'),

('13033', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 4)'),

('27134', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 5)'),

('33405', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 6)'),

('43038', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 7)'),

('43039', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 8)');

that hardcoded values was on purpose i believe ... just read the comment (to prevent double apply bonus)

[stfx]

Was fixed in [8341]. Thanks