[Help] Implementing Vehicles

[cafabrega]

It was updated yesterday, someone knows if it works again? or it's only a test update?

[Fell]

The Vehicle Spells are fixed.

Thanks a lot!

[fullburned]

DELETE FROM `creature_template_addon` WHERE `entry` IN (28670, 28312, 32629, 28319, 32627, 28094, 29929, 28782);

I think this query should be added to vvv_vehicle_test_data.sql before adding new values to creature_template_addon. The reason for this: if you revert structure changes for `creature_template_addon` and then again try to run vvv_vehicle_test_data.sql, the queries like "INSERT IGNORE INTO creature_template_addon" won't work.

[BloodLord]

how long until a stable patch that will be implemented in the master branch?

[Espec]

Average time of implement major patch is 8-12 months. Wait or use Trinity.

[roby10]

any progress so far?patch 3.2 came with new vehicles:):D

sry for my bad english

[voltz]

Nice . Im abit new to git system, so how do i get this code to the latest rev

would be nice if some1 could help me with this ^^

[JordanMckeag]

I have saw this same patch work perfectly in servers without crashing

I suggest people start reviewing it and seeing how stable it is

[morderek]

yes, i have seen mangos servers which have vehicles implemented.

good work , don´t leave this patch

[marcelomax]

Someone can fix the compilation for last rev?

in 8386 i've got error "not declared" on MovementHandler.cpp

ty

[roby10]

how could i get more vehicles to work?

sry for my bad english;)

[keltuss]

Someone can fix the compilation for last rev?

in 8386 i've got error "not declared" on MovementHandler.cpp

ty

@@ -591,16 +591,14 @@ void WorldSession::HandleRequestVehicleSwitchSeat(WorldPacket &recv_data)
    if(!vehicleGUID)                                        // something wrong here...
        return;

    if(Vehicle *vehicle = ObjectAccessor::GetVehicle(vehicleGUID))
    {
-        CHECK_PACKET_SIZE(recv_data, recv_data.rpos()+1);
        uint64 guid = 0;
        if(!recv_data.readPackGUID(guid))
            return;

-        CHECK_PACKET_SIZE(recv_data, recv_data.rpos()+1);
        int8 seatId = 0;
        recv_data >> seatId;

        if(guid)
        {
@@ -642,16 +640,14 @@ void WorldSession::HandleChangeSeatsOnControlledVehicle(WorldPacket &recv_data)
    {
        MovementInfo mi;
        ReadMovementInfo(recv_data, &mi);
        //_player->m_movementInfo = mi;

-        CHECK_PACKET_SIZE(recv_data, recv_data.rpos()+1);
        uint64 guid = 0;
        if(!recv_data.readPackGUID(guid))
            return;

-        CHECK_PACKET_SIZE(recv_data, recv_data.rpos()+1);
        int8 seatId = 0;
        recv_data >> seatId;

        if(guid)
        {

[marcelomax]

@@ -591,16 +591,14 @@ void WorldSession::HandleRequestVehicleSwitchSeat(WorldPacket &recv_data)
    if(!vehicleGUID)                                        // something wrong here...
        return;

    if(Vehicle *vehicle = ObjectAccessor::GetVehicle(vehicleGUID))
    {
-        CHECK_PACKET_SIZE(recv_data, recv_data.rpos()+1);
        uint64 guid = 0;
        if(!recv_data.readPackGUID(guid))
            return;

-        CHECK_PACKET_SIZE(recv_data, recv_data.rpos()+1);
        int8 seatId = 0;
        recv_data >> seatId;

        if(guid)
        {
@@ -642,16 +640,14 @@ void WorldSession::HandleChangeSeatsOnControlledVehicle(WorldPacket &recv_data)
    {
        MovementInfo mi;
        ReadMovementInfo(recv_data, &mi);
        //_player->m_movementInfo = mi;

-        CHECK_PACKET_SIZE(recv_data, recv_data.rpos()+1);
        uint64 guid = 0;
        if(!recv_data.readPackGUID(guid))
            return;

-        CHECK_PACKET_SIZE(recv_data, recv_data.rpos()+1);
        int8 seatId = 0;
        recv_data >> seatId;

        if(guid)
        {

Just removing? woohoo... Thanks

I'll compile tonight again!

[kamillys]

I can't find any patch for current MaNGOS versions. Is there any more complete than from first post in this thread? In this thread I can't find anything usable.

[kamillys]

I'm talking about Vehicle Support patch, not fix for CHECK_PACKET_SIZE(). How to patch my MaNGOS source for supporting Vehicles?

[DJNefast]

personnaly i use it on my 3.2.0a core and it works but not fully there is some details which not works : spell are not effective, when u enter vehicle it spawn another for u and destroy where u clicked and respawn it.

[kamillys]

DJNefast: Did you used any custom patches or just built from 320 git branch?

[DJNefast]

my base is a 320 branch.

After i create a new repository with the rastikzzz branch, i use winmerge to compare all my sources and update 320 branch with vehicules functions (all of these)

next i update 320 branch manualy to last revision

then i create my own alterac patch on these project (but my sources don't touch neither the vehicle's function nor the vehicle implementation.

Either i have a bad patch or i have forget some lines in my code but i don't think because actualy the differences are between raztikk rev of mangos and mine.

i think the spell packet is wrong now for vehicles in 3.2.0x .

But vehicle i think the spawn bug is normal, i look after the code when i go back home and i'll try to find the error.

[Cobra101]

hello,

it's just an adjustment to reflect the update by Arrai Here

Ah, very nice. So that source with those changes. Got it, thanks. B)

[Mousik]

I have small problem.

If i use 81_anticheat.patch from KAPATEJIB comulative pack, all is ok.

If i use "git pull git://github.com/rastikzzz/mangos.git master", all is ok.

and problem is :

Id i use 81_anticheat.patch from KAPATEJIB comulative pack and "git pull git://github.com/rastikzzz/mangos.git master", give me error.

Are two different patches, but affects some rows at the same position.

can you help me someone please ?

[wormyke]

Is there any update on Git? Somebody can create a merged vehicle branch with Vladimir's core?

I would appreciate if somebody could do this for us!

Thanks in advance!

Keep up the good work guys!

[mokanina]

for the argent tournament mounts to work there are 2 spells - 63791 and 63792. when i click on a horse it says "requires tournament stables" but there is no such gameobject. any ideas how to fix this ?

[roby10]

i think that is an area ... not sure

[mokanina]

it is http://thottbot.com/?f=s&focus=Tournament%20Stables . even if i bind the spell to an object through spell_script_target it doesn't work anyway.

[wormyke]

Rastkizz:

I have compiled the new release and got the following errors:

2>------ Build started: Project: game, Configuration: Release Win32 ------

2>Compiling...

2>MovementHandler.cpp

2>..\\..\\src\\game\\MovementHandler.cpp(616) : error C3861: 'CHECK_PACKET_SIZE': identifier not found

2>..\\..\\src\\game\\MovementHandler.cpp(621) : error C3861: 'CHECK_PACKET_SIZE': identifier not found

2>..\\..\\src\\game\\MovementHandler.cpp(667) : error C3861: 'CHECK_PACKET_SIZE': identifier not found

2>..\\..\\src\\game\\MovementHandler.cpp(672) : error C3861: 'CHECK_PACKET_SIZE': identifier not found

2>Build log was saved at "file://d:\\Mangos Compile\\vehiclebranchcore_rev8411\\rastikzzz-mangos-19f7414dc1ff127431c0c882f6489703341ed253\\win\\VC90\\game__Win32_Release\\BuildLog.htm"

2>game - 4 error(s), 0 warning(s)

3>------ Build started: Project: mangosd, Configuration: Release Win32 ------

3>Linking...

3>LINK : fatal error LNK1181: cannot open input file '.\\game__win32_release\\game.lib'

3>Build log was saved at "file://d:\\Mangos Compile\\vehiclebranchcore_rev8411\\rastikzzz-mangos-19f7414dc1ff127431c0c882f6489703341ed253\\win\\VC90\\mangosd__Win32_Release\\BuildLog.htm"

3>mangosd - 1 error(s), 0 warning(s)

4>------ Build started: Project: script, Configuration: Release Win32 ------

4>Linking...

4>LINK : fatal error LNK1181: cannot open input file 'mangosd.lib'

4>Build log was saved at "file://d:\\Mangos Compile\\vehiclebranchcore_rev8411\\rastikzzz-mangos-19f7414dc1ff127431c0c882f6489703341ed253\\win\\VC90\\script__Win32_Release\\BuildLog.htm"

4>script - 1 error(s), 0 warning(s)

Do you have any idea what is the problem? Or is there any fix for this?

Thanks in advance!

EDIT:

Should I create another merge with rev8411? Some of the files missing from VC90.