[Help] Implementing Vehicles

Null · October 29, 2009

At last revision 8746 I have crashs at start. I compile with last patch on vehicles.

Crashdump is here.

Date 29:10:2009. Time 21:56 
//=====================================================
*** Hardware ***
Processor: Intel(R) Celeron(R) CPU 2.40GHz
Number Of Processors: 1
Physical Memory: 1047276 KB (Available: 376304 KB)
Commit Charge Limit: 2519992 KB

*** Operation System ***
Microsoft Windows XP Professional Service Pack 3 (Version 5.1, Build 2600)

//=====================================================
Exception code: C0000005 ACCESS_VIOLATION
Fault address:  004C983C 01:000C883C C:\\Documents and Settings\\Null\\Мои документы\\Загрузки\\Server_8577+YTDB_r511\\Server\\MaNGOS\\mangosd.exe

Registers:
EAX:00000000
EBX:71DA6408
ECX:00A54CAC
EDX:00000000
ESI:00000000
EDI:0089BDC0
CS:EIP:001B:004C983C
SS:ESP:0023:0BEDCA58  EBP:0BEDCA70
DS:0023  ES:0023  FS:003B  GS:0000
Flags:00010212

Call stack:
Address   Frame     Function      SourceFile
004C983C  00000000  stdext::hash_compare<unsigned __int64,std::less<unsigned __int64> >::operator()+C
004C90D5  00000000  stdext::_Hash<stdext::_Hmap_traits<unsigned __int64,Player *,stdext::hash_compare<unsigned __int64,std::less<unsigned __int64> >,std::allocator<std::Pair<unsigned __int64 const ,Player *> >,0> >::lower_bound+15
00800759  00000000  stdext::hash_map<unsigned __int64,Player *,stdext::hash_compare<unsigned __int64,std::less<unsigned __int64> >,std::allocator<std::Pair<unsigned __int64 const ,Player *> > >::operator[]+19
007F4784  00000000  AuctionHouseBot+F4
005F5452  00000000  World::Update+1D2
0043092E  00000000  WorldRunnable::run+8E
0089BDD9  00000000  ACE_Based::Thread::ThreadTask+19
00AC1B84  00000000  __WSAFDIsSet+FFFFFFFFFFFCCB4C
78543433  00000000  _endthreadex+44
785434C7  00000000  _endthreadex+D8
7C80B729  00000000  GetModuleFileNameA+1BA

Call stack:
Address   Frame     Function      SourceFile
7C90E514  00000000  KiFastSystemCallRet+0
7C802542  00000000  WaitForSingleObject+12
00A79C04  00000000  __WSAFDIsSet+FFFFFFFFFFF84BCC
00AE64AA  00000000  __WSAFDIsSet+FFFFFFFFFFFF1472
00AE266F  00000000  __WSAFDIsSet+FFFFFFFFFFFED637
0060E1AA  00000000  WorldSocketMgr::Wait+4A
7214D1C4  00000000  0000:00000000 
7214D1C4  00000000  0000:00000000 
6C696146  00000000

NetSky · October 29, 2009

if you use my latest version of this patch you should not have any crashes / crashes only occure with outdated versions of this patch

DaemonCantor · October 29, 2009

As of yesterday I patched NetSky's Vehicles patch in with 8746, it's been up and running with no errors on UDB's 384 DB's for a little bit over 24 hours. it also has Dual_Specialization patch, and ahbot as well as the new pet branch and over 75 people has logged in with no problems or crashes....Great Job NetSky and Every one else whos helped make this.

Null · October 30, 2009

if you use my latest version of this patch you should not have any crashes / crashes only occure with outdated versions of this patch

I used the last version of this patch,but core crased everytime

yad02 · October 30, 2009

in your crash log : 007F4784 00000000 AuctionHouseBot+F4

Are you sure that is really due to vehicle patch ?

Does your auctionhousebot patch is correctly configured ?

Your must edit your mangosd.conf file with existing player guid and account id.

You can disable auctionhousebot patch using guid = 0 and id = 0.

NetSky · October 30, 2009

As of yesterday I patched NetSky's Vehicles patch in with 8746, it's been up and running with no errors on UDB's 384 DB's for a little bit over 24 hours. it also has Dual_Specialization patch, and ahbot as well as the new pet branch and over 75 people has logged in with no problems or crashes....Great Job NetSky and Every one else whos helped make this.

this is not yet finished there are lot of outstanding improvements which need to be done till you can call this 'finished' ^^

i will start working with generic dbcs and correcting standstates @ vehicle enter/leave today - sry but i was busy updating acelibs

yad02 · October 30, 2009

Hello NetSky

Why you don't use git branch to push your patch ?

In any case thank you to review this patch

NetSky · October 30, 2009

Hello NetSky
Why you don't use git branch to push your patch ?

i use git but its not public ^^

VenT · October 30, 2009

NetSky, i use your patch, its great,thx but if have a bit of trouble with vehichles... I cant sit on Salvaged Demolisher, Salvaged choppet and etc, because my cursor not VehicleCursor ( sorry for my english =) ).

NetSky · October 30, 2009

yes that's correct you need correct npc_spellclick table data for this i cannot provide data for at the moment maybe udb or someone else could

traponinet · October 30, 2009

update for Ulduar's vehicles

found these from getmangos.ru and thank them, that they share it

-- Salvaged Chopper
REPLACE INTO npc_spellclick_spells VALUES
(33062, 52196, 0, 0, 0, 0);
REPLACE INTO creature_template_addon VALUES
(33062, 0, 0, 0, 0, 0, 335, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(335, 12, 62974, 62286, 62299, 64660, 0, 0, 0, 0, 0, 0, 0); 
REPLACE INTO vehicle_seat_data VALUES
(3005, 1);

-- Salvaged Demolisher
REPLACE INTO npc_spellclick_spells VALUES
(33109, 52196, 0, 0, 0, 0);
REPLACE INTO creature_template_addon VALUES
(33109, 0, 0, 0, 0, 0, 338, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(338, 12, 62306, 62490, 62308, 62324, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3011, 1);

-- Salvaged Siege Engine
REPLACE INTO npc_spellclick_spells VALUES
(33060, 52196, 0, 0, 0, 0); 
REPLACE INTO creature_template_addon VALUES
(33060, 0, 0, 0, 0, 0, 336, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(336, 12, 62345, 62522, 62346, 0, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3006, 1);

and two Mammoths like vehicles, they maybe have two-seat? (not tested yet)

-- Traveler's Tundra Mammoth
REPLACE INTO npc_spellclick_spells VALUES
(32633, 52196, 0, 0, 0, 0);
REPLACE INTO creature_template_addon VALUES
(32633, 0, 0, 0, 0, 0, 312, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(312, 12, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

-- Grand Ice Mammoth
REPLACE INTO npc_spellclick_spells VALUES
(31857, 52196, 0, 0, 0, 0);
REPLACE INTO creature_template_addon VALUES
(31857, 0, 0, 0, 0, 0, 312, NULL, NULL);

BloodLord · October 31, 2009

HI all i am getting the following error:

9>d:\\insider42-mangos-4cfc460\\src\\game\\ObjectMgr.h(845) : error C2086: 'uint32 ObjectMgr::m_hiVehicleGuid' : redefinition
9>        d:\\insider42-mangos-4cfc460\\src\\game\\ObjectMgr.h(840) : see declaration of 'ObjectMgr::m_hiVehicleGuid'
9>Build log was saved at "file://d:\\insider42-mangos-4cfc460\\win\\VC90\\game__Win32_Release\\BuildLog.htm"
9>game - 1 error(s), 0 warning(s)
10>------ Build started: Project: mangosd, Configuration: Release Win32 ------
10>Compiling...
10>WorldRunnable.cpp
10>WheatyExceptionReport.cpp
10>RASocket.cpp
10>Master.cpp
10>Main.cpp
10>CliRunnable.cpp
10>d:\\insider42-mangos-4cfc460\\src\\game\\ObjectMgr.h(845) : error C2086: 'uint32 ObjectMgr::m_hiVehicleGuid' : redefinition
10>        d:\\insider42-mangos-4cfc460\\src\\game\\ObjectMgr.h(840) : see declaration of 'ObjectMgr::m_hiVehicleGuid'
10>d:\\insider42-mangos-4cfc460\\src\\game\\ObjectMgr.h(845) : error C2086: 'uint32 ObjectMgr::m_hiVehicleGuid' : redefinition
10>        d:\\insider42-mangos-4cfc460\\src\\game\\ObjectMgr.h(840) : see declaration of 'ObjectMgr::m_hiVehicleGuid'
10>Build log was saved at "file://d:\\insider42-mangos-4cfc460\\win\\VC90\\mangosd__Win32_Release\\BuildLog.htm"
10>mangosd - 2 error(s), 0 warning(s)
11>------ Build started: Project: script, Configuration: Release Win32 ------
11>Compiling...
11>sc_default.cpp
11>system.cpp
11>ScriptMgr.cpp
11>d:\\insider42-mangos-4cfc460\\src\\bindings\\universal\\../../game/ObjectMgr.h(845) : error C2086: 'uint32 ObjectMgr::m_hiVehicleGuid' : redefinition
11>        d:\\insider42-mangos-4cfc460\\src\\bindings\\universal\\../../game/ObjectMgr.h(840) : see declaration of 'ObjectMgr::m_hiVehicleGuid'
11>Build log was saved at "file://d:\\insider42-mangos-4cfc460\\win\\VC90\\script__Win32_Release\\BuildLog.htm"
11>script - 1 error(s), 0 warning(s)

Do anyone know what do i have to change to fix it?

roby10 · October 31, 2009

it's not quite corect ... with spell 52196....anyway ty i'll test them

xarly · November 1, 2009

VEHICLES
Patch for [8722]

Author: Netsky

Link : http://www.file-upload.net/download-1966455/0001-Vehicle-Patch.patch.html

needed SQL : http://www.file-upload.net/download-1966904/mangos_vehicle_sql.zip.html

Notes :

- Visual Bytes are not yet properly updated

- still working on generic DBC support

Hi!

I have succesfully patched my core with this patch, and vehicles do what they should do, but i have a very very big problem:

Massacre at light point:

The cannons can shot but they can move, i mean, when I press "Up arrow" the cannon starts walking, etc...

Also I have applied ulduar vehicles with this

-- Salvaged Chopper
REPLACE INTO npc_spellclick_spells VALUES
(33062, 52196, 0, 0, 0, 0);
REPLACE INTO creature_template_addon VALUES
(33062, 0, 0, 0, 0, 0, 335, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(335, 12, 62974, 62286, 62299, 64660, 0, 0, 0, 0, 0, 0, 0); 
REPLACE INTO vehicle_seat_data VALUES
(3005, 1);

-- Salvaged Demolisher
REPLACE INTO npc_spellclick_spells VALUES
(33109, 52196, 0, 0, 0, 0);
REPLACE INTO creature_template_addon VALUES
(33109, 0, 0, 0, 0, 0, 338, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(338, 12, 62306, 62490, 62308, 62324, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3011, 1);

-- Salvaged Siege Engine
REPLACE INTO npc_spellclick_spells VALUES
(33060, 52196, 0, 0, 0, 0); 
REPLACE INTO creature_template_addon VALUES
(33060, 0, 0, 0, 0, 0, 336, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(336, 12, 62345, 62522, 62346, 0, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3006, 1);

Then they started to work, but if you go in raid group, the first can drive the vehicle but when the second one tries to drive other vehicle jump to the first's vehicle, i mean, apparently only one vehicle can be used at the same time

Have you check this?

Thank you

wolftang32000 · November 1, 2009

are those links on the first post on this topic is still good? or are they outdated?

morderek · November 1, 2009

I´m having some probles with the sql patch, it seems to be uncomplete, is it right or am i doing it wrong?

NetSky · November 1, 2009

Hi!
I have succesfully patched my core with this patch, and vehicles do what they should do, but i have a very very big problem:

Massacre at light point:

The cannons can shot but they can move, i mean, when I press "Up arrow" the cannon starts walking, etc...

Also I have applied ulduar vehicles with this
-- Salvaged Chopper
REPLACE INTO npc_spellclick_spells VALUES
(33062, 52196, 0, 0, 0, 0);
REPLACE INTO creature_template_addon VALUES
(33062, 0, 0, 0, 0, 0, 335, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(335, 12, 62974, 62286, 62299, 64660, 0, 0, 0, 0, 0, 0, 0); 
REPLACE INTO vehicle_seat_data VALUES
(3005, 1);

-- Salvaged Demolisher
REPLACE INTO npc_spellclick_spells VALUES
(33109, 52196, 0, 0, 0, 0);
REPLACE INTO creature_template_addon VALUES
(33109, 0, 0, 0, 0, 0, 338, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(338, 12, 62306, 62490, 62308, 62324, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3011, 1);

-- Salvaged Siege Engine
REPLACE INTO npc_spellclick_spells VALUES
(33060, 52196, 0, 0, 0, 0); 
REPLACE INTO creature_template_addon VALUES
(33060, 0, 0, 0, 0, 0, 336, NULL, NULL); 
REPLACE INTO vehicle_data VALUES
(336, 12, 62345, 62522, 62346, 0, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3006, 1);
Then they started to work, but if you go in raid group, the first can drive the vehicle but when the second one tries to drive other vehicle jump to the first's vehicle, i mean, apparently only one vehicle can be used at the same time

Have you check this?

Thank you

should not happen maybe check creature data

Null · November 2, 2009

Maybe add full sql updates to patch?

xarly · November 2, 2009

should not happen maybe check creature data

Sorry but, what exactly i should check? i mean, in sql or c++?

Maybe add full sql updates to patch?

Ihave added this sql http://www.file-upload.net/download-1966904/mangos_vehicle_sql.zip.html, posted by NetSky

Thankyou

aliendiplomat · November 2, 2009

Pretty essential idea for a patch. Haven't had a chance to test extensively, however I did notice a couple small issues with the included SQL update when attempting to apply to an 8763 database template.

Problem #1:

The file attempts to put values in the vehicle_id and passengers field for both the creature_addon and creature_template_addon tables, however neither of these tables have either of those columns in the default MaNGOS 8763 structure.

Here's what I ran to add them prior to running the SQL patch for vehicles:

-- MaNGOS 8763+ update
ALTER TABLE creature_template_addon ADD COLUMN vehicle_id int(11) unsigned NOT NULL DEFAULT '0' AFTER moveflags;
ALTER TABLE creature_template_addon ADD COLUMN passengers text AFTER vehicle_id;

ALTER TABLE creature_addon ADD COLUMN vehicle_id int(11) unsigned NOT NULL DEFAULT '0' AFTER moveflags;
ALTER TABLE creature_addon ADD COLUMN passengers text AFTER vehicle_id;

I'm intuiting the field types (someone please correct me if I'm off), though the core complains if passengers is set to an integer, and this way it works. (I'm guessing the passenger field is populated with a string of data representing multiple current passengers?)

Problem #2:

You appear to have started to insert a section for people using UDB at the end (?), however it was cutoff before the completion of the query. This resulted in the 28887 and 28833 creatures being deleted and replaced with nothing.

-- UDB
DELETE FROM `creature` WHERE `id` IN (28887,28833);
INSERT INTO `creature` (`guid`,`id`,`map`,`spawnMask`,`phaseMask`,`modelid`,`equipment_id`,`position_x`,`position_y`,`position_z`,`orientation`,`spawntimesecs`,`spawndist`,`currentwaypoint`,`curhealth`,`curmana`,`DeathState`,`MovementType`) VALUES
(130112, 28833, 609, 1, 1, 25723, 0, 2104.74, -6179.82, 13.47, 1.22173, 360, 0, 0, 26140, 0, 0, 0),
(130113, 28833, 609, 1, 1, 25723, 0, 2253.24, -6193.09, 13.4068, 1.85005, 360, 0, 0, 26140, 0, 0, 0),
(130114, 28833, 609, 1, 1, 25723, 0, 2264.77, -

To resolve I got rid of the DELETE query (since it isn't adding anything back for those ID's which were already modified earlier in the file and so clearly are necessary). I also trimmed off the section that got cut off, leaving the two insert lines that were completed.

There was also a minor issue with one of the above creatures, 28887, and the core complaining about incorrect low mana value. I changed `minmana` = 0 and `maxmana` = 0 which is what it was before this patch, instead of 2117/2117 which it attempted to change it to. I left the other values this patch modifies for creature 28887 as they were.

Here's the Vehicles SQL patch with these few changes made that you can run against an 8763+ version of the MaNGOS database structure without the aforementioned snags:

http://filebeam.com/d9fb3a4b77dc8febd8a453b21b067086

fullburned · November 2, 2009

I know it's useless but I'll give a try.

Have anyone come across efficient way to know vehicle id of some creature? Or maybe it's possible to know the actual visual view of vehicle from vehicle.dbc without sniffing data from off server?

Or maybe someone can explain how to properly use .debug spawnvehicle command?

That's seems to be one of the main troubles for me now, I have data for 5 quests but without knowing vehicle id for npc it's useless:(

xarly · November 2, 2009

I have applied aliendiplomat fix but is the same...

Some screenshots of my main problems

Sorry....

About Ulduar, on the other hand exist the problem that I said, and i have discovered one more thing. If one can drive a vehicle and go far, then the second drive another vehicle and can drive his own vehicle but if the second go near the first the second appears in the first's vehicle and then the same problem... very odd....

I know Ulduar vehicles are very complex, I hope someone could work on it.

Thank you very much

NetSky · November 3, 2009

I have applied aliendiplomat fix but is the same...
Some screenshots of my main problems

About Ulduar, on the other hand exist the problem that I said, and i have discovered one more thing. If one can drive a vehicle and go far, then the second drive another vehicle and can drive his own vehicle but if the second go near the first the second appears in the first's vehicle and then the same problem... very odd....

I know Ulduar vehicles are very complex, I hope someone could work on it.

Thank you very much

first : this is db stuff not related to code anyway

second : energy for vehicles is not yet correctly implemented

Xlayer · November 3, 2009

Third: Screenshots are forbidden here, please delete them.

xarly · November 3, 2009

Third: Screenshots are forbidden here, please delete them.

Sorry, screenshots deleted

Sign In

[Help] Implementing Vehicles

Recommended Posts

Link to comment

Share on other sites

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Recently Browsing 0 members

Contact Us

Repositories

Important Information