[fix][9053] allows ignite & living bomb, fireball & pyroblast dots to stack

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

allows stacking of dot parts of these spells

For which repository revision was the patch created?

7940

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=2305

Who has been writing this patch? Please include either forum user names or email addresses.

me - laise

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index f06073e..d42b7c9 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -1256,6 +1256,17 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons
                if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x0000000000010000)) && (spellInfo_2->SpellVisual[0] == 72 && spellInfo_2->SpellIconID == 1499) ||
                    (spellInfo_2->SpellFamilyFlags & UI64LIT(0x0000000000010000)) && (spellInfo_1->SpellVisual[0] == 72 && spellInfo_1->SpellIconID == 1499) )
                    return false;
+
+                // Living Bomb & Ignite (Dots)
+               if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x2000000000000)) && (spellInfo_2->SpellFamilyFlags & UI64LIT(0x8000000)) ||
+                   (spellInfo_2->SpellFamilyFlags & UI64LIT(0x2000000000000)) && (spellInfo_1->SpellFamilyFlags & UI64LIT(0x8000000)) )
+                   return false;
+                 
+               // Fireball & Pyroblast (Dots)
+               if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x1)) && (spellInfo_2->SpellFamilyFlags & UI64LIT(0x400000)) ||
+                   (spellInfo_2->SpellFamilyFlags & UI64LIT(0x1)) && (spellInfo_1->SpellFamilyFlags & UI64LIT(0x400000)) )
+                   return false;
+
            }
            // Detect Invisibility and Mana Shield (multi-family check)
            if( spellInfo_2->Id == 132 && spellInfo_1->SpellIconID == 209 && spellInfo_1->SpellVisual[0] == 968 )

[Auntie Mangos]

But I think it's about time we did away with all these hack checks in IsNoStackSpellDueToSpell...

Not to derail this patch because it still may be needed in the end, but if people could help me test this big patch, that would be great.

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

allows stacking of dot parts of these spells

For which repository revision was the patch created?

7940

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=2305

Who has been writing this patch? Please include either forum user names or email addresses.

me - laise

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index f06073e..d42b7c9 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -1256,6 +1256,17 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons
                if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x0000000000010000)) && (spellInfo_2->SpellVisual[0] == 72 && spellInfo_2->SpellIconID == 1499) ||
                    (spellInfo_2->SpellFamilyFlags & UI64LIT(0x0000000000010000)) && (spellInfo_1->SpellVisual[0] == 72 && spellInfo_1->SpellIconID == 1499) )
                    return false;
+
+                // Living Bomb & Ignite (Dots)
+               if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x2000000000000)) && (spellInfo_2->SpellFamilyFlags & UI64LIT(0x8000000)) ||
+                   (spellInfo_2->SpellFamilyFlags & UI64LIT(0x2000000000000)) && (spellInfo_1->SpellFamilyFlags & UI64LIT(0x8000000)) )
+                   return false;
+                 
+               // Fireball & Pyroblast (Dots)
+               if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x1)) && (spellInfo_2->SpellFamilyFlags & UI64LIT(0x400000)) ||
+                   (spellInfo_2->SpellFamilyFlags & UI64LIT(0x1)) && (spellInfo_1->SpellFamilyFlags & UI64LIT(0x400000)) )
+                   return false;
+
            }
            // Detect Invisibility and Mana Shield (multi-family check)
            if( spellInfo_2->Id == 132 && spellInfo_1->SpellIconID == 209 && spellInfo_1->SpellVisual[0] == 968 )

Help with patch... plz

Core Mangos 0-12 8348

When i patch it - error

[Sephiroth1983]

Thanks, this fix is needed.

[Syn]

Bump...

[Sephiroth1983]

Tested and works.

[Morphau]

Up ...

This patch it's still ok ?

[Cobra101]

Just tested with 8248 and still works fine. Bumpity time.

I don't see any issues. I vote for it being added. :cool:

[bulek]

tested and works add pls

[the nadie]

does this patch still works?

[VladimirMangos]

In [9053]. Thank you

[Syn]

Thanks Vladirmir

Christmas gift for Mages :lol: