[fixed][10237] Spell Flametongue weapon

[alein]

Hi.

MaNGOS/0.14.0 (* * Revision 8416 - *) for Linux_x64 (little-endian)
Using script library: ScriptDev2 (for MaNGOS 8273+) Revision [1369] 2009-08-24 13:52:29 (Unix)
Using World DB: PSDB WotLK (243)
Using creature EventAI: PSDB EventAI & ACID 3.0.0

Spell http://www.wowwiki.com/Flametongue_Weapon work on 50%.

It give spellpower bonus, but doesn't add fire damage to the weapon.

Best regards.

[hershaw121]

On latest rev this seems to do way too much damage, I've seen shamans doing 3.5K+ crits and when I look up to one WWS report like http://wowwebstats.com/v2jhpf4s1lkdm?s=67399-75299 (and click Vran, mostly T9 geared) his flametongue crits are about 1K+ pretty sure this guy know how to play his char

Just asked around on the server and shaman players (without even full T7 gears) told me flametongue are hitting for 1K+ (non crit)

[FullMetal]

sounds like the formula has to be reworked.

[Betaman2k]

core: 9582

100 % confirmed Spell Flametongue weapon make to much damage, i testes on my server crit 6000 in raid, in pvp crit 3000 ( t9 gear ) i checked on offi, same gear raid crit 2500 and pvp max 900-1000 ( crits )

[Forusim]

core: 9582

100 % confirmed Spell Flametongue weapon make to much damage, i testes on my server crit 6000 in raid, in pvp crit 3000 ( t9 gear ) i checked on offi, same gear raid crit 2500 and pvp max 900-1000 ( crits )

Same Rev, but Flametounge still does no dmg O_o

Do you use any patches?

[Lavi]

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 40019f6..1f8cfd9 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -7266,6 +7266,53 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu
                    spell->AddTriggeredSpell(63685);
                return true;
            }
+            // Flametongue Weapon
+            if (dummySpell->SpellFamilyFlags & UI64LIT(0x200000))
+            {
+                //checks
+                if(GetTypeId()!=TYPEID_PLAYER)
+                    return false;
+                    
+                if(!castItem || !castItem->IsEquipped())
+                    return false;
+
+                if(!pVictim || !pVictim->isAlive())
+                    return false;
+
+                float fonhit = dummySpell->EffectBasePoints[EFFECT_INDEX_0] / 100.0;
+
+                float addspd = SpellBaseDamageBonus(SPELL_SCHOOL_MASK_FIRE)
+                                     + SpellBaseDamageBonusForVictim(SPELL_SCHOOL_MASK_FIRE, pVictim);
+
+                // 1.3speed = 5%, 2.6speed = 10%, 4.0 speed = 15%, so, 1.0speed = 3.84%
+                addspd= addspd / 100.0 * 3.84;
+
+                // Enchant on Off-Hand
+                if ( castItem->GetSlot() == EQUIPMENT_SLOT_OFFHAND && isAttackReady(OFF_ATTACK))
+                {
+                    float WeaponSpeed = GetAttackTime(OFF_ATTACK)/1000.0;
+
+                    //tooltip + spd
+                    basepoints0 = int32( (fonhit * WeaponSpeed) + (addspd * WeaponSpeed) );
+                    triggered_spell_id = 10444;
+                }
+
+                // Enchant on Main-Hand
+                else if ( castItem->GetSlot() == EQUIPMENT_SLOT_MAINHAND && isAttackReady(BASE_ATTACK))
+                {
+                    float WeaponSpeed = GetAttackTime(BASE_ATTACK)/1000.0;
+
+                    //tooltip damage + spd
+                    basepoints0 = int32( (fonhit * WeaponSpeed) + (addspd * WeaponSpeed) );
+                    triggered_spell_id = 10444;
+                }
+
+                else
+                    return false;
+
+                CastCustomSpell(pVictim,triggered_spell_id,&basepoints0,NULL,NULL,true,castItem,triggeredByAura);
+                return true;
+            }
            break;
        }
        case SPELLFAMILY_DEATHKNIGHT:

author Viste from ru-mangos

[xeross155]

For 9652 http://www.mediafire.com/?w5u5qlmyymu

If it doesn't apply apply manually, contains some compilation fixes.

[Mathman]

Flametongue Weapon make too much damage with this patch

[darkstalker]

spell power is getting added twice there, once in code and other in database (spell_bonus_data)

[hershaw121]

Did some tests and this is looking very bad, did 7K+ DPS by just standing.

Recount looks something like this.

-Flametongue attack (count, damage, %) 111, 160846, 77.2%

-Melee (count, damage, %) 37, 19941, 9.6%

-Other skills 13.2%

As you can see every melee swing is making 2-3 Flametongue procs this can't be right.

[Lynx3d]

Several things not very nice or plain wrong in this patch, after a lot of work and many dead creatures, new implementation finally added to [10237].