Vehicles (Dev)

[iceis2]

have two repos of vehicles one is darkrulerzs and saj(w/insider42) and one is trap's stuff

(plain mangos) both current as of time of post

http://github.com/GMHAZE

since its been awhile and no one has complained 8) repos have been updated current to time of post and oculus drake quest has been added to vehicles

[tortosterone]

howdy iceis2, i just noticed after compiling your vehicle.git master branch that the issue with salja's repo still persists. Rogues do not gain combo points nor can warlocks accumulate soul shards... the vehicles do work and the occulus drakes dont have the spells linked with them.

[Christian Schamara]

hmm work Perfect i have no Bug

[traponinet]

Thx traponinet, but you can't switch/change seat in this patch.

Then you can use this patch, from Wojta's repository (branch vehicle)

maybe He has no time to update repository, (or do not want?)

but, warn you that still have conflict with dual-spec.

Thanks to Wojta naturally! (for vehicle patch)

[Thyros]

can someone create a github repo for the vehicle?

[traponinet]

I have not been correct for patches from @tester20 - patch 'some fix for ramm spells'

and from @Anti - patch 'energy, power, steam etc.'

Nothing wrong with these patches, still work correctly. Thanks tester20 and Anti for patches.

[lecails]

At last I understood what was in conflict with Dual-spec

this is a patch of 'tester20' 'some fix for ramm spells'

or patch of Anti for vehicle energy, power, steam etc.

remove the patches and Dual-spec will works!

Edit:

now I'm seek to resolve the problem. I want patches to stay and not to conflict with Dual-spec

Oki thanks trapi ! Im waiting your patch . Add your fix too (drake,occulus and other ..)

[iceis2]

ill reopen a new vehicle repo for pullers after trap has post a post i can use with the problem fixed repo has moved as ive decided go just go back to DB work and stay outta of the light...... anyways new link is http://github.com/fallenangelX

[lecails]

i can use with the problem fixed

Where have you see the problem is fixed ?

[Stillhard]

Then you can use this patch, from Wojta's repository (branch vehicle)

maybe He has no time to update repository, (or do not want?)

but, warn you that still have conflict with dual-spec.

vehicle patch for MaNGOS rev. 9795:

http://filebeam.com/f948cd0d4b5e767f94551d18112d26fb

Thanks to Wojta naturally! (for vehicle patch)

Thanks to both of you

At last I understood what was in conflict with Dual-spec

this is a patch of 'tester20' 'some fix for ramm spells'

or patch of Anti for vehicle energy, power, steam etc.

remove the patches and Dual-spec will works!

Edit:

now I'm seek to resolve the problem. I want patches to stay and not to conflict with Dual-spec

I'll inform here if i have them fixed too

[Wojta]

well, guys, I wanted to update my repo today, but I see you have made some patches for vehicles Anybody wants me to keep repo up-to-date or its not needed anymore?

[vladex]

yes ,of course

[iceis2]

i agree but what would be up with dual talent? 8)

[Wojta]

Dual spec is already in mangos master branch...so wheres problem?

[Darkruler]

Dual spec is already in mangos master branch...so wheres problem?

The problem is that you can't switch back to the first spec after you've switched to the 2nd one (caused by the Vehicle patch...verified by various users)

[traponinet]

well, guys, I wanted to update my repo today, but I see you have made some patches for vehicles Anybody wants me to keep repo up-to-date or its not needed anymore?

We can not continue without your vehicle development and please keep working on vehicle,

because I have not so much knowledge as you. No doubt in this that everybody wants You to keep repo up-to-date.

And if you have time, maybe an update once a week would be wonderful for us for now.

and finally many thanks for your work so far.

[iceis2]

http://github.com/fallenangelX/pbvehiclesahbotpull repo up for the pullers and newbies and those who just don't know 8) has pb ahbot and vehicles

[iceis2]

I think the patch is now ready for test:

vehicle patch for MaNGOS core [9796]

http://filebeam.com/b32b45a7c639862742c76ad08953aba8

Edit:

already there is no conflict with the Dual-spec. Thanks to Wojta (for vehicle patch)

oops later I saw, that Wojta will make update, but I'm already done.

just wanted to take this time to say ty to woj and trap for all the work they do

[cyrex]

When you say ready for test, do you mean players can now share vehicles, like motorcycle and mammoth, do DK quests, ulduar and wintergrasp?

[iceis2]

add oculus quest support to it prety sure its fixed to

[lecails]

Is there a solution for dual spe conflict ?

[Unkle Nuke]

There's like what, 4 or 5 people working on Vehicles with just as many repositories?

I'm all for collaboration, guys, but this is getting downright confusing! How about someone sets up a testing repository so all of you can push commits there, instead of all over the place? Those commits that don't break things and improve Vehicles can then be reviewed by Wotja for inclusion into his master repo for Vehicles. Consider Wotja's Vehicles to be the "stable" branch.

If things continue in their present fashion, you'll never get this thing done!

[Darkruler]

There's like what, 4 or 5 people working on Vehicles with just as many repositories?

I'm all for collaboration, guys, but this is getting downright confusing! How about someone sets up a testing repository so all of you can push commits there, instead of all over the place? Those commits that don't break things and improve Vehicles can then be reviewed by Wotja for inclusion into his master repo for Vehicles. Consider Wotja's Vehicles to be the "stable" branch.

If things continue in their present fashion, you'll never get this thing done!

I totally agree... and i think Traponinet (if he/she wants to) should start the repo and add collaborators that can prove theirselves

[fabian]

no I can't confirm this bug. It works fine, no problem with the vehicle patch

[traponinet]

When you say ready for test, do you mean players can now share vehicles, like motorcycle and mammoth, do DK quests, ulduar and wintergrasp?

I mean to test vehicle patch for the problem with Dual-spec

The patch made the vehicle to work well, nothing more! the rest is done by the database

example:

/* Wintergrasp Tower Cannon */
DELETE FROM npc_spellclick_spells WHERE npc_entry IN (28366);
INSERT INTO npc_spellclick_spells VALUES
(28366, 60968, 0, 0, 0, 1);
REPLACE INTO creature_template_addon VALUES
(28366, 0, 0, 0, 0, 0, 160, NULL, NULL);
REPLACE INTO vehicle_data VALUES
(160, 5, 51362, 51421, 0, 0, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(2029, 1);

/* Salvaged Siege Turret */
DELETE FROM npc_spellclick_spells WHERE npc_entry = 33067;
INSERT INTO npc_spellclick_spells VALUES
(33067, 67373, 0, 0, 0, 1);
REPLACE INTO creature_template_addon VALUES
(33067, 0, 0, 0, 0, 0, 337, NULL, NULL);
REPLACE INTO vehicle_data VALUES
(337, 5, 62358, 64677, 62359, 0, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_data VALUES
(336, 4, 62345, 62522, 62346, 0, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3006, 1),
(3010, 1),
(4026, 8),
(4027, 8),
(3009, 8);
UPDATE `creature_template` SET `minhealth` = 1134000, `maxhealth` = 1134000 WHERE `entry` = 33067;
UPDATE `creature_template` SET `unit_flags` = 16384 WHERE `entry` = 33067;
DELETE FROM `creature` WHERE `id`= 33067;

/* Gunner Salvaged Demolisher */
DELETE FROM npc_spellclick_spells WHERE npc_entry IN (33167);
INSERT INTO npc_spellclick_spells VALUES
(33167, 67373, 0, 0, 0, 1);
REPLACE INTO creature_template_addon VALUES
(33167, 0, 0, 0, 0, 0, 345, NULL, NULL);
REPLACE INTO vehicle_data VALUES
(345, 5, 62634, 64979, 62479, 62471, 0, 62428, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_data VALUES
(338, 4, 62306, 62490, 62308, 62324, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3077, 1),
(3106, 8);
REPLACE INTO vehicle_seat_data VALUES
(3011, 1),
(3146, 8),
(3013, 8),
(3147, 8);
UPDATE `creature_template` SET `unit_flags` = 16384 WHERE `entry` = 33167;
UPDATE `creature_template` SET `minhealth` = 630000, `maxhealth` = 630000 WHERE `entry` = 33167;
DELETE FROM `creature` WHERE `id`=33167;

Note: in unifieddb 'Wintergrasp Tower Cannon' are not yet spawned.

vehicle+mount still not works and you can not take passenger with your mount bike

and all species of Mammoths are no longer vehicle, they are only mount.

btw

If you want the player when leaving the vehicle to go down near the vehicle, then use this patch:

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 5e4f22a..2d5545d 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -13691,8 +13691,8 @@ void Unit::ExitVehicle()

        float x = GetPositionX();
        float y = GetPositionY();
-        float z = GetPositionZ() + 2.0f;
-        GetClosePoint(x, y, z, 2.0f + v_size);
+        float z = GetPositionZ();
+        GetClosePoint(x, y, z, 0);
        SendMonsterMove(x, y, z, SPLINETYPE_NORMAL, SPLINEFLAG_WALKMODE, 0);
    }
}