[BUG] Mobs follow on fly

[byterider]

Mangos Version: 9034 (linux x86_32)

SD2 Version: 1513

Database Version: YTDB 524

Hello there,

When in fly on the ground and a mob gonna attack me, the mob follows me into the sky.

The combat should stop when I gonna fly into the sky.

Here a image.

Thank you for reading.

Greetz

byte

[byterider]

isn't that a critical Bug?

[dardennf]

The worst .

Just kidding, but it's funny to see non-flying creatures follow the attacker.

PS : on retail creatures leave combat if the attacker takes off.

[TonyMontana5000]

i think this is a well known and for a long time existing bug.

Btw. Screenshots aren't allowed.

[byterider]

i think this is a well known and for a long time existing bug.

Btw. Screenshots aren't allowed.

oh sorry.

thanks NoFantasy for removing.

[NoFantasy]

creatures leave combat if the attacker takes off.

Can you be more specific on this?

- is it instant evade or do they stand still for a little while (like 2-5 seconds) before they evade?

- are there cases where creature attempt use ranged spell and can possibly knock player off the mount so he fall back on to the ground?

[dardennf]

I'm going to test it on retail .

[NoFantasy]

Lol, just some test code i figured wouldn't hurt to try:

 src/game/TargetedMovementGenerator.cpp |    6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/game/TargetedMovementGenerator.cpp b/src/game/TargetedMovementGenerator.cpp
index 10f2597..1a3b0c9 100644
--- a/src/game/TargetedMovementGenerator.cpp
+++ b/src/game/TargetedMovementGenerator.cpp
@@ -65,6 +65,12 @@ TargetedMovementGenerator<T>::_setTargetLocation(T &owner)
        i_target->GetClosePoint(x,y,z,owner.GetObjectSize(),i_offset,i_angle);
    }

+    if (owner.GetTypeId() == TYPEID_UNIT && !((Creature*)&owner)->canFly())
+    {
+        const Map* pMap = owner.GetBaseMap();
+        z = std::max(pMap->GetHeight(x, y, MAX_HEIGHT), pMap->GetWaterLevel(x, y));
+    }
+
    /*
        We MUST not check the distance difference and avoid setting the new location for smaller distances.
        By that we risk having far too many GetContactPoint() calls freezing the whole system.

It pretty much glue them to ground and follow you from there, instead of going up in to the air. For correctness, it's probably not right, but at least can give some idea how to make them move on the ground instead of following up in the air. No idea if it have any side-effects, but i assume there are.

[Lynx3d]

i've been thinking about trying to add something like that too, because there are unpretty things going on not only if you fly away.

If there's some vale or hill between you and the mob it will currently still just run to you in a straight line, either jumping through the air or sinking into the ground, and actually also die right there if killed with ranged attacks, possibly being unlootable.

Though you probably distort movement speed quite a bit by only adjusting the z value with constant horizontal movement speed...not to mention you'll have a lot of fun with proper vmap support-

[NoFantasy]

You must not mix up _destination point_ with the points in between. i_destinationHolder.SetDestination(traveller, x, y, z); is the destination, and it is in fact correct for this function.

What you are talking about is pathfinding, the generated points between current location and destination location, which is a far more complex issue, not really related to this topic at all

[dardennf]

Ok so, even if mobs have abilities like this one Living Lasher if you take off, the creature doesn't follow you and gets out of combat.

He goes instantly in evade mode, and he doesn't stay on the ground under the aggressor.

[digitalni]

This would be a very nice bug to fix indeed...

[NoFantasy]

Ok, thanks for testing dardennf. That means doing anything with movement generator is wrong. Instead, we must do proper check from isInAccessablePlaceFor() and make sure this is really used in SelectHostileTarget()

[Clerigon]

its a problem example

Anub'Rekhan use http://www.wowhead.com/?spell=28783 send to the air tank and the boss follow the tank in the air, this problem that sometimes the boss dies in air and can't loot it

[*dOoM*]

So this should work like this:

While you are in the air, non-flying npcs will aggro you only if they have a ranged spell and as long as you are in range of that spell. Once you gain height and get out of range they stop casting, evade and return to their original location. Pathing NPCs continue the path they were following.

Non flying NPCs that don't have any ranged spells won't aggro you until you are in melee range or if you are floating closely above the ground in aggro range. It will start hitting and following you until you gain height again. After you get out of range and thus out of combat, the NPC immediately evades and returns to its original place.

Getting dismounted by other players or NPCs trough transforming spells, knockbacks, stuns, nets etc. is not possible while flying. An exception are the bombing run quests.

In any case, NPCs that are NOT flagged for flying should not leave the ground whatsoever.

[byterider]

any news for that problem?

[dardennf]

We have take care about bump effect, the creature should not get out of combat.

By the way, if a creature has some ranged spell he won't cast it even if the player is in range.

[wowprivate]

I just tripped over this bug in Nagrand while testing.

It is quite annoying and if there is a voting list for bugs to fix, I would vote for this one!

Directly after voting for the annoying and infamous "Snake Trap Bug" to get fixed!!

;-)

[dardennf]

Ok forget what I've said... mobs can cast spell upon you if you are flying (not to far, the max range of the spell I think) above them.

[piroy1337]

well, this could be related to Pathfinding.

cause adds search for a Path, and if ur in air, they cant walk up

[faramir118]

This was on my list of things to do with pathfinding, but I think that there are other, faster ways to fix it similar to what NoFantasy posted above.

However, there is a problem with checking JUST the height.

Some monsters can throw you into the air high enough that they need to follow to keep attacking. (see http://www.wowhead.com/npc=5474#abilities)

If the target isn't in range, that ogre will just evade and reset even though the player wasn't really out of range.

So, you need to see if the player is actually flying, versus if he is falling, knocked back, etc.

[terakoth]

Hey I have to agree if there is one problem that must be fixed and because it is annoying this bug would take the cake lol.

[vanguard]

its a problem example

Anub'Rekhan use http://www.wowhead.com/?spell=28783 send to the air tank and the boss follow the tank in the air, this problem that sometimes the boss dies in air and can't loot it

When you kill an enemy in the air, his corpse should fall to the ground. Also, if a player dies in the air his corpse should fall to the ground too.