[Spirit Guide] Spirit Heal

[Auntie Mangos]

there was some bug with the grid searcher in aoe spells, they didnt select targets when caster and target are on different grid (Chain-Lightning-%28target-chain-damage%29"]see this) it might be happening here

[Auntie Mangos]

there was some bug with the grid searcher in aoe spells, they didnt select targets when caster and target are on different grid (Chain-Lightning-%28target-chain-damage%29"]see this) it might be happening here

Ok but according to this, spirit guide should resurrect some players and not others if they are in "right" and "wrong" grid ?

But when spirit guide doesn't cast spell, nobody is resurrected , no matter of the distance or grid where they are.

So ?

[dardennf]

Mangos Version: 9238

SD2 Version: 1555

Database Name and Version : YTDB 255

How it SHOULD work: Resurrects all friends within 20 yards.

How it DOES work: Sometimes nothing happens even if we are very close from the spirit guide.

[przemratajczak]

i can confirm it on 9110, from time to time players from opposite faction can even aggro battleground healer using AoE

[Revils]

I can confrim too, often the spirt doesn't automatically cast http://www.wowhead.com/?spell=2584

[balrok]

sounds for me like the problem is mostly, that people can aggro the spiritguide.. this bug might be new, since the spiritguides aren't dead now anymore..

this is the only explanation i have for this... since those spritguides have this in their ai

void UpdateAI(const uint32 uiDiff)

{

// auto cast the whole time this spell

if (!m_creature->GetCurrentSpell(CURRENT_CHANNELED_SPELL))

m_creature->CastSpell(m_creature, SPELL_SPIRIT_HEAL_CHANNEL, false);

if the aggroing is 100% reproducible, it would be good to find out which functions are called, then we can add exceptions for the isInvisibleForAlive auras.. or maybe check in those aggro-cases if units can see each other...

ps: an idea how to hackfix this:

diff --git a/scripts/battlegrounds/battleground.cpp b/scripts/battlegrounds/battleground.cpp

index 0e8daef..1493b6b 100644

--- a/scripts/battlegrounds/battleground.cpp

+++ b/scripts/battlegrounds/battleground.cpp

@@ -53,8 +53,16 @@ struct MANGOS_DLL_DECL npc_spirit_guideAI : public ScriptedAI

{

}

+ void Aggro(Unit *who)

+ {

+ //Don't do anything

+ }

+

void UpdateAI(const uint32 uiDiff)

{

+ if (!m_creature->getThreatManager().isThreatListEmpty())

+ EnterEvadeMode();

+

// auto cast the whole time this spell

if (!m_creature->GetCurrentSpell(CURRENT_CHANNELED_SPELL))

m_creature->CastSpell(m_creature, SPELL_SPIRIT_HEAL_CHANNEL, false);

[Forusim]

I had same issue on my server with the alliance spirit guide in warsong.

The problem was missing npcflag (32768) for that spirit guide.

Check this in your database.

[dardennf]

No npcflag are good, I think darkstalker is right, we need an improvement of the current grid system.

[Syn]

Also AoE kill him.

[dardennf]

Still bugged in 9415.

[Wojta]

wrong grid search :D

one of devs of our server, frca, figured out it happens because spell has 30s duration and ressurect is triggered at 30s too. Sometimes spell update is just not fast enough, thought.

So, I just set spirit healer to cast http://www.wowhead.com/?spell=22012 every 30s, and problem is gone

EDIT: check that at least one periodic tick was triggered would be much better, in fact change healer's script was just test, i did not believed that it will work.

[Morphau]

So, I just set spirit healer to cast http://www.wowhead.com/?spell=22012 every 30s, and problem is gone

Can you share a patch please ?

Thanks

[Wojta]

He just add http://github.com/Tasssadar/Valhalla-Project-ScriptDev2/commit/aeca98eaf64e24ec3f694b604d788e8f82024327 this into SD2 script, I dont wanna write patch for auras in mangos right now, maybe tomorrow.

[balrok]

http://github.com/Tasssadar/Valhalla-Project-ScriptDev2/commit/aeca98eaf64e24ec3f694b604d788e8f82024327

is working?

i've found at least one bug with spiritguides, but i know, that it didn't fix the resurrection fully.. since it's very hard to reproduce it would be nice if someone has more information..

[dardennf]

I'll try to test it as soon as possible.

[Raynar]

He just add http://github.com/Tasssadar/Valhalla-Project-ScriptDev2/commit/aeca98eaf64e24ec3f694b604d788e8f82024327 this into SD2 script, I dont wanna write patch for auras in mangos right now, maybe tomorrow.

Works great!