[patch] Spell_damage_class_none Bug Fix

[Auntie Mangos]

Examples:

46008, this is a shadow damage spell, but it never miss/resist

43150, this is a physical damage spell, it never miss/crit/dodge

Please see bug report:

http://getmangos.eu/community/viewtopic.php?id=28637

Index: Unit.cpp
===================================================================
--- Unit.cpp                (revision 6412)
+++ Unit.cpp                (working copy)
@@ -2827,87 +2766,44 @@
//                                                 return MeleeSpellHitResult(pVictim, spell);
                                                return SPELL_MISS_NONE;
                                case SPELL_DAMAGE_CLASS_NONE:
+                                                return SPELL_MISS_NONE; // This is not a hack, this is what it should be
                                case SPELL_DAMAGE_CLASS_MAGIC:
                                                return MagicSpellHitResult(pVictim, spell);
                }
                return SPELL_MISS_NONE;
}

[Sephiroth1983]

maybe there is an attribute flag for what you state in spell.dbc?

[megamage]

You may check any SPELL_DAMAGE_CLASS_NONE spells and you will find none of them should miss. There is no flag. It is the property of such spells, just like class_magic can be resist and class_physical can be dodge

[laise]

in [9675]. Thanks =)