[Patch] Support for npc on transport

[Unkle Nuke]

So this is yet another feature that will be implemented by porting over from Trinity?

I'd rather not see that become a habit. Sometimes, their code is such a mess to port that a developer can likely find a better way of doing it from scratch in less time. If this keeps up, half of the core code will be nothing more than Trinity with a few name changes to variables and functions.

We need better innovation from this community!

[Schmoozerd]

why do you think these projects keep stucking and won't get accepted..

If a contributor has not more imagination than to port from trinity and _if_ this part in trinity is shit, well, then the patch won't be much better off

[Lynx3d]

We need better innovation from this community!

Sorry i forgot, what was the last innovation you contributed?

Code won't write itself. And writing good code is harder than adding lots of hacks that give the impression as if it was working.

I did briefly look at this stuff and IMHO there's not all that much to build on yet.

You don't need any weird extra table, transports do already have a "virtual" mapid assigned, it will be possible to spawn them like any other creature if you write proper core code.

Also the really difficult part is syncing transport movement properly, infact players are not properly updated either currently.

I see none of that really addressed properly here or in trinity...unless something has signifficantly changed lately.

[Curious]

(happy 300th post)

If we will be able to spawn transports (or did i missed something) that means that the one who are working now are spamned right ?

And what do you mean by saying player aren't properly update as for now ?

[shauren]

We need better innovation from this community!

Sorry i forgot, what was the last innovation you contributed?

Code won't write itself. And writing good code is harder than adding lots of hacks that give the impression as if it was working.

I did briefly look at this stuff and IMHO there's not all that much to build on yet.

You don't need any weird extra table, transports do already have a "virtual" mapid assigned, it will be possible to spawn them like any other creature if you write proper core code.

Also the really difficult part is syncing transport movement properly, infact players are not properly updated either currently.

I see none of that really addressed properly here or in trinity...unless something has signifficantly changed lately.

i dont think anything changed, in any case both TC and mangos transport system is a hack on mapmanager so its only adding hack to hack

[Lynx3d]

And what do you mean by saying player aren't properly update as for now ?

Just go on a zeppelin, do NOT move and watch for creatures nearby...they will all disappear because the client does not send movement updates and so the server thinks you are still standing where the zeppelin started.

There's only some commented code in Transport::Update(), i guess i didn't really work, since no one implemented the actualy spline movement, so positions would be far off anyway.

[vladex]

they don,t disappear to me but just remain flying and passing through every object.

[Unkle Nuke]

Well, gee, Lynx. If you'd like to make this into a code pissing contest, then we're already doing more harm than good.

I did say "community". That includes us all, even me and you, does it not?

[ankso]

Full table `creature_transport`

Work patch fom Trnity

Can you or anyone reupload the link or point me to TC commits? I can try to adapt the patch. I need this to port correctly IC.

[Skirnir]

Start searching here: http://code.google.com/p/trinitycore/source/detail?r=dabd3bb43a Obvious others followed. I don't follow this project just searched this revision for you, hoping something productive follows :-)

Regards

Skirnir

[sart13]

trinitycore patch based on fully wrong mechanic...

[ankso]

trinitycore patch based on fully wrong mechanic...

I know, but as long as transport system is a hack, the only way to implement this things is using more hacks. I have tried to renew transports system, but it was imposible to me.

[Neo2003]

First of all, don't alter creature table structure. You just need a column in transport table, that's it.

Let's says you have some npc on boat 176231.

In transport table, add a 'map' column to associate the boat id and the moving map id.

Here 176231 is map 584.

Then in creature table, you don't have to alter anything, just spawn the npcs based on map 584 coords, then it's "just" a matter of sending to the client the proper information with transport guid, local and global coords (related to the moving map 584 and the upper map).

[shauren]

you dont need even that.

map id is in gameobject_template.data6

[Neo2003]

Good news. I did not know since it was not the case when I worked on bit on this long ago.

[ansonic]

Update this pacth

Thank

[ankso]

Update this pacth

Thank

Update it yourself or at least use "please"...

[Walkum]

Please, anyone can tell me that this patch works correctly? Thanks.

[Unkle Nuke]

This patch is no longer compatible with recent MaNGOS revisions. Even if it were updated, there is still a lot of work to be done for this feature to function correctly.

[sart13]

more recent variant of this patch your may find in https://github.com/KioM/mangos/commits/master

(http://ru-mangos.ru/showthread.php?t=4783)

But this - only rework of old patch, based on principially wrong base...

[Walkum]

Ok thx for the answers ^^

[ZPS]

Actually, the latest version is here https://github.com/bwsrv/mangos/commits/transport

But as rsa said, this is only adapted old patch.

[amaru]

And what do you mean by saying player aren't properly update as for now ?

Just go on a zeppelin, do NOT move and watch for creatures nearby...they will all disappear because the client does not send movement updates and so the server thinks you are still standing where the zeppelin started.

There's only some commented code in Transport::Update(), i guess i didn't really work, since no one implemented the actualy spline movement, so positions would be far off anyway.

Actually, they disappear because transport in server-side uses waypoints, and servers sends update data when this waypoint is reached. (Client has exact coordinates of transport every time)

This means, when you are about to reach waypoint X, creature data and transport go data still matches coordinates as if in waypoint X-1. When you try to move or change orientation, new movementinfo is received from client, which makes your player relocate.

In most cases distance between those two waypoints is larger than visibility distance in map, so npcs disappear.

However, if you see npcs on transport and stand still, they wont disappear, that's because player movementinfo updates only upon reaching waypoint.

In trinity there is a bad hack, which makes transport and npc on in relocate on every movementinfo send from any passenger on it, transport position taken from it. If you move everytime, you will see the npcs But if you fly nearby and follow transport path, they will disappear eventually.

Perhaps, with SilverIce's spline movement somebody can fix transport update system.

[Unkle Nuke]

Good advice amaru.

Thanks to SilverIce, and others, there's been progress made on movement handlers, but still a lot of work to be done before I think there will be a solid foundation to build a better version of this patch.