Death Bug Fix

[bulek]

Death Bug

Mangos Rev: 8763+, and with newest problem too

Custom Patches: NO

autor:insider42

Problem:

If you try to cast a spell whem you are reciving the last hit, you got a bug "undead", you got all dead flags but you corspe don't become a ghost.

´´Killing, killing, killing, hitting keys like fool, you're about to die but you stay around 1-200health, stats are the same but no regen, you can cast spells but you don´'t take any damage, you cannot move and you cant release spirit

fix:

diff --git a/src/game/Player.cpp b/src/game/Player.cpp
index d8773cd..33a4341 100644
--- a/src/game/Player.cpp
+++ b/src/game/Player.cpp
@@ -1271,6 +1271,11 @@ void Player::Update( uint32 p_time )
        RegenerateAll();
    }

+    if (!isAlive() && !HasFlag(PLAYER_FLAGS, PLAYER_FLAGS_GHOST))
+    {
+        SetHealth(0);
+    }
+
    if (m_deathState == JUST_DIED)
    {
        KillPlayer();

[Morphau]

The author it's insider42 ...

[Forusim]

Good patch, should be in master.

[bulek]

The author it's insider42 ...

thank you ,edited first post

and thank insider42

[Wojta]

Good patch, should be in master.

No, it should not. Insider42 did not posted it to "..under review" because its hack - we need to find source of this, not just place something on it and be happy, thats TrinityCore way.

If you try to cast a spell whem you are reciving the last hit,

can somebody confirm this?

[FragFrog]

Confirmed here Wojta - mostly happens to priests & mages in arenas on our server. Had this bug ever since we updated from 8719 to 9382 (TBC branch) a few weeks ago. The patch prevents it as far as I can tell, though as you said, in a hacky way. That's fine by me (got about two dozen 'hackish' fixes on our server to prevent some of the bigger bugs) but of course not suitable for master

[stefan91]

hmmmm, I can also confirm this, it seams that the killing blow and the spell cast must occur at the same time for this bug to appear. Example: bg match, and I am healer, I am spamming my healing wave just to stay alive but someone kills me. And coz I was spam clicking on my healing wave button I end up in death bug. So I guess when the server gets 2 commands (one to cast the spell and the other that the player is dead) at the exact same time death bug happens.

[cyrex]

Can anybody tell me if after using this patch the Death Bug is gone forever?

[wow4]

Can anybody tell me if after using this patch the Death Bug is gone forever?

it will be gone as long as you use the patch

[The_Game_Master]

Use your server with log level 3 and start testing. When it will happen you'll find the cause.

[bulek]

Can anybody tell me if after using this patch the Death Bug is gone forever?

yes,confirm

[bulek]

bump,

iam tested with newest core, and any problem , death bug, fixed

[darkstalker]

this causes some strange "death bug" mode after leaving arena (if you released inside)

[bulek]

this causes some strange "death bug" mode after leaving arena (if you released inside)

any confirm this?

[Forusim]

this causes some strange "death bug" mode after leaving arena (if you released inside)

If you mean the release window, which counts to 0 and then stay infront of your ui... this was before this fix, also.

[Wowka321]

It happened cuz somewhere in code client don't right inform about health after deal damage. About one year ago i looking source of this issue, but can't find ((. and wrote this hack(in other case maybe not hack ).

[Forusim]

I am 100% OK with this "hack" till mangos will solve this VERY annoying BUG!

[bulek]

I am 100% OK with this "hack" till mangos will solve this VERY annoying BUG!

This is true, but this will never come to master, it is a way to hack fix, you can do to apply yourself, dont be lazy:), otherwise I can confirm, works perfectly with last revision, any crashes, freezes and other problems

[bulek]

problem still in 10k + revision

bug found on all revision

[Micks]

any update for this patch? not working anymore