[patch] Store creature power type in DB

[zergtmn]

This patch allows to specify creature power type (mana, energy, etc.) via field in creature_template. Uses same values as Powers enum.

Some remarks:

unk17 in creature cache is actually power_mod. For example http://www.wowhead.com/npc=33109 has power_mod = 0.5 in WDB.

max energy (100) * power_mod (0.5) = 50 pyrite max, that's right.

http://www.wowhead.com/npc=29859 has power_mod = 1 -> 100 energy as usual.

So I decided to use power_mod for calculating max energy.

Examples of creatures that have energy bar:

http://www.wowhead.com/npc=29840

http://www.wowhead.com/npc=37813

http://www.wowhead.com/npc=34472

http://www.wowhead.com/npc=34454

http://www.wowhead.com/npc=38200

Patch: http://paste2.org/p/1010938

SQL:

ALTER TABLE creature_template
 ADD COLUMN `PowerType` tinyint(3) unsigned NOT NULL default '0' AFTER `MaxHealth`,
 CHANGE COLUMN `unk16` `health_mod` float NOT NULL default '1',
 CHANGE COLUMN `unk17` `power_mod` float NOT NULL default '1';

[zergtmn]

Ok, I have found out that Blizz use spells like http://www.wowhead.com/spell=72242 for disabling power regen. So regeneration for creatures and vehicles can be implemented in the same way.

First post updated.

[KiriX]

Thanks! Realy great patch.

Need add to git!

[fdb_]

Nice patch

[KiriX]

This sould fix DK pet and very usefull for a future (for impliment vehicle). Why dev don't commetns this?

[qsa]

Tested, working as expected.

Overall, nice patch to have, unless there is other source for this data (non I know of).

[Toinan67]

You got qsa's support, you can die in peace!

More seriously, patch is nicely done. I will test it in a few minutes

Little question however :

Regenerate(getPowerType());

This Regenerate method is never, and will (probably?) never be called with another argument than the current power type of the creature.

Since Regenerate does not override Unit::Regenerate method, we could replace it with :

RegenerateCurrentPower();

void Creature::RegenerateCurrentPower()
{
   uint32 power = getPowerType();
   ...

And btw, would be nice to actually move Regenerate from Creature and Player to Unit, no?

Edit : tested, works fine.

[fdb_]

Maybe moving it to unit to also handle vehicles power types in future ?

[Patman128]

Maybe moving it to unit to also handle vehicles power types in future ?

Isn't Vehicle a subclass of Creature?

http://github.com/mangos/mangos/blob/master/src/game/Vehicle.h

class Vehicle : public Creature

So not sure what you're talking about.

[fdb_]

hehe you right

[Toinan67]

Little bump, it would be nice to have a dev comment

[zhenya``]

powertype can by extracted from UNIT_FIELD_BYTES_0.

Powers getPowerType() const { return Powers(GetByteValue(UNIT_FIELD_BYTES_0, 3)); }.

not need to store it..

[zergtmn]

powertype can by extracted from UNIT_FIELD_BYTES_0.

Powers getPowerType() const { return Powers(GetByteValue(UNIT_FIELD_BYTES_0, 3)); }.

not need to store it..

At first we need somehow set it to correct value.

[Undergarun]

Nice, it works ^^

[zhenya``]

powertype can by extracted from UNIT_FIELD_BYTES_0.

Powers getPowerType() const { return Powers(GetByteValue(UNIT_FIELD_BYTES_0, 3)); }.

not need to store it..

At first we need somehow set it to correct value.

sniffer

[kid 10]

/bump

It's time to implement this important feature.

[Darkknight900]

patch link is dead, need new one

would like testing it.