[BUG]Vanish

[ascent]

rev 10408
sd2

no combat is ok, but combat start is skill is pack up, don't have hide aura.

combat start - > can't cast Hide skill.

ex) Sap, hide bla~

[Flemzard]

I can confirm in 0.12 too

Vanish really work out of combat only

EDIT: Maybe due to this commit http://github.com/mangos/mangos/commit/e27be3cbf91d74f1806a99460bbf039b8892d6fc ?

[ifilgud]

I'm searching for the possible reason, and I think it is caused by the commit Flemzard said. Spell effect 18461 casts spell 1784 which can't be cast on combat so the cast fails. Maybe a special case is needed for spell 1784 or maybe that spell should be casted after getting you out of combat.

[ifilgud]

Can a triggered Spell be casted while in combat without being previously checked by the client? If it cant, the commit can be changed so the IF in Spell.cpp (checkCast function) may also include m_triggeredSpell, solving the problem

[Flemzard]

I've follow your reflexion ifilgud, and yes it's works

here my patch for 0.12 -> https://gist.github.com/10ccec53138076439c97

[ifilgud]

I made exactly that change in my server as a temporary fix until the MaNGOS team applies the final solution

[ascent]

I've follow your reflexion ifilgud, and yes it's works

here my patch for 0.12 -> https://gist.github.com/10ccec53138076439c97

thx, ^^ good work.

[Mr.Grom]

This fix

+    if (m_unitTarget && m_unitTargetGUID != caster->GetObjectGuid() &&
+        !m_unitTarget->isVisibleForOrDetect(caster, caster, false))
+            m_unitTarget = NULL;

[ascent]

This fix

+    if (m_unitTarget && m_unitTargetGUID != caster->GetObjectGuid() &&
+        !m_unitTarget->isVisibleForOrDetect(caster, caster, false))
+            m_unitTarget = NULL;

where is input this code?

[ifilgud]

Maybe wrong topic?

[Tman]

Confirmed . While in combat, if you use VANISH , it will only remove the movement impairing effects and enter and improved stealth mode but it will not trigger Stealth*the aura will not apply / the action bar will will not change thus making impossible for the rogue to reopen with a cheap shot , garrote or resap the target , nor Overkill even if you have points in this talent*which triggers only when you use Stealth*

[ankso]

I think this is related with a serious bug in BGs. Try this: go to WG, take the flag and use vanish. You will drop the flag, however you could take the flag again in a semi-stealth state where you are invisible. So, big exploit

[tester20]

here some fix

index 4970030..eb8e4c5 100755
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -2804,6 +2804,8 @@ void Spell::EffectTriggerSpell(SpellEffectIndex effIndex)
            // reset cooldown on it if needed
            if (((Player*)unitTarget)->HasSpellCooldown(spellId))
                ((Player*)unitTarget)->RemoveSpellCooldown(spellId);
+        if (unitTarget->isInCombat())
+        unitTarget->ClearInCombat();

            m_caster->CastSpell(unitTarget, spellId, true);
            return;