[FIXED] Crash with locales_gameobjects and locales_pagetext on [10578]

[Auntie Mangos]

Mangos Version: [10578] Clean

Custom Patches: NONE

SD2 Version: NONE

Database Name and Version : YTDB 566

http://pastebin.com/MMY1pymi

http://pastebin.com/ZMbE3tGe

Only happens with locales_gameobject and locales_page_text tables. I try with Client [ruRu] and works properly but with [esMX] and [esES] server crash on login.

¿Any ideas? charset is properly setted to UTF-8

Edit: Problem related to http://getmangos.eu/community/viewtopic.php?pid=126137#p126137

[ankso]

Same problem here. Same crashlog

[FeRkEl]

maybe QueryHandler.cpp at line 437

               if (pl)

change into

if (!pl)
   continue;
else

but i'm still to unadvanced in reading crashlogs ... maybe its a totaly different problem

[kero99]

Confirmed crash at esES, same crashlog

[Undergarun]

Some more info:

I try only with one gameobject and write undergarun in content_loc6 and content_loc7 to dismiss possible problems with ñ and/or others latin characters. Problem still exists

[VladimirMangos]

related code look as impossible for crash at related line for any table content.

I only see single case: GCC bug that generate wrong code with optimization. Suggest use diff optimization options for GCC.

[kero99]

Thank for response Vladimir, i try again with gcc 4.4.1 and without compilation flag:

Now

../configure --prefix=/opt/mangos --sysconfdir=/opt/mangos/etc --enable-cli --datadir=/opt/mangos

Before

../configure CFLAGS="-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -m64 -pipe  -msse4.2 -DFD_SETSIZE=4096 -fno-delete-null-pointer-checks -fno-strength-reduce -fno-strict-aliasing -frename-registers" CXXFLAGS="-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -m64 -pipe  -msse4.2 -DFD_SETSIZE=4096 -fno-delete-null-pointer-checks -fno-strength-reduce -fno-strict-aliasing -frename-registers" --prefix=/opt/mangos --sysconfdir=/opt/mangos/etc --enable-cli --enable-ra --datadir=/opt/mangos --with-debug-info --disable-builtin-ace

But same crash, how reproduce crash:

- Put something like "hello" in a name_loc6 of locales_gameobject

- Login and apear near gameobject with "hello" name.

- Crash

This problem dont exist in older revisions (rev 10100 for example)

Best regards

[VladimirMangos]

Test, not crash for me with Visual Studio 2010

[kero99]

More testing...

With client ruRU and something in name_loc6 dont crash...

But client esES and something in name_loc6.. crash..

Dont tested yet in Windows Environment

Best regards

P.D: Is soooo much really strange!!!

[Darky88]

I have the same problem....

I report on linux crash dump but the post is lost '' (new forum)

This crash have my own patchs buts its the same in clean version

Hilo 1 (Thread 14710):
#0  WorldSession::HandleGameObjectQueryOpcode (this=0x7fc4f13fcb80, 
   recv_data=<value optimized out>) at ../../../src/game/QueryHandler.cpp:236
       IconName = {static npos = 18446744073709551615, 
         _M_dataplus = {<std::allocator<char>> = {<__gnu_cxx::new_allocator<char>> = {<No data fields>}, <No data fields>}, _M_p = 0xc39418 ""}}
       CastBarCaption = {static npos = 18446744073709551615, 
         _M_dataplus = {<std::allocator<char>> = {<__gnu_cxx::new_allocator<char>> = {<No data fields>}, <No data fields>}, _M_p = 0xc39418 ""}}
       data = {<ByteBuffer> = {static DEFAULT_SIZE = 4096, _rpos = 0, 
           _wpos = 10669261066477184768, 
           _storage = {<std::_Vector_base<unsigned char, std::allocator<unsigned char> >> = {
               _M_impl = {<std::allocator<unsigned char>> = {<__gnu_cxx::new_allocator<unsigned char>> = {<No data fields>}, <No data fields>}, 
                 _M_start = 0x7fc4f13e1f80 "\\005", 
                 _M_finish = 0x9410d4696b472700 <Address 0x9410d4696b472700 out of bounds>, _M_end_of_storage = 0x0}}, <No data fields>}}, m_opcode = 1}
       Name = {static npos = 18446744073709551615, 
         _M_dataplus = {<std::allocator<char>> = {<__gnu_cxx::new_allocator<char>> = {<No data fields>}, <No data fields>}, 
           _M_p = 0x7fc4e0dfa5d8 "Ooze Covered Gold Vein"}}
       loc_idx = <value optimized out>
       entryID = 73941
       guid = <value optimized out>
       info = 0x7fc50d49ce30
#1  0x00000000007e75e8 in WorldSession::ExecuteOpcode (this=0x7fc4f13fcb80, 
   opHandle=<value optimized out>, packet=0x7fc4f141e200)
   at ../../../src/game/WorldSession.cpp:873
No locales.
#2  0x00000000007ea535 in WorldSession::Update (this=0x7fc4f13fcb80)
   at ../../../src/game/WorldSession.cpp:221
       opHandle = @0x1381935800007fc5
       packet = 0x7fc4f141e200
       currTime = <value optimized out>
#3  0x00000000007e3be2 in World::UpdateSessions (this=0x7fc518b63900, diff=104)
   at ../../../src/game/World.cpp:1927
       itr = {<std::tr1::__detail::_Hashtable_iterator_base<std::pair<unsigned int const, WorldSession*>, false>> = {_M_cur_node = 0x32, 
           _M_cur_bucket = 0x7fc51c369b53}, <No data fields>}
       sess = <value optimized out>
#4  0x00000000007e4494 in World::Update (this=0x7fc518b63900, diff=104)
   at ../../../src/game/World.cpp:1464
       autobroadcaston = 1
#5  0x000000000050fccc in WorldRunnable::run (this=<value optimized out>)
   at ../../../src/mangosd/WorldRunnable.cpp:60
       diff = 104
       realCurrTime = 2202790643
       realPrevTime = <value optimized out>
       prevSleepTime = 49
#6  0x000000000088a603 in ACE_Based::Thread::ThreadTask (param=0x7fc4f13e1ef0)
   at ../../../src/shared/Threading.cpp:187
       _task = 0x7fc51500bd80
#7  0x00007fc51a958a04 in start_thread () from /lib/libpthread.so.0
No symbol table info available.
#8  0x00007fc519f16d4d in clone () from /lib/libc.so.6
No symbol table info available.
#9  0x0000000000000000 in ?? ()
No symbol table info available.

-----

This problem dont exist in older revisions (rev 10100 for example)

Best regards

I dont know the exact rev but ~10400 generate the bug

[Undergarun]

Must be fixed on [10599]

Thanks to cyberbrest2 and VladimirMangos

[SeT]

help ))

Program received signal SIGSEGV, Segmentation fault.
[switching to Thread 0x7fffaf79b710 (LWP 19910)]
0x000000000088e35c in std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::size (this=0xe32955a000007fff)
   at /usr/lib/gcc/x86_64-redhat-linux/4.4.4/../../../../include/c++/4.4.4/bits/stl_vector.h:533
533       { return size_type(this->_M_impl._M_finish - this->_M_impl._M_start); }
(gdb) bt
#0  0x000000000088e35c in std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::size (this=0xe32955a000007fff)
   at /usr/lib/gcc/x86_64-redhat-linux/4.4.4/../../../../include/c++/4.4.4/bits/stl_vector.h:533
#1  0x00000000009a5549 in PlayerMenu::SendQuestQueryResponse (this=0x7fffaec0f9a0, pQuest=0x7fffcd1f3700) at ../../../src/game/GossipDef.cpp:596
#2  0x0000000000cf21d5 in WorldSession::HandleQuestQueryOpcode (this=0x7fffaebbbe40, recv_data=...) at ../../../src/game/QuestHandler.cpp:268
#3  0x0000000000c79856 in WorldSession::ExecuteOpcode (this=0x7fffaebbbe40, opHandle=..., packet=0x7fffaebdba90) at ../../../src/game/WorldSession.cpp:872
#4  0x0000000000c76e81 in WorldSession::Update (this=0x7fffaebbbe40) at ../../../src/game/WorldSession.cpp:187
#5  0x0000000000c6b41b in World::UpdateSessions (this=0x7ffff632b900, diff=51) at ../../../src/game/World.cpp:1893
#6  0x0000000000c69cdb in World::Update (this=0x7ffff632b900, diff=51) at ../../../src/game/World.cpp:1433
#7  0x000000000087da82 in WorldRunnable::run (this=0x7fffaed50590) at ../../../src/mangosd/WorldRunnable.cpp:60
#8  0x0000000000d26767 in ACE_Based::Thread::ThreadTask (param=0x7fffaed50590) at ../../../src/shared/Threading.cpp:187
#9  0x0000003a57007761 in start_thread () from /lib64/libpthread.so.0
#10 0x0000003a568e14ed in clone () from /lib64/libc.so.6

if (ql->ObjectiveText[i].size() > (size_t)loc_idx && !ql->ObjectiveText[i][loc_idx].empty())

revert 10599, crash disappear.

[VladimirMangos]

Can you and any who have locale related crashes before test this patch: http://gist.github.com/619398

If i understand problem right (mixed code use in packed/unpacked libstdc++ structures) then this resolve old and new porbelms

Patch do: avoid have std. lib templates under packed pragmas

[kero99]

Thanks Vlad, i go to test

[VladimirMangos]

New fix version applied into [10601].