Fix actionbar problems with shapeshifting

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Fixes actionbar problems with shapeshifting as of https://github.com/mangos/mangos/commit/9b4dcbbc01d65dd9f39c35814025a70daba730e6 . We now resend all updatefields when shifting into a form which causes the actionbar to be in an incorrect state when powershifting

if you use /cast !Cat Form while being in cat form you indeed correctly powershift and stay in cat form but the action bar is as if you were in no form

The solution is to only sync UNIT_FIELD_BYTES_2 updatefield which stores the shapeshift form

For which repository revision was the patch created?

[11811]

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

no

Who has been writing this patch? Please include either forum user names or email addresses.

Me, based on http://getmangos.eu/community/post/134007/#p134007

https://gist.github.com/1256482

[Auntie Mangos]

I already checked your code. Your implementation also uses a method to mark the byte as updated upon shapeshifting - in your case the function is called ForceValuesUpdateAtIndex which sets m_uint32Values_mirror[index] = m_uint32Values[index] + 1; which is bad because http://getmangos.eu/community/post/137966/#p137966 ...

[Auntie Mangos]

which is bad because http://getmangos.eu/community/post/137966/#p137966 ...

it's possible (i already not fit in memory details of this change), but changed not only this calls, also all method of update sending to client. after june i not have bugreports like published in first message, and in test (now) i not see any problems.

PS need for change arose only after the described commit.

[shauren]

this will not work if m_uint32Values[uNIT_FIELD_BYTES_2] is also 0 (not the case for shapeshifting, just shows this solution is not universal)

[stfx]

Yea, setting it to m_uint32Values_mirror[index] = m_uint32Values[index] + 1; seems like a good idea (taken from mangosr2)

[shauren]

actually thats taken from trinitycore but it is a bad idea (imagine the field being 1, then quickly shifted to 0 and back to 1; 1 is in fact the id of Cat Form), i would like to point you to my patch that makes SendForcedObjectUpdate obsolete

https://github.com/TrinityCore/TrinityCore/commit/8c707a13de6245ab505633bf50b4d078242de21a

https://github.com/TrinityCore/TrinityCore/commit/d8fcc9ef46931306d8157915b9af6b4d7476b907

and

https://github.com/TrinityCore/TrinityCore/commit/3be74850202d69ed19e712ae4b94508b927e8f97

(last 2 are silly mistakes)

[stfx]

I see, I didnt know that. Thanks, I cant believe I didnt think about this but I am not sure if this is not overkill as the server will now send the updated fields everytime they quickly changed to one value and back to the original again as it seems to only cause an issue on a very rare cases like shapeshifting - though maybe thats blizzlike... hm

[sart13]

Problem in ObjectUpdates code. I publish possible solution long time ago. In R2 works fine.

[stfx]

1. Please read the posts/patch before you post a solution as its essentially the same as yours which was the same as TC's old method.

2. If you want to contribute it would be awesome if you could push the patches Shauren mentioned to your repo with debug info as how many more packets are sent of old version vs. new version

Thanks

[sart13]

please, see on solution (mr216 + some - 4-5 - later, june 2011, distilled code be puplished in this forum, as i think), not related and not seems like TC code. Implemention of Shauren code possible, but not needed - this solve of other (not present in mangos at all) problems.

[lillecarl]

As soon as i get my workstation up and running im going to apply shaurens code and see how well it works. And about the sending of more packets, i think in mangos the blizzlike way is the only way?

[stfx]

Great, it would be very useful if you can log whenever a packet is being sent with the new version but would not with the old one

[lillecarl]

Yeah i can do that:) But that would need someone to help me with the logging part of the code. If you can tell me how to log it i can test it out! (if its ok if i test on mangos one because that is mainly what i am using)

Summary: Help me with the logging code and i help you log:)

EDIT: My workstation is up and running now!