[Zero] Bugs I am experiencing, solutions?

[Cala]

We need more people like you, Cala. :cool:

Thank you, that is a nice thing to say, but wait to see the results before praising me. For now, what I've done with scriptdev2 is more voodoo than true development. I've finished adding the change to the scriptdev0 files. Now come the true test: I will compile and cry in front of the many errors that will undoubtly rise.

Stay tuned.

[Cala]

Hello,

I had indeed error messages when compiling, but I didn't expected them to be core related. Many nice improvements were done on scriptdev2 for Mangos/Mangos One made by Xfurry, Schmoozerd, Lilcarl and others... But these improvements rely on new core features that are not in Mangos Zero. Then, I'm heading to implement them as well... if I can because it is a more complicated and longer work than I expected.

[evilatwow]

[*]Mining does not work correctly. I have a mining skill of 21, copper ore is orange to me, but I only had one skill increase after mining three times

It's probably a silly question, but the "mining three times" was on different deposits right? Because it used to be that you had to mine several times to get all ore etc from a single deposit, which only once gave a skill up if appropriate. These days on offi (since WoTLK I believe, but I'm not sure), you mine once and get everything a deposit contains at once.

[Xenithar]

Added a bug that I discovered last night to the bottom of my list. It seems as though turning in the Echeyakee quest in Crossroads results in random spells being applied to players. My girlfriend and friend got one with a guy's picture, but each functioned differently, and my shaman got "Sapta Sight". We were all supposed to get "Echeyakee's Grace".

*EDIT*

Yes, I mined the deposits two or three times. Either way, when it was orange you got a skill point every time you mined successfully in the official WoW. Not randomly. Also adding a bug I just thought of where when you mine or do another skill such as skinning, it insta-fails instead of going through the progress, then failing like on official.

[KapralPetrov]

IMHO, it is debatable all this

[sjizzle]

Added a bug that I discovered last night to the bottom of my list. It seems as though turning in the Echeyakee quest in Crossroads results in random spells being applied to players. My girlfriend and friend got one with a guy's picture, but each functioned differently, and my shaman got "Sapta Sight". We were all supposed to get "Echeyakee's Grace".

*EDIT*

Yes, I mined the deposits two or three times. Either way, when it was orange you got a skill point every time you mined successfully in the official WoW. Not randomly. Also adding a bug I just thought of where when you mine or do another skill such as skinning, it insta-fails instead of going through the progress, then failing like on official.

Well if it's a quest reward ( something you get by turning in the quest ) then you should look in the database.. Find the quest entry and look at the corresponding quest rewards.

[Cala]

• [...]
  
• The feral druid skills are all available at level 10 (possible code fix for this, have yet to try)
  
• [...]
  
• When you reach a specific level in skills the trainers are supposed to tell you where to go for more training, but they don't. My personal experience here is the herbalism trainer in Thunderbluff. You can learn 0-75, but where do you go for 75-150? I solved this by going to Orgrimmar and learning 75-150, but it doesn't seem right.
  
• Rockbiter does not increase AP and instead procs flametongue damage very rarely
  
• Flametongue proccing causes your character to go into a casting animation, like when casting Frost Shock
  

Regarding feral druid skills, I've implemented yesterday the fix from Mangos One to Mangos Zero (thanks to Schmoozerd) and it seemed to work as expected. I'll share soon the GitHub repository.

Regarding Rockbiter, I'm working on a fix from Gonzo1247 which I should test this evening along with other fixes.

And about trainers, any gathering profession trainer can teach you up to last skill level. Then, they don't have to tell you were to go as they still can teach you. The crafting profession trainers however are indeed splitted into several level and each one should send you to the next one once you've reached the max level available from them. Can you confirm that this isn't working like this?

[Xenithar]

I sure can, Cala. I am building a new kernel for the WoW server box right now (I love custom kernels) and will be able to tell you specifics later today or tomorrow. I am working towards a new internet connection and once done, I can allow you access to the server if it will help you.

[Unkle Nuke]

I do recall that, once your profession had reached a certain level, the trainer would give you a quest that directed you to the next trainer. This is especially true for acquiring Master level, which usually required completing a very long quest chain. It may be those trainer quests are missing or broken, which points to yet another database error.

The only exceptions to this, to the best of my knowledge, were mining, herbalism, and skinning, as Cala has said.

Perhaps someone should run a diff between the Zero and One databases, to highlight any missing or incomplete parts. TBCDB is the best database for One, so I'd recommend that one as a template for corrections in Zero.

[Cala]

I'd like to give you a quick update about how work is going on Mangos Zero update:

I forked the official Manogs Zero repository and I applied one by one small updates from Mangos One. Some could be backported without modifications, some requiered small adjustements.

• The feral druid skills are all available at level 10 (possible code fix for this, have yet to try) FIXED
  
• If another player or NPC begins casting a spell and is interrupted, the audio keeps looping and the animation stays with them. For example, interrupt an NPC casting a fire spell using Earth Shock and they come running towards you, hands engulfed in flame with the fire sound playing SHOULD BE FIXED NOW (didn't have the opportunity to test)
  

Also:

• Fix glancing blow formula
  
• Add Mark of Kazzak spell
  
• Remove stealth when looting
  
• Add Deep Wound for warriors
  
• Allow players to get quest from ghost NPCs
  
• Update targeting system (allow scripting of bosses with special abilities such as Moam)
  

(NOTE: I didn't wrote any of these updates, I just backported them from One to Zero)

However, I have yet to fix something with these updates: the escort quests are now broken core-side. This does not come from one of the updates as I tested them one by one. I assume one of the files that I didn't update was corrupted one way or another and I have to find which one. Once this issue is fix, I'll share the repository to allow further testing.

[Cala]

As promised earlier: https://github.com/cala/server

Feel free to download it, build it and test if previous fixes are indeed working and what remain to be done. Next (major step): porting spline subsystem from One to Zero.

Sorry it took so much time, but I finally found what broke escort quests: it was updating and uploading the src/shared/revision_nr.h file via git. The behavior of this bug is very strange:

- if I update the version number but don't push new commit to repository via git: escort quests are not broken (building from local source files)

- if I don't update the version number and push new commit to the repository via git: escort quests are not broken (building from updated repository source files)

- if I update the version number and push new to the repository via git: escort quests are broken (building from updated repository source files)

I just don't understand why, thus I don't update the version number.

[sjizzle]

Nice work!

[Xenithar]

I will try to implement these this weekend. No promises, as I have worked for almost three weeks straight, long hours (over 14 a few times). Very busy at my professional job, so this is on a back-burner. I did add one thing to my list. This is most-likely a DB issue however.