[6973][Patch] Demoting guildlog fix

[vdesai]

• * What bug does the patch fix? What features does the patch add?
  This just fixes the guildlog with apocs earlier fix in rev [6964]
  * For which repository revision was the patch created?
  Latest
  * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.
  None
  * Who has been writing this patch? Please include either forum user names or email addresses.
  Just me its just a simple one liner
  

    if((slot->RankId+1) >= guild->GetNrRanks() || slot->RankId <= GetPlayer()->GetRank())
       return;

   guild->ChangeRank(plGuid, (slot->RankId+1));

   // Put record into guildlog
-    guild->LogGuildEvent(GUILD_EVENT_LOG_DEMOTE_PLAYER, GetPlayer()->GetGUIDLow(), GUID_LOPART(plGuid), (slot->RankId+1));
+   guild->LogGuildEvent(GUILD_EVENT_LOG_DEMOTE_PLAYER, GetPlayer()->GetGUIDLow(), GUID_LOPART(plGuid), (slot->RankId));

   WorldPacket data(SMSG_GUILD_EVENT, (2+30));             // guess size
   data << (uint8)GE_DEMOTION;
   data << (uint8)3;

Sorry, did not know how to make a patch with git but its easy to find in mangos/src/game/GuildHandler.cpp

Line: 376

[DasBlub]

to create a patch just use the following command and copy the output.

git diff

or you can redirect the output to a file:

git diff > path/to/my/patchfile.diff

[Dythzer]

Seems like it's already fixed:

http://github.com/mangos/mangos/commit/cb1650ef33166bcb4dbac84c01cb221e01e9dfeb

EDIT:

Sorry, didn't see this was for guildlog. Never mind.

[arrai]

added in [6973], thanks

[vdesai]

Thanks, DasBlub I really haven't had time to read the steps in the guides yet or look at the documentation. Thank you.

[VladimirMangos]

Patch backported to mangos-0.12