[alt.fix in 7325] Mana/Energy/Rune Regen for Old 3.0.3 Chars

[Auntie Mangos]

Edit: Oops, title should be fix "for pre-3.0.3" chars.

What bug does the patch fix? What features does the patch add?

This fixes the DB error in characters table that causes old characters' clients to not exhibit the new regen system. Newer characters have this flag when created. It does not implement the fix in the core; it only makes it so the client receives the correct regen flag.

Somewhere after update to 3.0.3, a line "SetFlag(UNIT_FIELD_FLAGS_2, UNIT_FLAG2_REGENERATE_POWER);" was added to the create player method in player.cpp. There was never a corresponding sql update to give this flag to characters created before then, though.

For which repository revision was the patch created?

Tested on 7264.

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=5416

Who has been writing this patch? Please include either forum user names or email addresses.

me

delimiter //
DROP FUNCTION IF EXISTS fix_regen//
CREATE FUNCTION fix_regen (datastring longtext) RETURNS longtext
BEGIN
   declare i int default 0;
   declare back longtext default datastring;
   declare front longtext default "";
   while i < 59 do
       set front = concat(front, substring(back, 1, instr(back, " ")));
       set back = substring(back, instr(back, " ") + 1);
       set i = i+1;
   end while;
   set back = substring(back, instr(back, " ") + 1);
   return concat(front,"2048 ",back);
END;
//
delimiter ;

Update characters set data = fix_regen(`data`);

[Auntie Mangos]

in fact, I have post a patch in under review to fix that.

http://getmangos.eu/community/viewtopic.php?id=7545

[Sephiroth1983]

Note: In patch 3.0.3 energy regeneration became a smooth regeneration. This means that instead of regenerating chunks of 20 energy every tick, you now regenerate 1 energy every decisecond (ie every one tenth of a second).

This fix is needed, if someone needs a video (I don't know why) that prooves the new regen rate send me a pm.

[VladimirMangos]

this is not mangos-prefered way.In most cases we prefere do integrity check and restore expected state for character data at character loading. In code version added in [7325]. Thank you for pointing to problems and way to fix show.

[Sephiroth1983]

I noticed with new energy regen, talents like Adrenaline Rush, Vitality are still regenerating with old fashoned way

Apply Aura: Mod Power Regen % (3)

This gives strange regeneration, like big burst energy regen in some moments, can someone confirm?

Another big problem: Mana regen is the same if you are casting or not...

[nos4r2zod]

I noticed with new energy regen, talents like Adrenaline Rush, Vitality are still regenerating with old fashoned way

The core still does regeneration the old way, this only adds the regenerate flag for the clients. Really, for now, this only helps with DK runes not refreshing on their own for some DKs.

[dardennf]

Hello, the energy Mana/energy regeneration is still bugged.

[VladimirMangos]

Hello, the energy Mana/energy regeneration is still bugged.

Also possible write: mangios still buged. Same level of helpful data providing.

If you say about "nergy regeneration became a smooth regeneration" the this not related to this patch totally and reported many times.

[hikikomori18]

Also possible write: mangios still buged. Same level of helpful data providing.

lol <10 characters>

[kotora]

on your char sheet it's show like smooth regen(dunno for u but i am using xperl addon) but when u are in raid group.And when u are casting some spell and u have minimum mana for that spell u can't cast it u have to w8 1 sec or 2 to get enough mana to cast it.

[VladimirMangos]

this is known 3.0.3 feature not implemented in mangos. Totally unrelated.