VladimirMangos

I not understand how like call stack possible: 004A0BE8 00000000 ?CanReachWithMeleeAttack@Unit@@QBE_NPAV1@M@Z+68 08202673 00000000 ?setBValue@ThreatRefStatusChangeEvent@@QAEX_N@Z+193 004DAAA0 00000000 ?Update@Creature@@UAEXII@Z+3E0 I not see in code any possibilities for it...

this must fixed in one from recent commits (yeaterday)

But client by self can not propetly known when show infor (form dependent)? I meaning if just unconditionally set dynflag for caster view without any additional filters. 2) Unit::GetCreatureType() return proper creature type for creatures and players in form. So not need special checks.

Hmm, i think 1.3 into function body is replacement for 1.5 in spell code. Maybe i has been wrong.

I not have this porblem. Check by temeporting by provided coordinates. If its disabled then it must be reported as warnign at server startup. Mangos now _not_ support as normal configuration case with disabled vmaps.

Single core unsafe place fixed in [11107].

i not accept bug report about every spells. If say about totem targeting then for chain damage spell skip totems for not first target implemented long time ago. And for AoE spells also. Ofc if this spell implemented in core.

Can be good if you say what spell exactly casted wrongly..

Client 2.4.3 allow cast mount spell in (1) case so from _client_ point this is outdoor. Not expect from vmaps more that provide client data. In fact if you look up you will see the sky

This is not related to vmaps indoor. It must work as normal dismount in liquid. Old data no any indoor checks so if something work this has been not related to vmaps work in like cases. Indoor check as feature exist only in vmap 3.0 version About mounting: cleant by self control mount allowed check in indoor/outdoor case. So server just not get any casts in like case if client think that are indoor. vmap3 indoor feature just make accessable same info for server side. This feature allow recheck mount casting (but only as anti-cheating because client by self not allow it) When feature really used at server side only: when you attempt enter to indoor area at mount. This part not control by client. If in point mount cast allowed by client then area isn't indoor area from client (and then server) point and wmaps indoor check not related to it. mount not allowed but you can enter to are at mount - vmaps really detected bug. Please report exactly .gps coordinates where this problem (you enter mounted and stay in point are where you after unmount can't cast mount by client check protection).

In [s0772][s0773] restored work indoor checks so its enabled by default as in master.

I not undersatnd what you do and have in sources, but i specail after your post test step by step in debug apply spell_bonus_data coeff for Healing Touch and it work fine for me. You must understand this this is _spell_power_ coeff. It set how many affect spellpower bonus to spell damage/heal If your character not have spellpower then this coef will not affect anything. It not affect base raw spell damage/heal.

Look like your research right In [11106]. Thank you

Patch in rewrited form provided by Schmoozerd in [11105] Thank you.

Must be fixed in [11100]. In fact source of problem described by blueboy in github comment note. So my just code fix

ok, maybe recently added packet send must send only for real mount casting, not taxi like cases. But i not yet attempt repeat problem.

then better have suggested change with code that use it. Just not see reason add it before this.

Just for note: i work currently for backport One -> Zero [added]In [z1307]. Base at some testes problem only already noted for One: indoor checks.

What reason add extra flag that not used anyway in core....

But not new bugs? So all ok. I more interesting that as i test: fishing work in cities. city and caves now correctly return area info. So many quests related things start work in normal way. And etc.

Good job Btw did you check my partial backport of 6a6cde8d284370b160952582378190b92c5ac2d4 already? I think its pretty good one. It backports as much as possible without breaking 2.4.3 extraction. Patch can be found here: https://gist.github.com/802722 in [s0769] thank you.

hmm, ok, i look at original commit and because hard backporting skip it from including into backport package . But i see you cleanup it so i will look

vmaps 3.0 added to Mangos One (with disabled indoor check) in [s0767]. Thank you indoor check problem as i look in debug in result different flags used in 2.x for AreaInfo::flags field that get from class GroupModel uint32 iMogpFlags;// 0x8 outdor; 0x2000 indoor Commented values not valid for 2.x

You need update: character_pet character_pet_declinedname pet_aura pet_spell pet_spell_cooldown

In https://github.com/VladimirMangos/mangos master - version with some fixes and changes. I plan tommorow finish tests