Jump to content

VladimirMangos

Members
  • Posts

    2813
  • Joined

  • Last visited

    Never
  • Donations

    0.00 GBP 

Everything posted by VladimirMangos

  1. Look in function tail: coeff modified by diff ways in code path and end used in line total += int32(benefit * coeff * LvlPenalty);
  2. Yes, look like data missing in this table.
  3. Not mangos bug. Must be reported to script library creators.
  4. petnumbers used for pet auras, pet talents and etc
  5. ok, base at possibility disable this part by option we can live with it. And this will not worse that current Mangos One state. If backport then this will local problem that can be fixed at some moment in future but other chnages and features dependent or implemented by vmap3 will not blocked.
  6. Backporting package must also include 43f5bc2d0dc1e8952ee49b7b7228ba842df67d3e [9998] Fix *nix build. For make it compile possible for Unix. For simplify later backporting to zero (ofc will been more fixes for make this possible) i will backport per master commit + your fixes. At least where possible (in pre-required commits for example) with cross check with your version.
  7. Great work! I not look yet code but I think this one from most important missing backport features. So i will prio review this now. Big thanks!
  8. I think good idea for custom patch.
  9. We will not in any cases adding check base at spell name. This is slow check and not work always becase some spell ranks have different names. I understand some porblems existing with current check. But suggested way not proper sollution.
  10. base dodge/parry chance calculated in other place for same level attacker with max weapon skill for level So this part skill dependence value preincluded in chances. that why in function used reversed attackerWeaponSkill - int32(pVictim->GetMaxSkillValueForLevel(this)); and in fact negative always value have for fix value to real weapon skill value. You change make this broken.
  11. pet id is petnumber, not guid low. For pets guids is dynamic values and start from 0 at server start. In DB stored petnumbers. In different from creature guids, pet guids have as middle guid part referenced petnumber so petnumber limited by size of middle guid part: max value is 0xFFFFFF = 16777215. Maybe some compression possible at loading server, no other way prevent petnumbers overflow.
  12. Hmm, it expected same exactly as for mangos one. one/master differences only in diff path to vmap dir. And this diff not exist for one/zero. And yes, only limited amount responses here and at ru-mangos prevent apply it at least for unix side use. Ofc, we can do in normal rule for like case: if ppl don't want test as patch they will test as commit in repo
  13. 1) this is diff projects 2) don't know. I close thread. We not allow compare projects for avoid flamewars.
  14. Just for clarify: we store req. revision in field name for make possible add guards in sql updates for preserve proper apply order. In SQL more easy check this with field name that with field value.
  15. Original patch + fixes with invalid INVALID_HEIGHT uses in [11068]. Thank you
  16. Why only 1 school mask? In case warlock most damage expected in shadow school and as i understand it also must be counted?
  17. Sources patch in [11066]. Thank you.
  18. In [11065]. Thank you
  19. ok, so i mark problem as not mangos clean core related.
  20. Must be fixed in [11040]
  21. Related to problem with spell bonuses. I attemp wrte it with avoid hardcoded coeff and just basic bonuses calling in patch https://gist.github.com/784741 but final heal values not fit to expected as i test Because tested against area spell possible.
  22. Current master branch support 3.3.5a
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use