Jump to content

VladimirMangos

Members
  • Posts

    2813
  • Joined

  • Last visited

    Never
  • Donations

    0.00 GBP 

Everything posted by VladimirMangos

  1. From code point no diff in 0 value search in structures. Possible 0 just because at this point stack data corrupted or overwrited by something...
  2. I not see any related spells or spell mods so possible good wayI recheck this currently for be sure Maybe only need apply glyph mods as final duration addition [added] In [11035]. Thank you
  3. In [11034]. Thank you
  4. Hmm, why 0.32%. wiki page say about 1.5% ... Some statistics based?
  5. In [11033]. Thank you
  6. And what? Unit::RemoveAllDynObjects 1) cleanup dynobj list at owner side 2) call CleanupsBeforeDelete for dynobject that call DynamicObject::RemoveFromWorld that call: GetViewPoint().Event_RemovedFromWorld() that call in chain ResetView(); And this all _before_ map reset for player.
  7. I test this cases: no crash. Ofc, i test at clean mangos sources, so no mtmaps and etc patches.
  8. This is not related. remove list handeled at tick end. far teleport confirmation from client can't be received (and in any case processed) early next tick.
  9. as i read REPLACE statement exactly same as DELETE INSERT pair by execute time
  10. In [11026] implemented damage redunction in alt. way.
  11. About first patch: not good ask GetCaster() for all handler code, this slow operation (search guids lists for pointer) so must be used in specific spell code part only if need. Aura target can't be NULL in any cases. I can store corrupted pointer if some bug but not NULL. Cooldown reset look hackish. We have special fucntion for reset specific spell category: Player::RemoveSpellCategoryCooldown I will replace this part code by direct unconditional call this function. for original spell caster selection better use: Unit* caster = GetAffectiveCaster(); For triggered spells it point to original main spell that triggering chain of casts This 2 patches added in [11024]. Thank you. Damage redunction is unacceptable hack. Becase for this exist special spell 68066
  12. please not use threads as holder of not related spells patch collections. In this time i split posts from thread. About "Tricks of the Trade damage buff": i not see reason move triggering caster part to target spell trigger call. So i move it back to proc handler. With this change in to [11021]. Thank you.
  13. we have option delay update respawn tables until grid unload.
  14. all dynamic object created by player destroyed at far teleport _before_ teleport. So strange that problem exist. (i still not check yet suggested way for reproduce)
  15. LANG_LP_RUPT_MESSAGE = 11100 I suggest use random value from range instead first then you will have less chance conflict with other patch usage.
  16. In [11020]. Thank you
  17. Hmm, but at my testes aura always correctly removed at far teleport and camera reset to player back.
  18. I not see how it can freeze at pointed spell code. It can crash or like but not freeze and crash dump content show that this really freeze. So i think freeze in some other part
  19. While i test your bug report i have only single time something like described crash but in same time find another source of crash in code cleary not related to spell cast. Found case fixed in [11015]. Can you recheck with this rev? After this fix i can't repeat any crashes in many attempts.
  20. In [11013] with some rewrites. Thank you
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use