VladimirMangos

any non-static class function have hidden additional arg 'this' So : working example void outString( const char * str, ... ) ATTR_PRINTF(2,3); you have 1 arg mode in start so 3,4

About HoTs: SendPeriodicAuraLog not have absorb field for this cases. So i not sure is it really affected by heal absorb...

in [s0171]

How this all related to mangos core...

Indeed, talents checked for correctnes for current class at loading.

hard review this part functionality before main part of spell functionlity...

Base at "git blame" this is cbf07063 commit. Later just applied style changes. This is missing part already backported commit becuase mover has been backported with delay after other commit parts backporting. But as mns point better provide backporting commit info (git commit hash) if it available. [added]In [s0170]. Thank you

characters updates not so often and i as always forgot about ^^ thank you for watch for this In [s0169].

Developer's Corner3rd party projects not for mangos source modification, moving...

CoreMods for modifications, patches that not look like acceptable to mangos sources. 3rd party section for indepndent projects not mostly affected mangos code modification I think this cleary described in section subtopic:

Return? It never has been in like way always. And i strongly against devide patches targeted to adding to repo and diff section.

in fact i plan use in next commit from your patch only proc event code. Other or applied in alt. form or not related to redirection. [added]Last part of redirection spells functionality added into [10467]. Triggering code added base at tester20 patch. Thank you Sorry for strange author name i use in commit. I not understand how this happens. ^^ Please, if you want, post missing functionality patches for topic spell in thread, for other redirection spell please create own threads. About additional buffs casting: do it in effect/aura code is bads style and will not excepted without real reason do in like way. In most cases liek spells must be casted in Spell:cast (look existed examples) if casted spell duration not releated from main spell Or spell must be casted SpellAuraHolder::HandleSpellSpecificBoosts if applied by spell aura must be removed at main spell aura remove (1), or if spell must be casted at last main spell aura remove.

+ if (m_removeMode == AURA_REMOVE_BY_EXPIRE) + pCaster->SetThreatRedirectionTarget(NULL, 0); not good way check: player can cancel buff and by above code will still have redirection. Proper check: != AURA_REMOVE_BY_DEFAULT as i think. last used for explicit aura removes [added] With this fix in [10466] added reset code for all spells base at Toinan67 patch code. Thank you,

i will apply original core part of patch first anyway... continue commenting: iThreatContainer.addThreat isn't good way redirect threat because if redirect traget not in threat list yet then redirection threat will fail. [added]Core part added into [10465]. Thank you.

In Toinan67 this part possisble more correct at least by results: main spellmust be replaced at secondary part apply with preserve already set treat redirect target At least how i understand spell work. I not 100% agree with way how this done.

this is horriable.

ok, suggested way still required. I mostyl agree with patch as think but plan move new fields and functions to threat system where is better place for its

In past i also think that only way use additional fields (small possible improvment: place its to threat system objects instead Unit directly) But look: Misdirection (34477) have 1300 effect + 4 dummy aura AND have Misdirection (35079) with dummy aura Same: Tricks of the Trade (57934) have same structure and 59628 Same: Only Vigilance (59665) not have helper spell (at least if check by name) but have Vigilance (50720) that triggred 50725 So possible this spell linking let implement feature in more expected way... i will look.

Base at pointed by laise spell existence it look like must work in normal spell proc events way.

After recent getHeight changes all mobs work in this way. Follow by ground until evade from combat start point distance. So adding above patch it possible will make it work less correctly. Also mobs melee attack flying player if it at attack distance, Ranged attacks also work.

I understand that meaning IS state mostly.

I think wiki for this more appropriate

I plan do: 1) make vmaps loading disabled case error output at loading (but allow load) 2) drop support map list for partly diabled vmaps 3) drop possibility disable vmaps usage fro something if vmaps loaded.

Patch incorrect mostly. But patch give me idea howit must be implemented. So thank you I add into [10462] my version that work as expected as i think.

i don;t know. This is can be not easy find additional fields in pdump. Just loading pdump report that fields amount differ from expected.