VladimirMangos

I do same checks in to master and fix found cases in [8491] and "backport" (use your found cases and check more) in mangos-0.12. Thank you

Type fixed in [8490]. Thank you

That why it compared. UpdateObjectsVisibilityFor expected to be call for view points and your fix targeted correctly to fix this case. It include also update update players visibility around view point. BUT UpdatePlayerVisibility update visibility of player itself and expected to be in player position without deopendencr is viewPoint same to player or not. So we have 2 cases for UpdateObjectsVisibilityFor (1) player = viewPoint and we can use same cell coordinates as for player already used. (2) need initilize new cell coordinates for viewPoint (!= player). If-check just avoud like second point creating.

In [8489]. Thank you

You have typos in second line, but anyway in general fix correct I will added it in modified form, for aboid additionl calculations in most often case when viewPoint==player Also note: player visibility itself must use player point, objects around visibility use view point.

In [8488]. Thank you, to cccyril, nos4r2zod and all helpers Some data droped from from suggested sql updates as already listed in mangos.sql:

Patch in [8487]. Thank you

In [8486]. Thank you

In [8485]. Thank you. I think *.sln.cache better as more stricted to expected filename.

In [8484]. Thank you

1) you check for expected polumorph overwrite touch to many spells (need check family also) 2) I think you select wrong model. Exist polymorph spell 59634 that have in misc creature id 31128 with model 26452. With this fixes in [8483]. Thank you

In [8469]. Thank you

Ok, add like query not harm anythinh infact, i also found _single_ spell example from list. Just additional cleanup.

? Why it must be in character_spell ? This is dependent spells until it has been removed and then it don't must added to character_spell in old code. Current spell system add to character_spell only non-dependent spells (not learned as leraning another spell or tlanet or skill level, or quest state result). Do you really check that any from this spell listed in character_spell for character at list one time loggined in last weeks. My checks show that none from its listed

In [8451] with some changes. THank you

Or use true as 3 arg to make spell cast triggred and ignored reagents.

In [8446]. Thank you But i change to use _final_ damage.

In [8417]. Thank you

From other side as has been noted GM can use chat command. So i mobe to mods sections.

Current code not used harcided percent, so i not see what you meaning. In current code percent get from spell.dbc data and it correct for old and new version.

With this a... rewrite patch in [8416]. Thank you

I think not have big meaning have 2 way for work. If this has been 1-2 spell that not have space data then we can say that this just not updated DBC or typos in client, but when 500%/50% cases stance set or not set for passive better not base code at this as attemp be done in old code. Better switch to clear code set boosts apply without learning. I will rewrite suggested patch in this way.

Just for note: base at nos4r2zod and my tests patch have real problem with some auras stacking. So generic rules must be rewrited.

maybe base not at GM level but at isGamemaster() state ? So if you in GM-on state then as GM send fast GM-mails in normal state send normal mails...

Well fed checking part added in [8399]