VladimirMangos

This is not nice in generla use full list explcit spell ids for like remove. But your patch not work also correctly: what if 2 warlock casted spell that triggred this debuff applied? With your code it will remove debuf at first removed effect of any from warlocks.

In [4191]. Thank you

Added base at GetMangos.ru version in [8190] with some changes. Thank you

a -> b is same (in most cases) as (*a).b at least for built-in types... if 'a' is pointer to some object or structure with field 'b' then a -> b will return value of (in fact reference to) field 'b' od structure 'a'.

1 ) Is code really work as expected? For exampe if you not have anymore 55 level characters at some realm, code will anyway allow create heroic class... Other note: in current form it too generic. 2) I not see cases when another player or server must know account flags (current) for offline characters. That why this unneed slownees code with constant so DB access at rwad and any >55 levelup. More funct just have flags field in WorldSession readed at loading and modify only at new value set IN db if value different from values stored in flags field in WorldSession. If (1) real problem then use flags impossoble and need count characters that also can be bugged if level modified offline..

In general view if IsInWorld patch (+2 as rememeber later fixes) will backported as pre-backport then this pososble but, as Ambal note, need some testing and generic look at related code. Nothing in 3.0 specific changes expected prevent this.

This only meaning that moeny to `data` will saved _only_ at full save. But it not need anyway while new columps used. After normal logout value in `money` and monet in `data` must be same anyway.

Only when it will not need finally (nothing data will read at player loading from it).

Normal save still save _all_ data in `data`. So nothing deactivated. This data just not used at loading.

no, data at save stored and in old and in new fields so just drop new fields not create peoblem with backporting. Except only case when you for example change level for _offline_ character and he not login before backport. In like case he will have old level after backport. Same for other offline change data stored in new fields.

But it long period time not used... Is we need keep some code just beacuse with some low chance it will need later... Anyway we easy can revert this patch if it will be added later if we will need this functuonality.

In [8149] Thank you

In fact this is (MAX_NUMBER_OF_CELLS*MAX_NUMBER_OF_GRIDS/2)

In [8148]. Thank you

I first read this changes as suggested by Ambal and then i add it in [8145] as Ambal patch.

As notes simlar patch applied. Anyway thank you

with big chance no.... at least final `data` drop 100% sure will not added to 0.12: hard to recreated for preoper way switch to 0.13 structure and data.. For adding just new fields withuot `data` drop... fi this considered useful...

Patch already added by version at getmangos.ru

In [8110]. Thank you

Oh, sorry, forgot about this patch. Just fix errors while restore my long time (>half-year) not updated FreeBSD mangso testground. Anyway thank you for patch

Just for clarify thread state: I think reverting as suggested in first commit not sollution for any still existed probem. Old way also have real problems with work. So i not move this thread to rejected for make it place for find required changes in current code if need any. At least Seizer and Dagguh have nice discussion

Too hacky...I understand problem with not int values at percent apply that in result return 2...

Placing one more id in root of IsPositive check you slowdown _all_ call that toally not related to this sperll check. With this fix in [8086]. Thank you

Provide problematic character pdump and i will look at problem..

It this related to preview then this not DK specific rate bug. I also remember report about this porblem and for other characters. Patch added in [8085]. Thank you