Jump to content

VladimirMangos

Members
  • Posts

    2813
  • Joined

  • Last visited

    Never
  • Donations

    0.00 GBP 

Everything posted by VladimirMangos

  1. In [7818] and mangos 0.12. Thank you
  2. Yes, but patch related to way how related zone explored as expected by quest. In patch suggested by taxi destination node check that not have another similar cases and then hack like. But code have examples for do specific steps at dummy aura apply/remove and this expected for dummy auras...
  3. Not sure how this possible implement by scripts but current way too hacky indeed. Maybe apply at dummy aura remove for item spell....
  4. Astellar have at getmangos.ru some patches that do this pet implemention step by step in proper way. Referecned above commit has been one from like patches.
  5. spell sumoon _different_ type of pets when talent known and when not known. So _not_ need any addition check in Pet::IsPermanentPetFor and other horribale hacks
  6. Who post? trinity devs? I strongly against access to devs section not for team members. Nothing here intresting for they.
  7. Hmmm, you not write what error you see at build. In general i prefer switch to use relamd patch with ACE ( http://github.com/derex/mangos/tree/realmd ) and drop dep/sockets totally. Just need infor how it work at diff platforms (FreeBSD specailly)
  8. ok, but i will fix 2 problem in patch: 1) not safe store aura pointers if later aura can be rempved/etc, better store spellEntry+amount 2) if today classes have only single specific spell not meaning that spell not need checked in addition to spell family check. 3) rogue spell case chance need check _before_ assign prevent death data. This need for correct work in case: rogue have talent and have applied priest buff, talent applied after priest buff check and overwride it and then chance check fail. I not think that this is good way for work: die when have 2 anti-die buff/talent and one from its 100% chance always. 4) as death preventing i think this must be applied after any damage reducing auras check. With this changes in [7787]. Thank you
  9. In [7786]. Thank you. I rewrite code to switch by zone->team for simplify code read.
  10. 1) MoneyChanged is quest related update function, so better not add to it unrelated code. I move call to Player::SetMoney where it only called. 2) i think not exist any reason have different code for in game and loading cases. In all cases we can use GetPlayer()->GetMoney(). With this changes in [7772]. Thank you
  11. this is known problem related in general absent access to zone/water level in 3D static objects data. This will fixed in general way and adding any hacks not planned.
  12. I think no.
  13. this is not related to vmaps. Just for not fly creatures not implemented code for case how chase to fly creature.
  14. This is normal way in open source project development Maybe, but current way used in many places and better for consistence use one way until this not proved that wrong by some reason or switch in all cases to another way.
  15. Ah, it has been created before patches, understand now, no problem. At quick (and wrong as i see now) look i think that it created _after_ patch thread Closed.
  16. empty line need Maybe merge to UpdateForQuestWorldObjects() Loop in both by same guid list. I think http://www.youtube.com/ reference not required in to sources, Just clear note that example spell id aura confirmed as applied to vehicle fine. In any case i think patch now look more ready
  17. NPC flags part added in [7754]. Thank you. But GetCreature other 2 parts of patch is wrong as described by megamage. I plan add its in version suhhested by megamage. Ofc, instead GetCreature modify need adding GetCreatureOrPetOrVehicle in all affected gossip function/handlers [added]Second patch added in [7755]. Thanks to daveh and megamage.
  18. In added in [7752]. Please not create multiply threads.
  19. arrai, PLEASE, not suggest wrong way to fix problem. This checks added by real reasons. Why not suggest _P_R_O_P_E_R_ way? Open files where account types define (in src/shared/Common.h ) and add required account levels in to enum AccountTypes somewhere after SEC_PLAYER but _before_ SEC_CONSOLE and renumbering values. After this in `comand` update account type values.
  20. I not see final patch for review for found after this fix. If it exist then please provided URL in Reviews section. Not just code quotes.
  21. ??? This fix added to mangos sources... what password? What the crazy talks...
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use