VladimirMangos

Then original topic wrong.

In [7515]. Thank you

And sometime ban bumpers at some time Added in [7504]. Thank you

Please post any additon patches in new thread.

In [7500] and mangos-0.12. Thank you

Fix added to [7486]. Thank you

Ok, understand.But this part is only detail. More important Current way totally wrong.

Main part my remark that required lua addon at _each_ client. And impossible do at server-side only.

In [7483]. Thank you

So for this you need have lua addon at client. Original question i think do it from server side.

This related to recieve outdated movement packets from clients from past after server side teleport that considered by fall code as fall. But bug not in fall code, but in not implementing some way to skip outdated packets in case near (same map) teleport. Maybe need rememeber time of teleport and skill any packets with in packet time < remembered. Or after send teleport packet to client skill all movement pakcets until some client confirmation about teleport packet recieve. Anyway this optopic for thread.

In fact i have modified patch already at you post time, so i push target seelction part to [7481]. Thank you 1) In not added part i not like aura checks by spell ids. Talent have proc flags and code must be in aura dummy spell proc function: Unit::HandleDummyAuraProc 2) from description meaning that mana restore at percent of target max mana? so Custom spell incorrect and mana gain must calculated into Energize effect. Not sure at 100% from other side

This is C++: int/int = intSo need first *100 and only after / or use floats.

I think this is wrong. in like cases in description write: max mana, and base mana referecnes to mana without bonuses. For example when writed spell cost in percent from base mana we use: m_caster->GetCreateMana()

Thank you for links By second version: 1) percentMana will be always 0 2) and can crash if player not have mana (not paladin case ofc)

Specialized is trade/lfg and similar. That pre-exist and builting in client functionality.

Can be it provided in one from normal ways: 1) or commit at some github repo branch 2) or all file chnage in one patch ?

With some chnages patch in [7476]. Thank you

Form must be tested in CheckCast and exist specail check for feral forms: player->IsInFeralForm() Why this need if this not ranked single spell with dummy aura. This is impossible for aura, or big bug in another place, anyway check useless. In fact i have already writed partly weeks ago patch. I will merge it with yuor version. If this will work.

This lot time answered. In short: channle join initiated by client and client can't be forced do it. Aceept fixed time specialized channels.

Why compare in like strange way? Look at damage in spell description in client and compare with damage in combat log.

Rechecked: work as expected.

O_LARGEFILE not portable, not exist like definition in win32 api.

"Can be backposted only very local typos fixes." This has bee not very correct conclusion ofc. I backport many not local changes to mangos-0.12 for switch time. Main problem with more backporting is DB structure changes. It's hard backported: backporting break possibility safly upgrade DB to master branch DB structure. But as i think some way for this found in result team discussion. But main my points still same: 1) development for latest client as only possible by many reasons. 2) old client branch not for development but for fixes and for backporting approriate parts from master branch.

In independent from my note that sql updates review required code check also, i think that sql updates in really can go to special category. It really special case. About other not sure.