VladimirMangos

From changes: 1) used in achievment code code style required use achievement criteria data type specific record instead raw fields. 2) player checks not required for gender/level. this checks can be used with creatures also. In discussedf achievment exist race requiredment that have player limitation so all ok. Added to 310 branch with this changes. Thank you

Ah, Thanks! Get it now... I accept patch and will add but before i need implement related achievement support and it can be added only to master 310 branch... When suggest patch for not master btanch _always_ pleas provide info about this...

Grrr.. I can read code and understand what this check do, but in what exactly achievement this need?

Yes. Ceris, thanks for clarify.

I think this part expected and speciialy coded.

achievement id that required this checks?

Possible fixed in [7968]. Please, test with it rev or later and report is this chnages help

I check at 0.12 branch and remove player.SetUnitMovementFlags(MOVEMENTFLAG_WALK_MODE); not help at it also.

Hmm, as i remember source problems not resolved... but i not re-check, sorry. So maybe i just have CRC errors in memory

Long time ago added

In [7946]. Thank you

In [7945]. Thank you for patch and wait

And where fix _real_ problem_ that prevented by this _know_ hack. As i remember in past exist probelms with stacking this effects with crash and srange work possibilities...

must be fixed in [7941]

3.2.1? Hmm,,, maybe when it will exist. I understand that this typo but any way lol. I think some ppl from future can answer at this question. When you tlak with with any from they please share your info.... As we live in present then only one answer exist: when it will ready. Silly topic closed.

Main reason: hard and not safe implemntation reload. Safe way near to same as disconnection all players that i more simple do just reload server it self. This answered many times: what you will do it aftre reload some itams absent in item_template but equipped/owned by players, what do it item statistics changes? Creature equipment now also dependent from item_template data. What do with it? Scan all world for like creatures... And other questions... If some have idea how this implement in clean and safe way then maybe it will added.

Second way added in to [7938]. Thank you

Patch added by author in 9b0c53b37423daf9a73f663c1965ac6a693cd335

Related achivments implemented in [7379]. Sorry, i not see your patch at moment my patch version writing. Anyway thank you for patch

Ok, additional review show that in some cases this pososble with not normal player but GM maybe or hacks using special possitions for wrong coordinates or somehting like. In [7936]. Thank you for patch finding and prepering to mangos. Sorry, we not very favor to T* project and sceptic when look at releated changes. But next time and _always_ provided info where patch found and who author, if this patch not writed by you.

In [7934]. Thank you. I replace hardcoded values by `achievement_criteria_data`.

good point... patch (in proper section)?

We not support repacks and not care about any repack problems. Just not use its.

In [7928]. Thank you

In [7926]. Thank you