Foereaper

This has already been reported in a previous ticket, some interesting discussion followed there as well.

The fix that worked for TC was pushed here:

[URL]https://github.com/mangoszero/server/commit/426c697a73839b89a117b8f1fc61eee696b6bc7c[/URL]

Something else is obviously playing up, though at this point I have no idea what. Like Trinity did, we should recreate the crash in Valgrind for some proper information. For reference sake I would still like for you to try this with both SD2 and Eluna disabled. The more we can rule out the better.

It will, you can disable one, the other, or both if you choose to do so. Least it does on Windows, haven't tested Linux build :) Anyway, some interesting information about the crash. See:

[URL]https://github.com/TrinityCore/TrinityCore/issues/5218[/URL]

The fix for this was pushed already not too long ago, however it is most likely something along the same lines as what Trinity faced. Also, note that this is a *NIX only issue.

Actually, for testing purposes. Would you mind disabling both Eluna and SD2 and see if any crashes occur?

The last stable version as far as my testing has gone is up until this commit:

[url]https://github.com/mangoszero/server/commit/1cd1b9614dec8a519af47bd30a65064d46ad1d2d[/url]

I have not yet had the time to venture past that commit, though I suspect it is either the timed event handler rewrite or the new ore system. I somewhat lean towards the latter as the stack trace contains information related to game object models.

[quote=Xenithar]Is it possible to set "CONF_DIR" to "/etc"? If so I can begin making the Debian packages again.[/quote]

Yes, however I will have to look into the technical aspects of doing this, as it may cause some issues with relative pathing. Will get to it once I have some spare time.

Fix has been pushed, please test and report back

[url]https://github.com/mangoszero/server/commit/9ee406aee5d2997901fa6699b35404fcc05f10aa[/url]

Testing now, will push fix shortly

I am testing a compile with external ACE now.

Say your install prefix is /home/usr/server. By default, the config dir would then be /home/usr/server/etc. If you would like the config dir to be /home/usr/etc, you would then use -DCONF_DIR=../etc/

As of this commit: [URL]https://github.com/mangoszero/server/commit/7e30aa81d033ea89b07cfd307b3310c943488a54[/URL]

Linux:
- Binary files are now installed at install_prefix/bin
- Config files are now by default installed to install_prefix/etc

Windows:
- Binary files are now installed at install_prefix
- Config files are now by default installed to install_prefix

CONF_DIR option is relative to install_prefix on both Windows and Linux. On linux this option defaults to: -DCONF_DIR=etc/

Notes:

lua_scripts directory and log files location are relative to the binary directory, this means;
Linux: install_prefix/bin
Windows: install_prefix

This can be changed in mangosd.conf, ie.

LogsDir = "../logs/"

The above would set the logs directory to:

install_prefix/logs

I have attempted to recreate this issue for roughly a week so far, unfortunately after 8 hours of gameplay I have not been able to find a good way to reproduce.. If possible, could you note exactly where everyone online are when this happens, as well as what people are doing specifically? Also, if possible, how long the server has been running.

Because the old one is horribly broken and is just a patch job for this to work as is. Also, this is an attempt at fixing the cmake build to be cross platform. Not a change. All of the above is simply install step settings.

Like I said, it is a work in progress. Fixing up the build system is not a one-step task. There is no need to get heated what so ever, simply state what is wrong, how it should be, and we'll get to it. If it is more urgent than that, you could always look at the install file and do the necessary changes for this to work like it should on Linux.

For reference sake, the internal ace library has been completely switched out.

This is due to the install step of the new build system, it is not yet complete :)

Good to hear :) The install location was made to be structurally similar to Windows, thus the binaries not being added to the bin folder. Will discuss this with LFX and Rochet as they know the install system better than I do. Will also take a look at using external Ace once we're done porting the system to One.

Edit:

Saw your update, it is not broken per se. For cmake to work properly on windows with a configurable conf dir, as that was wanted by a few, a new cmake option was added where you can specifically configure the path to the conf dir. -DCONF_DIR

Alright, will install a VM and try :) Mind attempting to try and use the internal ace lib just to see if you get the same error? If not then it's just down to an if statement :D

A lot changed since you left two weeks ago, we're currently working on restructuring the entire source as well as rewriting the build system :) What OS are you using and what cmake params are you using? Mind attempting to compile with internal ace to see if you have the same issues?

Did you use internal or external ace? Just tested and working on Ubuntu

The below commit will have to be ported to One. Do mind, changes done to ByteBuffer read/write SHOULD NOT be ported.

[url]https://github.com/mangoszero/server/commit/8d0d8b918bb8101b11ab80d9a80aa4c8d1716c0a[/url]

Final fix as of this commit:

[url]https://github.com/mangoszero/server/commit/12fc6cbc239445c23660b68476e29bf7bc50e2f5[/url]

Tested and working

As of the latest changes to Rel20, SD2 is no longer compiled as a shared library, but a static library and integrated into the binary :) Thus the above comment is no longer "valid" and the issue should be re-tested if it indeed was SD2 related :)

Fixed with this commit, please confirm:

[url]https://github.com/mangoszero/server/commit/8be9b36224aab1a76306c69628163b5c7f33ae0d[/url]

Check all the commits done to the AH bot files? :)

[url]https://github.com/mangoszero/server/commits/Rel20/src/game/AuctionHouseBot/AuctionHouseBot.cpp[/url]
[url]https://github.com/mangoszero/server/commits/Rel20/src/game/AuctionHouseBot/AuctionHouseBot.h[/url]
[url]https://github.com/mangoszero/server/commits/Rel20/src/game/AuctionHouseBot/CMakeLists.txt[/url]
[url]https://github.com/mangoszero/server/commits/Rel20/src/game/AuctionHouseBot/ahbot.conf.dist.in[/url]

He was "killed" in 5.0.4 during a quest line. The notes are not necessarily the correct ones for 1.x respectively :)