Talendrys

[url]https://github.com/Warkdev/server/commit/5b808e63aa265f394cd1d62610581f77c78edbca[/url]

That was really simple. When you've sources, it goes quick, when you don't, you waste time. :-)

Don't hesitate to report any other bug related to looting system, now I'm used to it.

All of mine do have names, so I guess it is. :-)

In fact, it solves all creatures types error, I removed by mistake a DBC load in a previous commit, all creatures in the game were humanoid then.

Commit has been identified and corrected: [url]https://github.com/Warkdev/server/commit/df9f84740bb57b3cc6847b6c0716aba90ac44cfd[/url].

Pets are back again !

However, don't forget to clean-up the WDB folder.

There was a global issue that I've introduced in Rel20 for all creatures type (not only hunter would have been hit, but they were really wrong). Now rolled back: [url]https://github.com/Warkdev/server/commit/df9f84740bb57b3cc6847b6c0716aba90ac44cfd[/url]

Don't forget to clean your WDB cache.

Adding a commit: [url]https://github.com/Warkdev/server/commit/9c95b4271669bcd48a1836124c945194b821a560[/url]

Please let me know.

Hello,

Should be fixed by this commit for both chest and group loot: [url]https://github.com/Warkdev/server/commit/9c95b4271669bcd48a1836124c945194b821a560[/url]

[quote=Xenithar]So you can loot the same chest with two players at the same time?
[/quote]

Yes.

[quote=Xenithar]Are the contents of the chest the same for both players?
[/quote]

No.

[quote=Xenithar]This sounds like something I should play with this weekend when I have some time![/quote]

To be honest, I wouldn't.. being 2 to work on such basic issue is too much.

Worflow: players are casting spell 3365 to open the chest (spell_cast_failed to notify that other have it open), then player::sendloot is actually generating the loots (if required) and setting the permissions, dolootrelease actually close the chest.

Remaining to do: Show open chest to other players than the one opening it.

Thats the visible part. For me visual and looting a chest that other player is already looting are also bugged.

Well, either you say that you fix things, either you dont. But if you do, i think you must do it properly.

Chests are not blizzlike actually. Working on it. And Im not an IT geek... I only have one standard computer, one screen and some times between activities...

[quote=Xenithar]How will you validate it without a group? Is there a way we can test group things solo? I have never tried so forgive my ignorance.[/quote]

I launch 2 clients with 2 accounts and I group them. I'm not fixing things and hopping it will work, I test quite some scenario's. ;-)

I will validate it. Just need to pop a chest btw :)

[quote=Xenithar]If group loot works, does setting the loot level for rolling work? In other words, if I set group loot and choose blue or better, will greens be rotated like whites as it should be, or will we still have to roll on greens?[/quote]

Yes it should. I did test with blue and epic.

[quote=Xenithar]
Also, does any of this fix the "never happened in a million years in official" issue where if I open a chest, the entire group must roll on items? Normally the group would do "/roll 100" and whomever had the highest roll got to open and loot the chest. However, in R19 (not sure about R20 yet) when I open a chest, my entire group gets to roll and win the items inside. Not Blizzlike at all.[/quote]

Didn't test that, only focused on creatures. Must give a try.

The part telling that everybody should be able to loot a corpse and get the view on items higher than the quality has not been implemented because we don't think it was the blizzlike way to do it.

Other issues have been fixed with commits:

[URL="https://github.com/mangoszero/server/commit/abaf96b6aeaa068c910cd30e4c12788b4debf516"]https://github.com/mangoszero/server/commit/abaf96b6aeaa068c910cd30e4c12788b4debf516[/URL]
[URL="https://github.com/mangoszero/server/commit/a17fabbf4da5624396c19f0bbd2646b7eb5dec15"]https://github.com/mangoszero/server/commit/a17fabbf4da5624396c19f0bbd2646b7eb5dec15[/URL]
[URL="https://github.com/mangoszero/server/commit/10f4de8495a9d41d22707971f23684f1f8b9fa32"]https://github.com/mangoszero/server/commit/10f4de8495a9d41d22707971f23684f1f8b9fa32[/URL]
[URL="https://github.com/mangoszero/server/commit/b8e91f1f87f675882fb1774c41abbca65bed2401"]https://github.com/mangoszero/server/commit/b8e91f1f87f675882fb1774c41abbca65bed2401[/URL]
[URL="https://github.com/mangoszero/server/commit/588d766c5704d02e06f6cb02906bcf2164d12086"]https://github.com/mangoszero/server/commit/588d766c5704d02e06f6cb02906bcf2164d12086[/URL]
[URL="https://github.com/mangoszero/server/commit/1fd8f4a8623dfbbabbdebd41dc0bd04b091612a9"]https://github.com/mangoszero/server/commit/1fd8f4a8623dfbbabbdebd41dc0bd04b091612a9[/URL]

Hello Xenithar,

For Zero (Rel20), group loot methods have been reworked and must be more blizzlike. If it's convenient for everybody, this can be ported to one and maybe two.

(don't forget to clone submodules while cloning again the sources)

[URL="https://github.com/mangoszero/server/commit/abaf96b6aeaa068c910cd30e4c12788b4debf516"]https://github.com/mangoszero/server/commit/abaf96b6aeaa068c910cd30e4c12788b4debf516[/URL]
[URL="https://github.com/mangoszero/server/commit/a17fabbf4da5624396c19f0bbd2646b7eb5dec15"]https://github.com/mangoszero/server/commit/a17fabbf4da5624396c19f0bbd2646b7eb5dec15[/URL]
[URL="https://github.com/mangoszero/server/commit/10f4de8495a9d41d22707971f23684f1f8b9fa32"]https://github.com/mangoszero/server/commit/10f4de8495a9d41d22707971f23684f1f8b9fa32[/URL]
[URL="https://github.com/mangoszero/server/commit/b8e91f1f87f675882fb1774c41abbca65bed2401"]https://github.com/mangoszero/server/commit/b8e91f1f87f675882fb1774c41abbca65bed2401[/URL]
[URL="https://github.com/mangoszero/server/commit/588d766c5704d02e06f6cb02906bcf2164d12086"]https://github.com/mangoszero/server/commit/588d766c5704d02e06f6cb02906bcf2164d12086[/URL]
[URL="https://github.com/mangoszero/server/commit/1fd8f4a8623dfbbabbdebd41dc0bd04b091612a9"]https://github.com/mangoszero/server/commit/1fd8f4a8623dfbbabbdebd41dc0bd04b091612a9[/URL]

Hello cabfever,

Many improvements have been done since your creation of this issue to all group loot methods. Various core crashes have also been fixed which will let you clone the last Rel20 and compile it to enjoy it. :-)

Let us know if you find any weird behavior with this or confirm if things are blizzlike.

Thanks !

[URL="https://github.com/mangoszero/server/commit/abaf96b6aeaa068c910cd30e4c12788b4debf516"]https://github.com/mangoszero/server/commit/abaf96b6aeaa068c910cd30e4c12788b4debf516[/URL]
[URL="https://github.com/mangoszero/server/commit/a17fabbf4da5624396c19f0bbd2646b7eb5dec15"]https://github.com/mangoszero/server/commit/a17fabbf4da5624396c19f0bbd2646b7eb5dec15[/URL]
[URL="https://github.com/mangoszero/server/commit/10f4de8495a9d41d22707971f23684f1f8b9fa32"]https://github.com/mangoszero/server/commit/10f4de8495a9d41d22707971f23684f1f8b9fa32[/URL]
[URL="https://github.com/mangoszero/server/commit/b8e91f1f87f675882fb1774c41abbca65bed2401"]https://github.com/mangoszero/server/commit/b8e91f1f87f675882fb1774c41abbca65bed2401[/URL]
[URL="https://github.com/mangoszero/server/commit/588d766c5704d02e06f6cb02906bcf2164d12086"]https://github.com/mangoszero/server/commit/588d766c5704d02e06f6cb02906bcf2164d12086[/URL]
[URL="https://github.com/mangoszero/server/commit/1fd8f4a8623dfbbabbdebd41dc0bd04b091612a9"]https://github.com/mangoszero/server/commit/1fd8f4a8623dfbbabbdebd41dc0bd04b091612a9[/URL]

Then, just overload existing shutdown command to add an optional message.

Does the same with all NPC having a GossipHello defined.

It's because the reference to PlayerTalkClass is lost during the method call GossipHello of SD2 (while the player isn't completely lost, at least that part is).

I've not root cause, verifying each commit from 7 days ago could help a bit.

We may update the existing server shutdown command with a flag at the end representing a standard type message. I would prefer that one rather than duplicating again and again shutdown commands.

Would you define them ?

Yeah, sorry, forgot to tell you Evildead.

I guess my fix is what you intended to do. ;-)

We just isolated that situation Xen'. Basically, it may happen with any creature attacking any other creature in some conditions.

Commands are in the database or in ChatHandler ;-)

also typing server in console will give you the options.

Sorry Xen' but I don't understand what you mean. On Zero, I've compared master, Rel19 and Rel20, it's impossible that "server shutdown" may have working in its actual state if players are connected.

Ok, just analysed the issue, 3 commands where found, only 2 were implemented:

- server exit (stops the server now)
- server shutdown (stops the server when idle - means no players connected anymore)
- server idleshutdown (not implemented)

My last PR, merged by Antz, must solve this issue, now:

- server exit (stops the server now)
- server shutdown (stops the server after X seconds, players gets message and are saved on stop)
- server idleshutdown (stops the server after X seconds or more if there're remaining players in game)

Hello, my last pr bas been merged. Group loot should be fixed properly. Master loot still suffers some issues. :-)