Jump to content

Chucksta

getMaNGOS Retired Staff
  • Posts

    552
  • Joined

  • Last visited

  • Days Won

    1
  • Donations

    0.00 GBP 

Bug Comments posted by Chucksta

  1. Windows 10!!! 

    use branch Develop21

    https://github.com/mangostwo/database/tree/Develop21

    You'll need to fork the branch to your own profile, just click on Fork button on the mangostwo database page

    https://github.com/mangostwo/database

    If your profile is called necrovoice and you don't have any other project with the name of database, you'll then have mangosteo database at:

    https://github.com/necrovoive/database

    You can commit changes via the github client, or directly from a git terminal using git commands

    client: https://desktop.github.com/

    git for windows: https://git-for-windows.github.io/

    with git for windows, you can right click on a folder and run git bash - a git terminal. Very useful.

    Say you have a folder on your PC called Mangos, to clone (download) the mangostwo repo, you'll need to work from your copy firth, then PR it. To do that:

    right click on the Mangos folder

    select git bash

    the terminal will open up

    then in the terminal you type:

    git clone --recursive git://github.com/necrovoice/database -b Develop21 

    You'll have under your Mangos folder, a folder called database

    Make the changes - adding a new update under World/Updates/Dev21 in your case

    Then if using the client, drag and drop the database folder to it - enter details - hit commit - hit Publish/Synch

    The go to your github account and your fork of the mangostwo database, and hit Create Pull Request

    Someone will then check it over and merge it for you

     

  2. [quote=Corsol].. Each vehicle has his own spell to active the dismount action... This spell can be discovered from search on wowhead or other portal that describe the vehicle in object.[/quote]

    This might be what Corsol is talking about:

    [url]http://www.wowhead.com/spells?filter=na=dismount[/url]

    Lots of dismount spells :)

    Without looking at the code, I presume something like:

    [QUOTE]Deathknight exits mount
    cast Dismount Deathcharger [COLOR="#FF0000"]

  3. [quote=Nagilum]Ok, but because i'm a noop at git, how to implement your update ?

    Do i just copy and past your addition in to the Opcode.ccp and do a build?

    Thats where i get lost...

    Nagilum[/quote]

    If that is the fix for it, then yes.

    Look for those lines in the file ([B]src/game/Server/Opcodes.cpp[/B]), and if the ones highlighted in red are still there, then replace them with the lines highlighted in green. Then rebuild :)


    [quote=Nagilum]Noop, Noob i just dont get it :D[/quote]

    Welcome to my world :D

    -------------------------------------------------------------------------------
    I just checked that file, and that code has already been applied.
    (I hadn't read the whole of the thread, lol)

  4. [quote=H0zen]The fix for this issue has been [URL="https://github.com/mangoszero/server/pull/60"]PR`ed[/URL]. The problem was the destruction of various static ACE_TSS objects. A great hint was quite the [URL="http://www.dre.vanderbilt.edu/Doxygen/5.7.9/html/ace/a00737.html#_details"]documentation[/URL] (the note)[/quote]

    Nice one, H0zen :D

    I am going to create an effigy to your awesomeness and show my devotion by sacrificing MadMax before your altar :)
    Or would you prefer the standard virgin maid?

    (moments of madness, priceless) :D

    Keep up the awesome work, matey :D

  5. Lots of nice work there, necrovoice :-)

    When performing an INSERT, you must DELETE the record first, otherwise if it exists, the INSERT will fail.

    e.g.
    [QUOTE]delete from creature where guid = 151032;
    insert into creature (guid, id, map, spawnMask, phaseMask, modelid, equipment_id, position_x, position_y, position_z, orientation, spawntimesecs, spawndist, currentwaypoint, curhealth, curmana, DeathState, MovementType) values(151032,16315,530,1,1,0,0,7051.7,-5811.42,46.5964,2.50734,472,5,0,270,295,0,1);[/QUOTE]



    I took the scripts and made a version for One and a version for Two (database record structures are not the same), applied them and they work as intended.

    I'll PR them now on One and Two.

    [B]ONE:[/B]
    [url]https://github.com/mangosone/database/pull/20[/url]

    [B]TWO:[/B]
    [url]https://github.com/mangostwo/database/pull/33[/url]

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use