Unkle Nuke

It has always been a very odd behavior of the AHBot that even when the percentage of an item color is set to zero, it will always continue to offer some items of that color. I think that somewhere in the AHBot code, something is preventing the percentages from being truly zero and returns a value of at least "1" instead. The entire code base needs a complete rewrite to fix such logic errors, have better error trapping, and replace the player character with an NPC. One must bear in mind this is based on a very old patch that has been maintained over the years, after the author left, but not actually developed much beyond keeping it updated with the MaNGOS core.

See post #23 in this thread. It helps if you bother to actually read through at least a page or two to know what's happening.

Creativity rarely is compatible with the more pragmatic matters of book-keeping. That's why the suits count the beans earned from the talent of the artists.

My mistake, DV. When you mentioned Dualspec, I thought you were referring to a seperate patch. There's still a few of those floating around, mostly from custom cores. By all means, continue to disclose every detail. That's the best way to figure out what needs fixed.

Some of the issues with how the Outdoor PvP zones behave are likely due to incomplete SQL data and some GOs probably need scripting. I'm learning as I work, so this might take a while for a patch as complex as this one. As for your merge errors, everyone knows Vehicle conflicts with everything! lol. I'm not sure why you're using DualSpec. That was added to the core a while back.

ankso, vehicles are treated as pets. That's why you owe your confusion to thinking the crash originated with pets. Something in the Vehicle code is messing up pets.

We could get the guys that make Robot Chicken to shoot a Warcraft movie using the collectible figures licensed by Blizzard from a few years ago.

Thanks for the update and continuing to support this patch, BThallid.

C++ works the same with MaNGOS as any other software. The main thing is to know the functions, classes, and variables. Finding the changes in the core and updating the code for OutdoorPvP is the hardest part if you already know C++. As I've said, feel free to contribute. That goes for the entire community! I couldn't be more proud of any work I've done than I would be if everyone comes together and makes OutdoorPvP fully working. We can't always rely on single developers to do everything for us. It would be a great moment for this community to know that OutdoorPvP was completed by all of us and added to the official core.

Good job! I hope you'll share your fixes with the community. There may be others who have been needing this updated.

It's all right there in the README for AuctionHouse Bot. Follow every step, exactly! rhaziel's trouble with mobs not dropping correct loot is not related to AHBot, unless he's completely screwed up his core with botched patches/merges. AHBot does not touch those areas of the source or database that deal with looting. Either way, learning how to properly patch/merge your source and mob loot drops are matters that you can get help with elsewhere in these forums. I recommend the sections labeled Source Code Management, Installation And Upgrades, and General Help. You have to learn the basics before you can step up to the more complex matters of working with patches. To do otherwise is inviting troubles and a broken server.

Well, duh! But that's not an MMORPG, which is the style of gameplay vladex and I were referring in our posts. @rulebreaker: I think Blizz could pull it off, catch lightning in a bottle once more, make another Starcraft, Warcraft, Diablo, or WoW...if they have the same drive, talent, and creativity that brought us those franchises. As a general rule, the more successful a publisher becomes, the more burdened by bureaucracy they become and the less willing a company is for taking chances and risking the bottom line.

yad has kept his Github repository current with MaNGOS master. Unfortunately, all of his old branches are now merged into a single code tree. This means you'll have to pick through the commits to find all the changes you'll need to have flying mounts everywhere working correctly. ...unless yad can be persuaded to return and post an updated patch.

That's my general condition for 23 hours each day.

Here's a patch for development work. Merged OutdoorPvP with MaNGOS rev. 10314. No code changes to this one, just updated existing work to latest core. Feel free to dig in and offer fixes. http://paste2.org/p/938057

If I recall, that was due to Liquids causing the crash, wasn't it? Is there a workaround for this? The last advice I remember was to just use the commit prior to implementing Liquids. Perhaps that commit can be used as a comparison against your updated code to snip out the parts relating to Liquids, sort of an "updated revert"?

Looks like Wotja liked DaViper's fixes. His latest push to Valhalla is nearly identical to the patch posted earlier. Good teamwork all around on this one, guys!

This patch works by changing mounts into trinkets or a non-armor clothing item. To do this, it must make a custom item that is linked to the "Summon Mount" spell for a particular mount. The trouble is that custom items no longer work by the method used. After client version 3.2.2a, items are hard-linked to the DBC entries. This means that you must find unused item IDs in the DBC files of the same type as the custom item with which you wish to replace it. So, a custom trinket would need an unused trinket from the DBC, just as using a custom shirt or tabard for the flying mount would also require an unused shirt or tabard in the DBC file. However, since these DBC files can change with every new patch or expansion, unused item IDs can suddenly come into use for official items. As such, you would need to revise the item IDs for the custom items to keep them working... but only if there are any remaining unused IDs for trinkets, shirts, or tabards. That's one reason why this patch declined into disuse. Perhaps someone might have a better method for dealing with custom items. If so, it would be deeply appreciated for details to be posted.

...and the "beating a dead horse" continues with yet another bump. If you wish to implement this, there is no actual patch, it is just a discussion for various ways to prevent cheating and hacking the client/server. CWN's relaxed anti-cheat or FH3095's anti-cheat are very close to having most of the ideas presented here implemented as a patch.

I refuse to acknowledge the existence of any country that calls a "cookie" by the name "biscuit" and has never heard of real biscuits. Southern style, made from scratch, buttermilk biscuits...with milk gravy seasoned with bacon drippings and ground black pepper!! <Homer Simpson drooling sounds>

Yes, you did, but I stand by my original statements. NYAH! I have the sinking feeling the XP Bar issue might be client-side. Only other places I can think that there may be server-side code to fix it might be in CharacterHandler.cpp or Player.cpp. One place to look at would be void Player::GiveLevel(uint32 level) in Player.cpp. (Disclaimer: The above technical advice is based purely on intuition and does not imply any technical expertise on the part of the person posting.) lol

Thanks for the update and for once more showing that you're still one of the best!

Oh no! Another patch to add to my server! Curse you, evil developers!! Still, good work on this, DV.

Judging by his reason given for editing the post, "I'm noobs", it would appear kingvaras felt what he had to say was dumb or pointless. There are no dumb questions, except for the ones people ask over and over again because they refuse to learn. Let's hope we hear more from you, kingvaras! We all start as "noobs".

@frostzhenya: The official repository for Vehicles is in the Tasssadar repository at Github. Wotja makes all his commits there. @vladex: Putting your heads together to learn things can sometimes be the best way to do it. Working with DaViper taught me more in five minutes than I'd managed to puzzle out on my own in an entire week! @DaViper: I read that and LAWLED! Keep up the good work.