mns

Same problem with [Living Ruby Pendant] http://www.wowhead.com/spell=31024 fix : DELETE FROM `spell_bonus_data` WHERE `entry` = 31024; INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('31024', '0', '0', '0','Item - Living Ruby Pedant');

Not stable . Exception code: C0000005 ACCESS_VIOLATION Fault address: 0000000078656B2E 01:0000000000035B2E C:\\WINDOWS\\WinSxS\\amd64_Microsoft.VC90.CRT_1fc8b3b9a1e18e3b_9.0.21022.8_x-ww_0296E955\\MSVCR90.dll Registers: RAX:000000007FFFFFFE RBX:0000000000000002 RCX:0000000000000002 RDX:0000000000000007 RSI:0000000000000025 RDI:000000000A596A73 R8: 0000000078620000 R9: 0000000000000000 R10:0000000000000200 R11:0000000000000000 R12:000000000A598F58 R13:00000000FFFFFFFF R14:00000000FFFFFFFF R15:000000000A5960A0 CS:RIP:0033:0000000078656B2E SS:RSP:002B:000000000A596640 RBP:024BA967 DS:002B ES:002B FS:0053 GS:002B Flags:00010202 Call stack: Address Frame Function SourceFile 0000000078656B2E 000000000A596940 _vcwprintf_s+2A06 0000000078635564 000000000A5969B0 _vsnprintf_l+80 00000000786355AD 000000000A5969F0 _vsnprintf+11 00000001402EC3E7 000000000A598470 MaNGOS::WorldWorldTextBuilder::operator()+97 d:\\compail-folder\\39-[s0651]_1934\\src\\game\\world.cpp line 1518 00000001402EC2D3 000000000A598D50 MaNGOS::LocalizedPacketListDo<MaNGOS::WorldWorldTextBuilder>::operator()+1B3 d:\\compail-folder\\39-[s0651]_1934\\src\\game\\gridnotifiersimpl.h line 512 00000001402E01AA 000000000A598F30 World::SendWorldText+1DA d:\\compail-folder\\39-[s0651]_1934\\src\\game\\world.cpp line 1570 000000014035EA01 000000000A599370 BattleGroundQueue::AddGroup+291 d:\\compail-folder\\39-[s0651]_1934\\src\\game\\battlegroundmgr.cpp line 184 0000000140520014 000000000A59F7D0 WorldSession::HandleBattlemasterJoinArena+934 d:\\compail-folder\\39-[s0651]_1934\\src\\game\\battlegroundhandler.cpp line 697 00000001402D65AD 000000000A59F870 WorldSession::ExecuteOpcode+5D d:\\compail-folder\\39-[s0651]_1934\\src\\game\\worldsession.cpp line 571 00000001402D46D5 000000000A59FAC0 WorldSession::Update+135 d:\\compail-folder\\39-[s0651]_1934\\src\\game\\worldsession.cpp line 186 00000001402E150C 000000000A59FC00 World::UpdateSessions+14C d:\\compail-folder\\39-[s0651]_1934\\src\\game\\world.cpp line 1853 00000001402DF5B7 000000000A59FDC0 World::Update+2E7 d:\\compail-folder\\39-[s0651]_1934\\src\\game\\world.cpp line 1386 000000014006F116 000000000A59FE80 WorldRunnable::run+A6 d:\\compail-folder\\39-[s0651]_1934\\src\\mangosd\\worldrunnable.cpp line 61 2011-01-09 10:07:13 WORLD: CMSG_BATTLEMASTER_JOIN_ARENA 2011-01-09 10:07:13 Battleground: arena join as group start 2011-01-09 10:07:13 Battleground: arena team id 5675, leader Djali queued with rating 1500 for type 2 2011-01-09 10:07:13 Adding Group to BattleGroundQueue bgTypeId : 6, bracket_id : 6, index : 1 Apparently queue announcer crashing .

Thank you . I will testing last revision tomorrow and feed back to you

How i can calculating coefficient bonus ? for example where spell = 5185 then direct_bonus = '1.6104' . how i can recalculating this ? this backporting must correcting for TBC

Not stable Crash server when join Eye of the Storm .

ok I backporting this again for [s0566] base commits : [8474] [8813] [8815] [10781] [10782] http://www.yourfilelink.com/get.php?fid=597722 I will test stability test at tomorrow Note : I do not correcting SQL and commit revision and makefile.am . commiter will be .....

Maybe cause forgotten [8815] backporting .

I research master branch and find [8488] will be backporting this

cause rev : [s0567] http://www.wowhead.com/spell=18790 SQL fix : DELETE FROM `spell_bonus_data` WHERE `entry` = 18790; INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('18790', '0', '0', '0','Warlock - Fel Stamina');

not yet I could not bilden crash again in local server and trace problem . maybe double delete BattleGround objects in special situation .

thx very good

yea I rollback server to s547 16 hour ago and not any crash again . Crash cause [s0548]

Base commits : [10781] [10782] I research several commits for full backporting but some commits refers to before mangos switch to Git and SVN researching is very hard [10782]->[10781]->[8818]->[8813]-> Git over ! ->[7269]->[9910]->[10363] After backporting [8818] must reapply this for some enums . http://www.speedyshare.com/files/25855953/download/10781-10782%20TBC%204.patch Note : I not stability test for this yet .

rev : s0550 how reapply crash ? Players reported when join in Arathi Basin and Eye of the Storm after enter battle crashing server but i can`t reapply this in local test server . over 20 crash in day Cash log : Exception code: C0000005 ACCESS_VIOLATION Call stack: Address Frame Function SourceFile 0000000140366A60 000000000A58F940 BattleGroundQueue::Update+30 d:\\compail-folder\\35-[s0550]_1913\\src\\game\\battlegroundmgr.cpp line 752 00000001403699FF 000000000A58FC00 BattleGroundMgr::Update+61F d:\\compail-folder\\35-[s0550]_1913\\src\\game\\battlegroundmgr.cpp line 1195 00000001402E7DCA 000000000A58FDC0 World::Update+6CA d:\\compail-folder\\35-[s0550]_1913\\src\\game\\world.cpp line 1397 000000014006D926 000000000A58FE80 WorldRunnable::run+A6 d:\\compail-folder\\35-[s0550]_1913\\src\\mangosd\\worldrunnable.cpp line 66 0000000140317F03 000000000A58FED0 ACE_Based::Thread::ThreadTask+23 d:\\compail-folder\\35-[s0550]_1913\\src\\shared\\threading.cpp line 190 00000000006F24AB 000000000A58FF10 ?invoke@ACE_OS_Thread_Adapter@@UEAAKXZ+5B 0000000078622FDF 000000000A58FF40 _endthreadex+47 0000000078623080 000000000A58FF70 _endthreadex+E8 0000000077D6B71A 000000000A58FFA0 BaseThreadStart+3A Local Variables And Parameters Call stack: Address Frame Function SourceFile 0000000140366A60 000000000A58F940 BattleGroundQueue::Update+30 d:\\compail-folder\\35-[s0550]_1913\\src\\game\\battlegroundmgr.cpp line 752 Local <user defined> 'this' Local <user defined> 'bgTypeId' Local <user defined> 'bracket_id' Local unsigned int 'arenaType' = 0 Local bool 'isRated' = 0 Local unsigned int 'arenaRating' = A58FFA8 Local <user defined> 'bg_template' Local <user defined> 'next' Local unsigned int 'MinPlayersPerTeam' = 1 Local unsigned int 'MaxPlayersPerTeam' = 0 Local <user defined> 'itr' 00000001403699FF 000000000A58FC00 BattleGroundMgr::Update+61F d:\\compail-folder\\35-[s0550]_1913\\src\\game\\battlegroundmgr.cpp line 1195 Local unsigned int 'i' = 40 Local <user defined> 'scheduled' Local unsigned int 'i' = 8 Local <user defined> 'this' Local unsigned int 'diff' = 0 Local <user defined> 'next' Local <user defined> 'itr' Debug log : 2010-12-22 18:07:11 Battleground: removing player 71361 from bg queue for instance 57 because of not pressing enter battle in time. 2010-12-22 18:07:11 BattleGroundQueue: Removing player GUID 71361, from bracket_id 6 2010-12-22 18:07:11 Battleground: removing player 28454 from bg queue for instance 57 because of not pressing enter battle in time. 2010-12-22 18:07:11 BattleGroundQueue: Removing player GUID 28454, from bracket_id 6 . . . I experience 6 day uptime before s0550 with s0498

Any way i think better commiting Ambal solution in git for public test . We can argue and correct patch after this We have 49 day time before overflow

base commit : 5360df3d643d3f8ad8fe0c015edface250df5a76 Correctly restore powers with energize-effect spells like Shadowfiend or Mana Tide Totem diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 52e7921..99c080f 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -7345,7 +7345,7 @@ void Unit::EnergizeBySpell(Unit *pVictim, uint32 SpellID, uint32 Damage, Powers { SendEnergizeSpellLog(pVictim, SpellID, Damage, powertype); // needs to be called after sending spell log - ModifyPower(powertype, Damage); + pVictim->ModifyPower(powertype, Damage); } uint32 Unit::SpellDamageBonus(Unit *pVictim, SpellEntry const *spellProto, uint32 pdamage, DamageEffectType damagetype, uint32 stack)

Update and test patch : [s0473]

Why use this patch ? Show message in monitor when GM login to game and hero is invisible . this can help GM to know is visible or invisible . diff --git a/src/game/CharacterHandler.cpp b/src/game/CharacterHandler.cpp index f1445f2..028e1b6 100644 --- a/src/game/CharacterHandler.cpp +++ b/src/game/CharacterHandler.cpp @@ -671,6 +671,9 @@ void WorldSession::HandlePlayerLogin(LoginQueryHolder * holder) if(pCurrChar->isGameMaster()) SendNotification(LANG_GM_ON); + if(!pCurrChar->isGMVisible()) + SendNotification(LANG_INVISIBLE_INVISIBLE); + std::string IP_str = GetRemoteAddress(); sLog.outChar("Account: %d (IP: %s) Login Character:[%s] (guid: %u)", GetAccountId(), IP_str.c_str(), pCurrChar->GetName(), pCurrChar->GetGUIDLow());

Last test [s0466] still bug !

Please accept or reject ! tell me if method of my fix is wrong .

Bug : when use http://www.wowhead.com/spell=18788 in sanctuary regions then pet not Sacrifice ! Caused commit : [s0225] Prevent damage player in sanctuary by pet or other controlled unit. in fact player must authoritative to Sacrifice own pet . diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 73d8d7e..fe8d1f6 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -508,7 +508,7 @@ uint32 Unit::DealDamage(Unit *pVictim, uint32 damage, CleanDamage const* cleanDa //You don't lose health from damage taken from another player while in a sanctuary //You still see it in the combat log though - if (pVictim != this && IsCharmerOrOwnerPlayerOrPlayerItself() && pVictim->IsCharmerOrOwnerPlayerOrPlayerItself()) + if (pVictim != this && IsCharmerOrOwnerPlayerOrPlayerItself() && pVictim->IsCharmerOrOwnerPlayerOrPlayerItself() && pVictim->GetOwner() != this) { const AreaTableEntry *area = GetAreaEntryByAreaID(pVictim->GetAreaId()); if (area && area->flags & AREA_FLAG_SANCTUARY) //sanctuary Now works properly in sanctuary regions Note : This spell expired for master branch and not need commit in master if not etc restriction .

Please opening "Post new topic" in "under review" section for registered members . I can`t post new patch

I can't create new topic in under review section . Lost some posts replys ! Thx TheLuda

this can help to found missed spells diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index b5abcb9..7b49835 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -7830,7 +7830,8 @@ uint32 Unit::SpellHealingBonus(Unit *pVictim, SpellEntry const *spellProto, uint DoneAdvertisedBenefit /= DotTicks*int32(stack); TakenAdvertisedBenefit /= DotTicks*int32(stack); } - } + }else + sLog.outError("Missed spell_bonus_data : %u",spellProto->Id); } // Distribute Damage over multiple effects, reduce by AoE CastingTime = GetCastingTimeForBonus( spellProto, damagetype, CastingTime );

emergency patch diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index b5abcb9..7b49835 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -7830,7 +7830,8 @@ uint32 Unit::SpellHealingBonus(Unit *pVictim, SpellEntry const *spellProto, uint DoneAdvertisedBenefit /= DotTicks*int32(stack); TakenAdvertisedBenefit /= DotTicks*int32(stack); } - } + }else + return healamount; } // Distribute Damage over multiple effects, reduce by AoE CastingTime = GetCastingTimeForBonus( spellProto, damagetype, CastingTime );