mns

in fact caused GetSpellDuration(spellProto) result . it's -1 Unit.cpp if(damagetype == DOT) { int32 DotDuration = GetSpellDuration(spellProto); // 200% limit if(DotDuration > 0) { if(DotDuration > 30000) DotDuration = 30000; if(!IsChanneledSpell(spellProto)) DotFactor = DotDuration / 15000.0f; int x = 0; for(int j = 0; j < 3; j++) { if( spellProto->Effect[j] == SPELL_EFFECT_APPLY_AURA && ( spellProto->EffectApplyAuraName[j] == SPELL_AURA_PERIODIC_DAMAGE || spellProto->EffectApplyAuraName[j] == SPELL_AURA_PERIODIC_LEECH) ) { x = j; break; } } int32 DotTicks = 6; if(spellProto->EffectAmplitude[x] != 0) DotTicks = DotDuration / spellProto->EffectAmplitude[x]; if(DotTicks) { DoneAdvertisedBenefit /= DotTicks*int32(stack); TakenAdvertisedBenefit /= DotTicks*int32(stack); } } } can you any fast solution or i must rollback own server ?

[s0242] For exampel : use http://www.wowhead.com/search?q=Healing+Stream+Totem+#abilities big healing

diff --git a/sql/updates/before_upgrade_to_0.13/Makefile.am b/sql/updates/before_upgrade_to_0.13/Makefile.am index 0846f50..08e78cc 100644 --- a/sql/updates/before_upgrade_to_0.13/Makefile.am +++ b/sql/updates/before_upgrade_to_0.13/Makefile.am @@ -50,6 +50,8 @@ pkgdata_DATA = \\ s0114_09136_01_characters_character_ticket.sql \\ s0201_7255_01_characters_characters.sql \\ s0216_7307_01_characters_arena_team_member.sql \\ + s0224_10503_01_characters_creature_respawn.sql \\ + s0224_10503_02_characters_gameobject_respawn.sql \\ README ## Additional files to include when running 'make dist' @@ -80,4 +82,6 @@ EXTRA_DIST = \\ s0114_09136_01_characters_character_ticket.sql \\ s0201_7255_01_characters_characters.sql \\ s0216_7307_01_characters_arena_team_member.sql \\ + s0224_10503_01_characters_creature_respawn.sql \\ + s0224_10503_02_characters_gameobject_respawn.sql \\ README diff --git a/sql/updates/before_upgrade_to_0.13/s0224_10503_01_characters_creature_respawn.sql b/sql/updates/before_upgrade_to_0.13/s0224_10503_01_characters_creature_respawn.sql new file mode 100644 index 0000000..5cdc551 --- /dev/null +++ b/sql/updates/before_upgrade_to_0.13/s0224_10503_01_characters_creature_respawn.sql @@ -0,0 +1,4 @@ +ALTER TABLE character_db_version CHANGE COLUMN required_s0224_10503_01_characters_creature_respawn required_s0216_7307_01_characters_arena_team_member bit; + +DROP TABLE IF EXISTS `creature_respawn`; + diff --git a/sql/updates/before_upgrade_to_0.13/s0224_10503_02_characters_gameobject_respawn.sql b/sql/updates/before_upgrade_to_0.13/s0224_10503_02_characters_gameobject_respawn.sql new file mode 100644 index 0000000..cca7dd9 --- /dev/null +++ b/sql/updates/before_upgrade_to_0.13/s0224_10503_02_characters_gameobject_respawn.sql @@ -0,0 +1,4 @@ +ALTER TABLE character_db_version CHANGE COLUMN required_s0224_10503_02_characters_gameobject_respawn required_s0224_10503_01_characters_creature_respawn bit; + +DROP TABLE IF EXISTS `gameobject_respawn`; + note : we can betake this revert and change character_db_version to required_s0216_7307_01 in future revert . but i think is better use this revert completely .

Applyed in [s0190] Please move thread to reject section . Thx Vladimir for recent several huge backportings tired Do not be .

caused commit [10379] diff --git a/src/game/ArenaTeam.cpp b/src/game/ArenaTeam.cpp index d8130aa..694db37 100644 --- a/src/game/ArenaTeam.cpp +++ b/src/game/ArenaTeam.cpp @@ -491,7 +491,7 @@ void ArenaTeam::BroadcastEvent(ArenaTeamEvents event, ObjectGuid guid, char cons { uint8 strCount = !str1 ? 0 : (!str2 ? 1 : (!str3 ? 2 : 3)); - WorldPacket data(SMSG_GUILD_EVENT, 1 + 1 + 1*strCount + (guid.IsEmpty() ? 0 : 8)); + WorldPacket data(SMSG_ARENA_TEAM_EVENT, 1 + 1 + 1*strCount + (guid.IsEmpty() ? 0 : 8)); data << uint8(event); data << uint8(strCount);

How to regain crash .char erase how to delete own character ! .char erase AnyCharacterName Maybe cause [s0103] Exception code: C0000005 ACCESS_VIOLATION Fault address: 00000001400157E2 01:00000000000147E2 F:\\hard\\mangosd.exe Registers: RAX:0000000000000000 RBX:000000000989AF90 RCX:000000000A572E78 RDX:000000000A570718 RSI:000007FFF7F56020 RDI:0000000140307260 R8: 7EFEFEFEFEFEFF64 R9: 00000000099F77E0 R10:8101010101010100 R11:0000000000000000 R12:0000000000000000 R13:0000000000000000 R14:0000000000000000 R15:000000000A570050 CS:RIP:0033:00000001400157E2 SS:RSP:002B:000000000A5705F0 RBP:00000000 DS:002B ES:002B FS:0053 GS:002B Flags:00010206 Call stack: Address Frame Function SourceFile 00000001400157E2 000000000A570700 ChatHandler::HandleCharacterEraseCommand+52 d:\\30-[s0168]_1816\\src\\mangosd\\clirunnable.cpp line 413 00000001401F6619 000000000A5708B0 ChatHandler::ExecuteCommand+129 d:\\30-[s0168]_1816\\src\\game\\chat.cpp line 1105 00000001401F6F42 000000000A572930 ChatHandler::ParseCommands+1C2 d:\\30-[s0168]_1816\\src\\game\\chat.cpp line 1238 00000001405D3245 000000000A57F810 WorldSession::HandleMessagechatOpcode+6C5 d:\\30-[s0168]_1816\\src\\game\\chathandler.cpp line 173 00000001402CD8AD 000000000A57F8B0 WorldSession::ExecuteOpcode+5D d:\\30-[s0168]_1816\\src\\game\\worldsession.cpp line 573 00000001402CBA25 000000000A57FB10 WorldSession::Update+135 d:\\30-[s0168]_1816\\src\\game\\worldsession.cpp line 187 00000001402D867C 000000000A57FC50 World::UpdateSessions+14C d:\\30-[s0168]_1816\\src\\game\\world.cpp line 1830 00000001402D6848 000000000A57FE20 World::Update+2D8 d:\\30-[s0168]_1816\\src\\game\\world.cpp line 1380 000000014006D9C5 000000000A57FE60 WorldRunnable::run+A5 d:\\30-[s0168]_1816\\src\\mangosd\\worldrunnable.cpp line 61 0000000140307283 000000000A57FED0 ACE_Based::Thread::ThreadTask+23 d:\\30-[s0168]_1816\\src\\shared\\threading.cpp line 190 00000000006F139B 000000000A57FF10 ?invoke@ACE_OS_Thread_Adapter@@UEAAKXZ+5B 0000000078622FDF 000000000A57FF40 _endthreadex+47 0000000078623080 000000000A57FF70 _endthreadex+E8 0000000077D6B71A 000000000A57FFA0 BaseThreadStart+3A

This patch can solve problem when vmap is disable . diff --git a/src/game/TargetedMovementGenerator.cpp b/src/game/TargetedMovementGenerator.cpp index 29877ac..0836290 100644 --- a/src/game/TargetedMovementGenerator.cpp +++ b/src/game/TargetedMovementGenerator.cpp @@ -77,8 +77,9 @@ void TargetedMovementGeneratorMedium<T,D>::_setTargetLocation(T &owner) // Just a temp hack, GetContactPoint/GetClosePoint in above code use UpdateGroundPositionZ (in GetNearPoint) // and then has the wrong z to use when creature try follow unit in the air. - if (owner.GetTypeId() == TYPEID_UNIT && ((Creature*)&owner)->canFly()) - z = i_target->GetPositionZ(); + if (owner.GetTypeId() == TYPEID_UNIT) + if ( ((Creature*)&owner)->canFly() || owner.GetPositionZ() > z+1.0f ) + z = i_target->GetPositionZ(); Traveller<T> traveller(owner); i_destinationHolder.SetDestination(traveller, x, y, z); side effect hack : Units can move to flyer target from overhead can solve this with check target is flyer or not but i think not important problem

miss again in s0169 SQL file not commited

and base commit form master ?

diff --git a/sql/updates/before_upgrade_to_0.13/Makefile.am b/sql/updates/before_upgrade_to_0.13/Makefile.am index 0f8919e..d97f039 100644 --- a/sql/updates/before_upgrade_to_0.13/Makefile.am +++ b/sql/updates/before_upgrade_to_0.13/Makefile.am @@ -47,6 +47,7 @@ pkgdata_DATA = \\ s0087_10312_02_characters_pet_aura.sql \\ s0099_10332_01_characters_character_aura.sql \\ s0099_10332_02_characters_pet_aura.sql \\ + s0114_09136_01_characters_character_ticket.sql \\ README ## Additional files to include when running 'make dist' @@ -74,4 +75,5 @@ EXTRA_DIST = \\ s0087_10312_02_characters_pet_aura.sql \\ s0099_10332_01_characters_character_aura.sql \\ s0099_10332_02_characters_pet_aura.sql \\ + s0114_09136_01_characters_character_ticket.sql \\ README diff --git a/sql/updates/before_upgrade_to_0.13/s0114_09136_01_characters_character_ticket.sql b/sql/updates/before_upgrade_to_0.13/s0114_09136_01_characters_character_ticket.sql new file mode 100644 index 0000000..e86b5cb --- /dev/null +++ b/sql/updates/before_upgrade_to_0.13/s0114_09136_01_characters_character_ticket.sql @@ -0,0 +1,4 @@ +ALTER TABLE character_db_version CHANGE COLUMN required_s0114_09136_01_characters_character_ticket required_s0099_10332_02_characters_pet_aura bit; + +ALTER TABLE `character_ticket` DROP COLUMN `response_text`; +

lost buff in Arena -> http://www.wowhead.com/spell=34709 diff --git a/src/game/BattleGround.h b/src/game/BattleGround.h index 32554e4..aa65709 100644 --- a/src/game/BattleGround.h +++ b/src/game/BattleGround.h @@ -30,7 +30,7 @@ #define BG_EVENT_DOOR 254 // only arena event // cause this buff apears 90sec after start in every bg i implement it here -#define ARENA_BUFF_EVENT 252 +#define ARENA_BUFF_EVENT 253 class Creature; in DB event1 = 253 Other solution : update gameobject_battleground set event1 = 252 where event1 = 253; update battleground_events set event1 = 252 where event1 = 253;

I can`t confirm crash in [s0096] ! one day uptime with 700+ online .

TakenTotal < 0 in some cases For Example : http://www.wowhead.com/search?q=dampen+magic diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index e647863..13ae7b2 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -7202,8 +7202,8 @@ uint32 Unit::SpellDamageBonus(Unit *pVictim, SpellEntry const *spellProto, uint3 // Taken/Done total percent damage auras float DoneTotalMod = 1.0f; float TakenTotalMod = 1.0f; - uint32 DoneTotal = 0; - uint32 TakenTotal = 0; + int32 DoneTotal = 0; + int32 TakenTotal = 0; // ..done // Pet damage @@ -7870,8 +7870,8 @@ uint32 Unit::SpellHealingBonus(SpellEntry const *spellProto, uint32 healamount, // Taken/Done total percent damage auras float DoneTotalMod = 1.0f; - uint32 DoneTotal = 0; - uint32 TakenTotal = 0; + int32 DoneTotal = 0; + int32 TakenTotal = 0; // Healing done percent AuraList const& mHealingDonePct = GetAurasByType(SPELL_AURA_MOD_HEALING_DONE_PERCENT);

http://www.wowhead.com/search?q=Healing+Way diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 3c60a5d..744213f 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -8043,7 +8043,7 @@ uint32 Unit::SpellHealingBonus(SpellEntry const *spellProto, uint32 healamount, Unit::AuraList const& auraDummy = pVictim->GetAurasByType(SPELL_AURA_DUMMY); for(Unit::AuraList::const_iterator itr = auraDummy.begin(); itr!=auraDummy.end(); ++itr) if((*itr)->GetId() == 29203) - TakenTotalMod *= (*itr)->GetModifier()->m_amount; + TakenTotalMod *= ((*itr)->GetModifier()->m_amount+100.0f)/100.0f; } heal = (heal + TakenTotal) * TakenTotalMod; Bug caused [s0060] Backporting in [7190]

This is natural after hard work in programing I see you simultaneous working in several branchs and i very thankful to you for working in 0.12 branch Good luck .

I not understand your purpose Please illustrate to me

diff --git a/sql/updates/before_upgrade_to_0.13/Makefile.am b/sql/updates/before_upgrade_to_0.13/Makefile.am index 3fd0aa7..6a23474 100644 --- a/sql/updates/before_upgrade_to_0.13/Makefile.am +++ b/sql/updates/before_upgrade_to_0.13/Makefile.am @@ -42,6 +42,7 @@ pkgdata_DATA = \\ 111_9767_03_characters_characters.sql \\ 112_8874_01_characters_character_skills.sql \\ 114_9849_01_characters_saved_variables.sql \\ + s0041_10254_01_characters_auctionhouse.sql \\ README ## Additional files to include when running 'make dist' @@ -64,4 +65,5 @@ EXTRA_DIST = \\ 111_9767_03_characters_characters.sql \\ 112_8874_01_characters_character_skills.sql \\ 114_9849_01_characters_saved_variables.sql \\ + s0041_10254_01_characters_auctionhouse.sql \\ README diff --git a/sql/updates/before_upgrade_to_0.13/s0041_10254_01_characters_auctionhouse.sql b/sql/updates/before_upgrade_to_0.13/s0041_10254_01_characters_auctionhouse.sql new file mode 100644 index 0000000..ee2551d --- /dev/null +++ b/sql/updates/before_upgrade_to_0.13/s0041_10254_01_characters_auctionhouse.sql @@ -0,0 +1,16 @@ +ALTER TABLE character_db_version CHANGE COLUMN required_s0041_10254_01_characters_auctionhouse required_114_9849_01_characters_saved_variables bit; + +DROP TABLE IF EXISTS auctionhouse; +RENAME TABLE auction TO auctionhouse; + +ALTER TABLE auctionhouse + ADD COLUMN location tinyint(3) unsigned NOT NULL DEFAULT '3' AFTER deposit; + +ALTER TABLE auctionhouse + ADD COLUMN auctioneerguid int(11) unsigned NOT NULL DEFAULT '0' AFTER id; + +UPDATE auctionhouse SET location = houseid; + +ALTER TABLE auctionhouse + DROP COLUMN houseid; +

hi diff --git a/src/game/BattleGroundMgr.cpp b/src/game/BattleGroundMgr.cpp index 5db8e52..a4c750c 100644 --- a/src/game/BattleGroundMgr.cpp +++ b/src/game/BattleGroundMgr.cpp @@ -1139,7 +1139,7 @@ void BattleGroundMgr::Update(uint32 diff) } } // if rating difference counts, maybe force-update queues - if(sWorld.getConfig(CONFIG_UINT32_ARENA_MAX_RATING_DIFFERENCE)) + if(sWorld.getConfig(CONFIG_UINT32_ARENA_MAX_RATING_DIFFERENCE) && sWorld.getConfig(CONFIG_UINT32_ARENA_RATING_DISCARD_TIMER)) { // it's time to force update if(m_NextRatingDiscardUpdate < diff) Without this patch players enter to arena without checking rating if Arena.MaxRatingDifference > 0 and Arena.RatingDiscardTimer > 0 . and this cause prevent spam update queue when players join in arena . Increase performance have fun corrected arena .

possible caused by your Anti Cheat mind control cause report misstiming in Anti Cheat Check . Disable misstiming check and test again

Not for any user ! More users using bin file for extracting MAP and VMAP .

after [Work vs Auras] client show wrong spell stack ! for example : .cast 33763 stack = 1 .cast 33763 stack = 3 instead 2 ! .cast 33763 stack = 4 instead 3 !

We hopeful to you and Lynx3d and faramir118 I like Mangos-0.12 Map is Great infirmity in 0.12

based on commit : [fc1c10be8d6ac263fa4c877ea568f31d7c31a220] [7119] diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index bd45e9a..0890ce5 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -486,7 +486,7 @@ void Spell::EffectSchoolDMG(SpellEffectIndex effect_idx) Aura *poison = 0; // Lookup for Deadly poison (only attacker applied) Unit::AuraList const& auras = unitTarget->GetAurasByType(SPELL_AURA_PERIODIC_DAMAGE); - for(Unit::AuraList::const_iterator itr = auras.begin(); itr!=auras.end() && combo;) + for(Unit::AuraList::const_iterator itr = auras.begin(); itr!=auras.end(); ++itr) { // Deadly poison (only attacker applied) if( (*itr)->GetSpellProto()->SpellFamilyName==SPELLFAMILY_ROGUE && ((*itr)->GetSpellProto()->SpellFamilyFlags & UI64LIT(0x10000)) &&

Fix http://www.wowhead.com/spell=770 Remove affected . Based on commit : [bd60bd129f1420edc33730389b1d8ffc10fe064c] need after : [b98e7fcd806d8b295de982f475ad035bc98c14a3] diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index c921bc2..aedec26 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -952,7 +952,7 @@ void Aura::_AddAura() if (!secondaura) { // Update Seals information - if( IsSealSpell(GetSpellProto()) ) + if (IsSealSpell(m_spellProto)) m_target->ModifyAuraState(AURA_STATE_JUDGEMENT, true); // Conflagrate aura state @@ -1055,7 +1055,9 @@ bool Aura::_RemoveAura() removeState = AURA_STATE_CONFLAGRATE; // Conflagrate aura state break; case SPELLFAMILY_DRUID: - if(m_spellProto->SpellFamilyFlags & 0x50) + if(m_spellProto->SpellFamilyFlags & UI64LIT(0x0000000000000400)) + removeState = AURA_STATE_FAERIE_FIRE; // Faerie Fire (druid versions) + else if(m_spellProto->SpellFamilyFlags & 0x50) { removeFamilyFlag = 0x50; removeState = AURA_STATE_SWIFTMEND; // Swiftmend aura state

Confirm in mangos 0.12