mns

This code in TradeHandler.cpp add enchantment to traded Item after accept trade but not effecting and decrease item enchantment charges or stack . possible missed spell information setting. his_spell = new Spell(trader, spellEntry, true); his_spell->m_CastItem = castItem; his_targets.setTradeItemTarget(trader); his_spell->m_targets = his_targets; . . . . if (his_spell) his_spell->prepare(&his_targets); Emergency fix (not offilike): Deleting this code in spell.cpp // if trade not complete then remember it in trade data if (!my_trade->IsInAcceptProcess()) { // Spell will be casted at completing the trade. Silently ignore at this place my_trade->SetSpell(m_spellInfo->Id, m_CastItem); return SPELL_FAILED_DONT_REPORT; } this cause enchant accept without problem before accepting trade .

Bug still in [6f44fd6b7913d3834eae75ebbba35f833107830c]

After [non-trade slot item enchanting at trade complete] some items enchantments can be used in trade . but in fact they should not be used in trade. Edit : This part is old Bug (some items enchantments can be used in trade .but in fact they should not be used in trade) New Bug is enchantmets spell in trade not effect and decrease enchantment items . for example : http://www.wowhead.com/item=29535 http://www.wowhead.com/item=24276 this cause item enchantment not decrease and player can use that item again and again . Another one : when used some enchantments in items must be decrease charges but now it doesn't do so . for example : http://www.wowhead.com/item=22522

Still Bug in [e461658419d547ad29962c052d632a2f9be2b516]

Fixed in [10080] and Backporting Thank Vladimir

in last rev when player is dead and click [Release Spirit] then not teleport to Spirit Healer and after click Accept Hero teleport to Spirit Healer and the Hero is in Live and Full HP

sorry to wrong section reporting please remove topic to bug report section

Rev cause : 26072a2986964e3323a78fa4354f2e3ded28b556 Server crash when player teleport by quest . http://udbwiki.webhop.net/index.php/Quest_start_scripts when use 6 Command . Teleports the player to a location. SCRIPT_COMMAND_TELEPORT_TO = 6 * datalong: Target Map ID. See Maps.dbc * x: Teleport target x coordinate. * y: Teleport target y coordinate. * z: Teleport target z coordinate. * o: Teleport target orientation. Call stack: Address Frame Function SourceFile 0000000140153B93 0000000008ED9EA0 stdext::_Hash<stdext::_Hmap_traits<unsigned __int64,GameObject * __ptr64,stdext::hash_compare<unsigned __int64,std::less<unsigned __int64> >,std::allocator<std::Pair<unsigned __int64 const ,GameObject * __ptr64> >,0> >::lower_bound+33 c:\\program files (x86)\\microsoft visual studio 9.0\\vc\\include\\xhash line 597 0000000140153AF0 0000000008ED9F50 TypeUnorderedMapContainer<TypeList<Creature,TypeList<Pet,TypeList<GameObject,TypeList<DynamicObject,TypeNull> > > >,unsigned __int64>::find<GameObject>+30 d:\\compail-folder\\src\\framework\\gamesystem\\typecontainer.h line 121 0000000140153892 0000000008ED9FE0 TypeUnorderedMapContainer<TypeList<Creature,TypeList<Pet,TypeList<GameObject,TypeList<DynamicObject,TypeNull> > > >,unsigned __int64>::find<GameObject,Creature,TypeList<Pet,TypeList<GameObject,TypeList<DynamicObject,TypeNull> > > >+72 d:\\compail-folder\\src\\framework\\gamesystem\\typecontainer.h line 143 0000000140135561 0000000008EDA050 Map::GetGameObject+31 d:\\compail-folder\\src\\game\\map.cpp line 3351 00000001401AFFB5 0000000008EDB2D0 Player::UpdateForQuestsGO+1E5 d:\\compail-folder\\src\\game\\player.cpp line 18508 000000014018DFFE 0000000008EDD620 Player::AddQuest+67E d:\\compail-folder\\src\\game\\player.cpp line 12566 00000001405B8FB1 0000000008EDF810 WorldSession::HandleQuestgiverAcceptQuestOpcode+4C1 d:\\compail-folder\\src\\game\\questhandler.cpp line 155 00000001402B907A 0000000008EDFB20 WorldSession::Update+13A d:\\compail-folder\\src\\game\\worldsession.cpp line 186 00000001402CADFC 0000000008EDFC60 World::UpdateSessions+14C d:\\compail-folder\\src\\game\\world.cpp line 1806 00000001402C8F78 0000000008EDFE20 World::Update+2D8 d:\\compail-folder\\src\\game\\world.cpp line 1355 000000014006E405 0000000008EDFE60 WorldRunnable::run+A5 d:\\compail-folder\\src\\mangosd\\worldrunnable.cpp line 61 00000001402F7953 0000000008EDFED0 ACE_Based::Thread::ThreadTask+23 d:\\compail-folder\\src\\shared\\threading.cpp line 190 00000000006F170B 0000000008EDFF10 [email="?invoke@ACE_OS_Thread_Adapter@@UEAAKXZ+5B"]?invoke@ACE_OS_Thread_Adapter@@UEAAKXZ+5B[/email] 0000000078622FDF 0000000008EDFF40 _endthreadex+47 0000000078623080 0000000008EDFF70 _endthreadex+E8 0000000077D6B71A 0000000008EDFFA0 BaseThreadStart+3A 2010-06-18 10:28:19 WORLD: Received CMSG_QUESTGIVER_ACCEPT_QUEST npc = 96653, quest = 91201 2010-06-18 10:28:19 Player Justwarior is being teleported to map 0 2010-06-18 10:28:19 Remove player Justwarior from grid[28,42] Note : I use custom quest . my quest teleport player to custom location in other map . my quest work fine before 26072a2986964e3323a78fa4354f2e3ded28b556

I will researching related commit and create new compatible backporting patch some related commits : 9347 9323 7465 7025 9774 7701 8426 9324 8329 7330 this commits backporting by you (Vladimir) But with some conflict to procflag commit . this backporting is very hard , but i'm very stubborn

Test this SQl query in characters DB truncate table `instance_reset`; Note : Mangos re extract this table at startup

if you are pro you can ! else mangos can`t teach to you not supported branch and you must wait to switching master branch to 4.x.x

Correcting patch for last revision [fba3116e55707096268ee9dbe20d06659f5733f1] 8182_8725_8729_8739

diff --git a/src/mangosd/mangosd.conf.dist.in b/src/mangosd/mangosd.conf.dist.in index 8716cf7..29addce 100644 --- a/src/mangosd/mangosd.conf.dist.in +++ b/src/mangosd/mangosd.conf.dist.in @@ -1382,8 +1382,6 @@ Ra.Stricted = 1 SOAP.Enabled = 0 SOAP.IP = 127.0.0.1 SOAP.Port = 7878 -<<<<<<< HEAD -======= ################################################################################################################### # CharDelete.Method @@ -1411,4 +1409,3 @@ SOAP.Port = 7878 CharDelete.Method = 0 CharDelete.MinLevel = 0 CharDelete.KeepDays = 30 ->>>>>>> e8e3ff9... [9767] Add the posibility to keep deleted characters in the database for a while and also add related commands.

Buzz! Please commit vladimir

hi When NPC cast pet summoner spell server crash ! Example : .list c 458 .go c npc guid Server crash ! http://www.wowhead.com/npc=458 this npc cast http://www.wowhead.com/spell=8656 at ACID Exception code: C0000005 ACCESS_VIOLATION Fault address: 00000001403F4DDA 01:00000000003F3DDA F:\\hard\\mangosd.exe Registers: RAX:0000000000000000 RBX:000007FFFC696E20 RCX:000007FF6A314000 RDX:F130000D58003732 RSI:000007FFFFCE1800 RDI:0000000000000038 R8: 000007FF6A3160E0 R9: 0000000000000000 R10:000007FF6A93A24C R11:0000000000000000 R12:0000000000000000 R13:0000000000000000 R14:0000000000000000 R15:0000000008EA0D80 CS:RIP:0033:00000001403F4DDA SS:RSP:002B:0000000008EA1320 RBP:00000000 DS:002B ES:002B FS:0053 GS:002B Flags:00010206 Call stack: Address Frame Function SourceFile 00000001403F4DDA 0000000008EA2450 Pet::InitPetCreateSpells+18A d:\\mangos\\src\\game\\pet.cpp line 1664 0000000140563E7A 0000000008EAC8F0 Spell::EffectSummonPet+D8A d:\\mangos\\src\\game\\spelleffects.cpp line 4031 00000001403BCC58 0000000008EAC950 Spell::HandleEffects+178 d:\\mangos\\src\\game\\spell.cpp line 3288 00000001403B124B 0000000008EB1AB0 Spell::DoSpellHitOnUnit+85B d:\\mangos\\src\\game\\spell.cpp line 1000 00000001403B06FC 0000000008EB4C00 Spell::DoAllEffectOnTarget+1DC d:\\mangos\\src\\game\\spell.cpp line 856 00000001403B81D4 0000000008EB4CA0 Spell::handle_immediate+124 d:\\mangos\\src\\game\\spell.cpp line 2353 00000001403B7F77 0000000008EB6DF0 Spell::cast+867 d:\\mangos\\src\\game\\spell.cpp line 2336 00000001403B8DF3 0000000008EBBFB0 Spell::update+363 d:\\mangos\\src\\game\\spell.cpp line 2529 00000001403C5D5B 0000000008EBC060 SpellEvent::Execute+4B d:\\mangos\\src\\game\\spell.cpp line 5283 00000001405EC40E 0000000008EBC110 EventProcessor::Update+15E d:\\mangos\\src\\framework\\utilities\\eventprocessor.cpp line 47 000000014009D276 0000000008EC1210 Unit::Update+46 d:\\mangos\\src\\game\\unit.cpp line 356 00000001400E621D 0000000008EC6470 Creature::Update+7FD d:\\mangos\\src\\game\\creature.cpp line 462 0000000140142535 0000000008EC6500 MaNGOS::ObjectUpdater::Visit+F5 d:\\mangos\\src\\game\\gridnotifiersimpl.h line 49 000000014014242D 0000000008EC6570 VisitorHelper<MaNGOS::ObjectUpdater,Creature>+1D d:\\mangos\\src\\framework\\gamesystem\\typecontainervisitor.h line 48 0000000140141AFD 0000000008EC65A0 VisitorHelper<MaNGOS::ObjectUpdater,Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > >+1D d:\\mangos\\src\\framework\\gamesystem\\typecontainervisitor.h line 54 00000001401412B0 0000000008EC65D0 VisitorHelper<MaNGOS::ObjectUpdater,GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > >+30 d:\\mangos\\src\\framework\\gamesystem\\typecontainervisitor.h line 55 0000000140140B8D 0000000008EC6600 VisitorHelper<MaNGOS::ObjectUpdater,TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > >+1D d:\\mangos\\src\\framework\\gamesystem\\typecontainervisitor.h line 61 000000014013CD43 0000000008ECA6B0 Map::Visit<MaNGOS::ObjectUpdater,TypeMapContainer<TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > > >+113 d:\\mangos\\src\\game\\map.h line 606 0000000140135AE5 0000000008ECB770 Cell::Visit<MaNGOS::ObjectUpdater,TypeMapContainer<TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > > >+95 d:\\mangos\\src\\game\\cellimpl.h line 47 000000014011A40B 0000000008ECFB80 Map::Update+59B d:\\mangos\\src\\game\\map.cpp line 637 00000001403145FF 0000000008ECFC70 MapManager::Update+19F d:\\mangos\\src\\game\\mapmanager.cpp line 252 00000001402B13D6 0000000008ECFE20 World::Update+726 d:\\mangos\\src\\game\\world.cpp line 1381 00000001400698B5 0000000008ECFE60 WorldRunnable::run+A5 d:\\mangos\\src\\mangosd\\worldrunnable.cpp line 61 00000001402D0773 0000000008ECFED0 ACE_Based::Thread::ThreadTask+23 d:\\mangos\\src\\shared\\threading.cpp line 190

I can confirm this

Add other Backporting http://gist.github.com/mangos/mangos/commit/a2e3c59dd2e3afe02a49c6eabfabb427ab98a88c 8182_8725_8729_8739 2 days uptime in 500+ player Please commit to mangos-0.12 Thx barlok for point me to crash cause .

thx balrok but why you not commited this too Mangos-0.12 ? I endeavor use backporting because Vladimir alway endeavor for Increase compatibility mangos-0.12 to master if we use not compatible patch for fixing then future backporting will be too hard .

ok I first rollback 8eb70eff6e9727a404e095a9978add4fd09677fc patch then if stop crashing use fix patch and test again very thx for fast reply

rev : 421b2459a5c62c032c2a61f22ff6c52030dc9038 over 30 crash in day http://paste2.org/p/754343

For 097_9611_01_characters.sql : ALTER TABLE character_db_version CHANGE COLUMN required_097_9611_01_characters required_091_9339_01_characters_group bit; ALTER TABLE `group_member` DROP INDEX `Idx_memberGuid`; ALTER TABLE `guild_eventlog` DROP INDEX `Idx_PlayerGuid1`; ALTER TABLE `guild_eventlog` DROP INDEX `Idx_PlayerGuid2`; ALTER TABLE `guild_bank_eventlog` DROP INDEX `Idx_PlayerGuid`; ALTER TABLE `petition_sign` DROP INDEX `Idx_playerguid`; ALTER TABLE `petition_sign` DROP INDEX `Idx_ownerguid`; ALTER TABLE `guild_eventlog` DROP INDEX `Idx_LogGuid`; ALTER TABLE `guild_bank_eventlog` DROP INDEX `Idx_LogGuid`; ALTER TABLE `guild_bank_item` DROP INDEX `Idx_item_guid`; ALTER TABLE `corpse` DROP INDEX `Idx_player`; ALTER TABLE `corpse` DROP INDEX `Idx_time`; ALTER TABLE `guild_rank` DROP INDEX `Idx_rid`;

before_upgrade_to_0.13 diff --git a/sql/updates/before_upgrade_to_0.13/091_9339_01_characters_group.sql b/sql/updates/before_upgrade_to_0.13/091_9339_01_characters_group.sql new file mode 100644 index 0000000..f3be2b7 --- /dev/null +++ b/sql/updates/before_upgrade_to_0.13/091_9339_01_characters_group.sql @@ -0,0 +1,14 @@ +ALTER TABLE character_db_version CHANGE COLUMN required_091_9339_01_characters_group required_066_8409_01_characters_guild bit; + +ALTER TABLE group_member + CHANGE COLUMN `groupId` `leaderGuid` int(11) unsigned NOT NULL; + +UPDATE `group_member`,`groups` SET `group_member`.`leaderGuid` = `groups`.`leaderGuid` WHERE `group_member`.`leaderGuid` = `groups`.`groupId`; + +ALTER TABLE groups + DROP COLUMN `groupId`; + +ALTER TABLE groups + DROP INDEX `leaderGuid`, + ADD PRIMARY KEY (`leaderGuid`); + diff --git a/sql/updates/before_upgrade_to_0.13/Makefile.am b/sql/updates/before_upgrade_to_0.13/Makefile.am index 9b94c02..699f852 100644 --- a/sql/updates/before_upgrade_to_0.13/Makefile.am +++ b/sql/updates/before_upgrade_to_0.13/Makefile.am @@ -35,6 +35,7 @@ pkgdata_DATA = \\ 066_8402_01_characters_guild_eventlog.sql \\ 066_8402_02_characters_guild_bank_eventlog.sql \\ 066_8409_01_characters_guild.sql \\ + 091_9339_01_characters_group.sql \\ README ## Additional files to include when running 'make dist' @@ -50,4 +51,5 @@ EXTRA_DIST = \\ 066_8402_01_characters_guild_eventlog.sql \\ 066_8402_02_characters_guild_bank_eventlog.sql \\ 066_8409_01_characters_guild.sql \\ + 091_9339_01_characters_group.sql \\ README Patch file

Need backporting to 0.12 Branch

diff --git a/src/mangosd/mangosd.conf.dist.in b/src/mangosd/mangosd.conf.dist.in index 63201c5..8cfc258 100644 --- a/src/mangosd/mangosd.conf.dist.in +++ b/src/mangosd/mangosd.conf.dist.in @@ -665,6 +665,7 @@ AllFlightPaths = 0 AlwaysMaxSkillForLevel = 0 ActivateWeather = 1 CastUnstuck = 1 +MaxSpellCastsInChain =10 Instance.IgnoreLevel = 0 Instance.IgnoreRaid = 0 Instance.ResetTimeHour = 4 thx veladimir for very useful patch

Please Stop ! your crashs not related groups changes . maybe conflict spells and loop