przemratajczak

MANGOS: 9272 I'm not quite shure if it is a bug but when tying to fix issue with Prison Break quest i found something like that: 1) GO arcane prison is casting spell http://thottbot.com/s45447 at use (go template triggered) 2) this spell has effect forcing player to cast http://thottbot.com/s45449 . 45449 has TARGET_SCRIPT implicit target. but when cast of 45449 is processed nothing is happening. It is not applying spell effects. even when trying to .cast 45449 core does not reach void Spell::EffectDummy(uint32 i) I must confess that i've got custom code in Spell::handle_immediate() ( http://www.pastebin.org/85181 ) checking if lists are not empty so i wondered why m_UniqueGOTargetInfo is empty or filled with null pointer when EffectImplicitTarget is set in spell_script_target ( http://www.pastebin.org/85184 ) and found that after grid searcher finished to lookup for nearest matching target, GO is stored in goScriptTarget but goScriptTarget is not pushed back to AddGOTarget() for TARGET_SCRIPT when added http://www.pastebin.org/85186 everything works normal now maybe i misunderstood something in mechanic how this quest should work, but lack of goScriptTarget pushed back to Targets when the same is done for units was confusing for me.

if ( Pet* pet = GetPet()) { if (pet->IsWithinDistInMap(this, GetMap()->GetVisibilityDistance()) && (GetCharmGUID() && (pet->GetGUID() != GetCharmGUID()))) RemovePet(pet, PET_SAVE_NOT_IN_SLOT, true); else if (m_petScalingUpdateTimer) { if (m_petScalingUpdateTimer <= p_time) { pet->UpdateScalingAuras(); m_petScalingUpdateTimer = 0; } else m_petScalingUpdateTimer -= p_time; } } try something like that in Player.cpp in place where UpdateScalingAuras is called

MaNGOS: 9272 Any creature with InhabitType = 2 and MovementType = 1 are falling on the bottom. how to reproduce: 1) spawn creature insert into creature values ('9000006','25203','571','1','1','0','0','4569.34','6325.88','-47.3439','4.84171','300','20','0','9291','0','0','1'); 2) make it use InhabitType = 2 UPDATE creature_template SET InhabitType = 2 WHERE entry = 25203; look what happens. I tried creature_addon MONSTER_MOVE_UNK13 nor MONSTER_MOVE_FLY was working. Sometimes update is not sent to player that creature remain in original spawn point but players can see it at the bootom or in different place

Maybe SPELL_ATTR_EX3_MAIN_HAND? edit sorry, read everything carefully now (Gouge and Envenom are included in SPELL_ATTR_EX3_MAIN_HAND)

IFAIK loot recipient is set by first damage, the same with XP. When npc pull another creature and player assist him in killing victim && npc is not pet nor charmed unit all credits are going to npc. Thats hows working for example siege events. Netherstorm: nether beasts with ~1.5k HP and 70lvl are giving full xp because right after respawn they are marked and attacked by Archers that makes them giving no XP to players that try to grind on them. The same for infernals around horde camp in Shadowmoon Valley. If you now any place on offi when such a event is happening on around 30lvl I can checkout how it works

indeed, tool tip of triggered spell indicates that it is 0.05 but main spell should get 0.15

thanks pet spell branch will be also updated?

i havn't time to take a look at whole patch and test it in game but at the first briefly glance this part of code makes me confused: SetModifierValue(UNIT_MOD_RESISTANCE_HOLY, BASE_VALUE, float(cinfo->resistance1)); SetModifierValue(UNIT_MOD_RESISTANCE_FIRE, BASE_VALUE, float(cinfo->resistance1)); SetModifierValue(UNIT_MOD_RESISTANCE_NATURE, BASE_VALUE, float(cinfo->resistance1)); SetModifierValue(UNIT_MOD_RESISTANCE_FROST, BASE_VALUE, float(cinfo->resistance1)); SetModifierValue(UNIT_MOD_RESISTANCE_SHADOW, BASE_VALUE, float(cinfo->resistance1)); SetModifierValue(UNIT_MOD_RESISTANCE_ARCANE, BASE_VALUE, float(cinfo->resistance1)); Does it suppose to update each resistance field based on one, origin resistance1?

those should be only offensive spells. I was speaking with frien from offi so final target != caster. It could be general rule for this spell but AoE are breaking it (target = caster but results are impacting SPELL_AOE_TARGETS) so some unifying spell flag has to be found or DropCharge() has to be moved somwhere closer to DoAllEffectsOnTarget()

NetSky or ApoC can you pick up thread once again that we could give you a feadback please. I think that is important feature that has to be updated.

maybe more generic approach but still hacky http://www.pastebin.org/83413 affected spells: mysql> SELECT id, spellname FROM spell_entry WHERE mechanic = 29; +-------+--------------------+ | id | spellname | +-------+--------------------+ | 498 | Divine Protection | | 642 | Divine Shield | | 1022 | Hand of Protection | | 5599 | Hand of Protection | | 10278 | Hand of Protection | | 27619 | Ice Block | | 41367 | Divine Shield | | 45438 | Ice Block | | 46604 | Ice Block | | 63148 | Divine Shield | | 65802 | Ice Block | | 66009 | Hand of Protection | | 66010 | Divine Shield | | 67251 | Divine Shield | +-------+--------------------+ 14 rows in set (0.13 sec)

true, but this patch concern around implementing aura 262, should be cleand from other spell fixes/hacks and reviewed at last

i can confirm it on 9110, from time to time players from opposite faction can even aggro battleground healer using AoE

you probably done mistake like many other people. If you stored pointers and you fail to control what is happening with them during script execution use GUIDs instead and create pointer each time when it is needed. Pobably you summoned adds using SummonCreature() than stored pointers to them and finaly tried to access unit that has been already killed and despawned.

Sap has incapacitate effect

afaik m_target is processed in Spell.cpp it musn't be current unit target. but thats not the point of this issue offtoping Devs

removed m_target NULL check, first post updated

pet_aura?

MaNGOS 9110 UDB 386 SD2 1541 Description: effect of Aura::HandleAuraAllowFlight is handled with using Player* class functions. I think nomather of script or DB data correctness there should be chack before processing if target indeed is a player. crashlog: http://www.pastebin.org/74389 patch: http://www.pastebin.org/74617

waiting impateitntly for more generic solution (including Slam) : )

try PasdVn patch. I slightly modified it http://www.pastebin.org/73194 orginal one is somwhere here http://github.com/pasdVn/mangos/commits/OV_3.1 for thos looking for different approach the clue is flag AttributesEx2 & SPELL_ATTR_EX2_UNK17 for spells that are not interruping autoattacks (hunters shots + slam)

it is working as intended at least i think so. i've got modified AutoShot update patch that enable shooting hunter shots and autoshot simultanously (slightly modified version of PasdVn patch) and i had to prevent casting autoshot without ranged weapon. Any one can checkout clean source for that issue?

MaNGOS 9110 ScriptDev2 1537 UDB 386 Spell Living Ruby Pedant and Siphon Essence should do healing exact as it is described in spell tooltip. Instead after passing: pdamage = pCaster->SpellHealingBonus(m_target, GetSpellProto(), pdamage, DOT, GetStackAmount()); receive spell bonus that makes it heal for insane amount of health. maybe SPELL_AURA_PERIODIC_HEAL and SPELL_AURA_OBS_MOD_HEALTH should have two different cases? DELETE FROM spell_bonus_data WHERE entry IN (31024,38395,5707,17712); INSERT INTO spell_bonus_data VALUES (31024,0,0,0,'Living Ruby Pedant'), (38395,0,0,0,'Siphon Essence - Malefic Raiment set spell'), (5707,0,0,0,'Lifestone Regeneration'), (17712,0,0,0,'Lifestone Healing'); EDIT added: http://www.wowhead.com/?item=833

@Darky88 lookup creature_addon or creature template addon of npc 33778 (guid 136670) for auras reserved only for player class.

true, hitbox on mangos is always set on default. that also make some encounters not possible to scritp blizzlike. For example gruul the dragon killer. While growing up at each buff stack his hitbox should also grow that at certain point he is able to reach almost all players in his lair.