Jump to content
  • Shield Slam issues (warrior) (duh..)


    Aenra
    • Status: Completed
      Main Category: Database
      Sub-Category: Spell
      Version: 0.20(currentmasterbranch) Milestone: 20-newbeginnings Priority: New
      Implemented Version: 0.20(currentmasterbranch)

    Shield Slam issues (warrior) (duh..)

    It can't be used unless NPC targetted at has buff for you to dispel. Am not a warrior expert (i know casters), but i think it's a skill you should have been able to use at will, the debuff a secondary effect if/when applicable.

    If you're sure i'm wrong, disregard this :)


    User Feedback

    Recommended Comments

    PR: [URL="https://github.com/mangoszero/server/pull/291"]core[/URL]. Implemented now.

    Here the spell is allowed in a "hacky" way. To solve the probem more accurately, two things are needed:
    1) the full answer to [URL="https://www.getmangos.eu/community-input-needed/10265-vanilla-dispel.html"]this[/URL],
    2) an analysis of unknown spell flags. The spell has four such flags.
    The later is achievable much harder, so I'm not ready to promise it.

    Moreover, in two code parts the spell is identified via two different SpellFamilyFlags values, which is not good. Cast is enabled, but actual dispel effect application should be tested (seemingly ok).

    Link to comment
    Share on other sites

    [quote=Olion]Moreover, in two code parts the spell is identified via two different SpellFamilyFlags values, which is not good.[/quote]
    PR: [URL="https://github.com/mangoszero/server/pull/292"]core[/URL], unified method of the spell recognize. A minor code improvement.

    Link to comment
    Share on other sites



    Create an account or sign in to comment

    You need to be a member in order to leave a comment

    Create an account

    Sign up for a new account in our community. It's easy!

    Register a new account

    Sign in

    Already have an account? Sign in here.

    Sign In Now

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use