[Rel20] Release showstoppers! PLEASE READ!

The FFF issue sounds like a DB issue. As such i'm tempted to say it's not a show stopper in getting this massively improved version out.

When you compare where Rel20 is now, compared to Rel19. The bugs were also in that version, so nothing has got worse.
- I'm tempted to push this one out to Rel21 for now

The druid thing is NOT a show-stopper. The looting STILL being messed up is. I would like to see loot working correctly prior to R21, but I'm not a shot-caller here. I just believe that, since it worked for quite a while before the split, we should have it working by now. Either way I intend on contributing my time to R21 the moment it is out. I am still struggling with why the hell MaNGOS despises foreign keys, but that is my own issue.

Xen, i'm with you all the way with foreign keys !
- horrific db design choices were made there

I won't even go into the inverted key matching thats done on gossip texts etc.

I just found one that cna be a show-stopper as far as questing goes. My fiance and mom are in a cave (Splinthoof Hold) and the mobs there are aggroing and deaggroing repeatedly. Not only that but my fiance tries summoning her VW in the cave and it uses a soul-gem but does not grant the VW. Finally, my mother did charge in the cave at an enemy and fell through the world and died. Caves may be hosed for some reason...

Testcommit for chest is up if anyone wants to test

[url]https://github.com/Evildead666/server/commit/f01e511f9e23f09b5cd51115e4c78855b9f89827[/url]

What does that fix?

Should fix chestlootling in grouploot and need before greed

We really need that tested ASAP !!

Wait, we did not roll on items in chests. That is WRONG. Players would do "/roll" and whomever had the highest number got to open it. I have NEVER seen chest items rolled on. I played every iteration from the alpha to Cataclysm, so if rolling on things in chests was ever added, it was added in Cataclysm. The correct behavior in vanilla is for whomever opens it gets it.

*UPDATE*

Based on reading, this has been implemented... in 2.1! Therefore this patch should apply to BC and newer, not vanilla. I honestly do not remember having to roll on chests when I played through Lich King however, but it may have been due to the way my guild played. We simply rolled on the chests.

[url=http://www.wowwiki.com/Roll]WoW Wiki #1[/url]
[url=http://www.wowwiki.com/Loot]WoW Wiki #2[/url]

Note from #2:
[quote]
Note that loot from containers — chests, food crates, and the like — as opposed to corpses, also uses the party loot threshold (if one is in effect), although the container will always be lootable by any party member. If the container holds a high-quality item, that item will be rolled on (or not), the same as if it were looted from a corpse. Since this is a recent change (Patch 2.1.0), many groups may still require rolling on content, or at least to link the common items such as foods and potions to give to those who need it. Since chests do not normally contain items of high value, usually the party members /roll for it.
[/quote]
We do NOT have a loot system in vanilla for the party rolling on chest loot.

Then it is not needed for 1.12.1, however it would be a good idea to check if it works as intended for 2.4.3 and implement accordingly.

Right. Now my question is this. Is the article right? I have been asking my guild-mates (we all stopped when Cata was released) and nobody remembers ever having to need or greed on a chest. I swear this was implemented at a later date, but I will find patch-notes and figure out when it was added. If it WAS added in 2.1, why did we not get the prompts in BC/LK on official? We ALWAYS used group loot, but nobody remembers having to roll on the items in the chest. We simply did /roll and the highest number got the chest.

I remember rolls on chests during BC :) A good example of this, is last boss in Ramparts. The end chest counts as any other chest, and the boss loot was something you had to roll for :) No special scripts or anything.

Actually boss chests were NOT the same. In fact while researching I have come across several threads on the Blizzard forum referencing various boss chests not working correctly. The one that came up most often was the one where you fight the seven dwarves and their chest was bugged so rolling didn't work and on person would wind up looting it and being unable to share the items. In fact that one had been bugged for seven months when the last post was made.

I will say it again, I do not remember this and nobody else in my guild does. I am still going through patch-notes trying to find this, but whether or not it was in BC is irrelevant. We're pushing vanilla right now and we do know it wasn't there.

[quote=Xenithar]Actually boss chests were NOT the same. In fact while researching I have come across several threads on the Blizzard forum referencing various boss chests not working correctly. The one that came up most often was the one where you fight the seven dwarves and their chest was bugged so rolling didn't work and on person would wind up looting it and being unable to share the items. In fact that one had been bugged for seven months when the last post was made.

I will say it again, I do not remember this and nobody else in my guild does. I am still going through patch-notes trying to find this, but whether or not it was in BC is irrelevant. We're pushing vanilla right now and we do know it wasn't there.[/quote]

Not necessarily sure how you can say BC is irrelevant when we're working towards a release of Zero, One and Two at the same time..? We already established that it shouldn't be added to Zero as the chests were not included in the standard group loot policy till after 2.1.

Also not sure how boss chests are not the same as normal chests? They were added as viable boss loot during the same time rolling on chest items were added. They are handled the exact same way as normal chests are, except their flags are changed to active or the chest is spawned once the boss is killed. So the flag and the pushing of the loot to the object itself are the only differences. But a chest is still a chest, whether it's a boss chest or not. I quote wowwiki and wowpedia:

[COLOR=#D5D4D4][FONT=Helvetica]"Since [/FONT][/COLOR][URL="http://www.wowwiki.com/Patch_2.1"]Patch 2.1[/URL][COLOR=#D5D4D4][FONT=Helvetica], lootable world objects (such as chests) follow group loot rules, meaning that group members would be able to distribute loot found in chests just as they would on drops from ordinary mobs."[/FONT][/COLOR]
[url]http://www.wowwiki.com/Chest_(container)[/url]

The change is listed in the undocumented patch notes:
[url]http://www.wowwiki.com/Patch_2.1.0_(Undocumented_Changes)[/url]

[quote=Xenithar]Actually boss chests were NOT the same. In fact while researching I have come across several threads on the Blizzard forum referencing various boss chests not working correctly. The one that came up most often was the one where you fight the seven dwarves and their chest was bugged so rolling didn't work and on person would wind up looting it and being unable to share the items. In fact that one had been bugged for seven months when the last post was made.

I will say it again, I do not remember this and nobody else in my guild does. I am still going through patch-notes trying to find this, but whether or not it was in BC is irrelevant. We're pushing vanilla right now and we do know it wasn't there.[/quote]

We are pushing Zero, One AND Two atm. It's just Zero is closer as it's had the most attention.

I can always remember having to roll for chests, from stockades onwards
- Having a rogue or blacksmith with skeleton keys was a bonus as there was that one chest that was always locked.

On group loot, there was always a roll

I meant that the change for chests in Zero was irrelevant, not that Two was. Should have clarified that.

Guess it was added in BC then. Maybe I took a break before BC made the change. I remember getting bored with BC and taking a break until just before LK came out, so maybe I missed the chest looting change. We did not do much (any?) raiding in LK so that may also add to why I do not remember it.

As for the boss chests they are somehow handled differently on the official servers beyond spawning. The bug mentioned above is linked below. If the chest was just a "normal" chest this would not happen. I was never the ultimate raiding guy after BC was released, but I remember threads from the past about boss chests not acting right on several occasions. This is just one. Sadly, I cannot offer much assistance here due to my lack of raiding post-BC.

[url=http://us.battle.net/wow/en/forum/topic/8197581942]Chest of The Seven[/url]
[url=http://us.battle.net/wow/en/forum/topic/7811541287]Ulduar Hodir Chest[/url]

There are more, just google for them. If we can fix this then it puts us ahead of them somehow.

Xenithar you are probably right as i also remember rolling for chests.
But there was a change introduced late in Classic regarding chestloot, it was made to stop ninjalooting the majordomo chest which was possible before.
so i guess it was already in classic but only applied to bosschests.

It was not in vanilla at all. I was a HEAVY raider in vanilla. I had top gear and even a Thunderfury. We NEVER got the group loot roll in vanilla. That was added in BC after I took a break.

*EDIT*

Also, I just built the current R20 and I STILL cannot see any realms listed in the realm selection screen despite having my realm show up when realmd starts. This is a game-breaker. A new player who just built their first server would not even be able to get into it. I can reproduce this on 64bit and 32bit Debian Wheezy. I do not have my Gentoo server up right now. Hardware changes.

[quote=Xenithar]It was not in vanilla at all. I was a HEAVY raider in vanilla. I had top gear and even a Thunderfury. We NEVER got the group loot roll in vanilla. That was added in BC after I took a break.

*EDIT*

Also, I just built the current R20 and I STILL cannot see any realms listed in the realm selection screen despite having my realm show up when realmd starts. This is a game-breaker. A new player who just built their first server would not even be able to get into it. I can reproduce this on 64bit and 32bit Debian Wheezy. I do not have my Gentoo server up right now. Hardware changes.[/quote]

[url]https://www.youtube.com/watch?v=RXU545FU8yE[/url]

As seen there, the chest was FFA as of 1.12.1, and it kept being that way till chest loot rolling was implemented in 2.1.

On the realms not being listed, unfortunately I can't help you with that, have tried several OS', both internal and external ACE and I'm not able to reproduce it.

Have you tried Debian stable with the ACE that comes with Debian? Not a downloaded one (that is not the proper way to do things in Linux) and not one from some off the wall repo. Can you make it work in Debian stable with the OS stuff? I have now narrowed my issue down to ACE starting and killing a thread, but no clue as to why. No info is given. It just won't run.

Yup, tried with the lib that comes with the distro, latest available with apt get, and internal. All three working like they should for me, realm shows up just like it does in the Ubuntu screenshot like I showed previously

Then we need to figure out why this is failing on every system I try it on, but we should discuss it in the correct thread since it may not be a show-stopper for everybody. I will say that I just build Zero on my work laptop running Gentoo and had the exact same issue. I cannot figure out why the ACE thread dies the instant it starts, but I am fairly sure that is the issue.

[quote=Xenithar]It was not in vanilla at all. I was a HEAVY raider in vanilla. I had top gear and even a Thunderfury. We NEVER got the group loot roll in vanilla. That was added in BC after I took a break.

*EDIT*

Also, I just built the current R20 and I STILL cannot see any realms listed in the realm selection screen despite having my realm show up when realmd starts. This is a game-breaker. A new player who just built their first server would not even be able to get into it. I can reproduce this on 64bit and 32bit Debian Wheezy. I do not have my Gentoo server up right now. Hardware changes.[/quote]

Have you checked there are no 'funny' realmflags set ?
- I have on occassion seen a value of 6 in the realmflag column, which prevents the realm from being shown to the client

My server is dead as you know, but the flags were 64.

Is anyone aware of any issues that are preventing Rel20 from being released ?