A few more bugs...

Alright, found an oddity here. Thrall has only 2665 hp. Cairne and Onyxia only have 3331 hp. Thrall should have 360k hp. Reference is below. Heck, I have people below 60 who have more HP than them!

[url=http://datenbank.welli-it.de/?npc=4949]Thrall - NPCs - Classic WoW - 1.12.1 Datenbank[/url]

Rel19 or 20 for the above ?

... And these should be logged in the tracker not here !

You mean the ticket system at GitHub or the forum here? I posted here to have this stuff discussed to determine wether or not we need a ticket. Also, I run R19 but will be testing R20 later this week.

The one on the forum

[quote=Xenithar]Alright, found an oddity here. Thrall has only 2665 hp. Cairne and Onyxia only have 3331 hp. Thrall should have 360k hp. Reference is below. Heck, I have people below 60 who have more HP than them!

[url=http://datenbank.welli-it.de/?npc=4949]Thrall - NPCs - Classic WoW - 1.12.1 Datenbank[/url][/quote]


This is due to the new HP/Mana Calculation on creatures.cpp (the modifier is not working at this moment). I commented the new calculation out like this:

[code]
//////////////////////////////////////////////////////////////////////////
// Calculate level dependend stats
//////////////////////////////////////////////////////////////////////////

uint32 health;
uint32 mana;
// New style of calculating health/mana is not working properly
/* if (CreatureClassLvlStats const* cCLS = sObjectMgr.GetCreatureClassLvlStats(level, cinfo->UnitClass))
{
// Use Creature Stats to calculate stat values

// health
health = cCLS->BaseHealth * cinfo->HealthMultiplier;

// mana
mana = cCLS->BaseMana * cinfo->ManaMultiplier;
}
else */
// {
// Use old style to calculate stat values
float rellevel = maxlevel == minlevel ? 0 : (float(level - minlevel)) / (maxlevel - minlevel);

// health
uint32 minhealth = std::min(cinfo->MaxLevelHealth, cinfo->MinLevelHealth);
uint32 maxhealth = std::max(cinfo->MaxLevelHealth, cinfo->MinLevelHealth);
health = uint32(minhealth + uint32(rellevel * (maxhealth - minhealth)));

// mana
uint32 minmana = std::min(cinfo->MaxLevelMana, cinfo->MinLevelMana);
uint32 maxmana = std::max(cinfo->MaxLevelMana, cinfo->MinLevelMana);
mana = minmana + uint32(rellevel * (maxmana - minmana));
// }

health *= _GetHealthMod(rank); // Apply custom config settting
if (health health = 1;
[/code]