Rhapsody Malt: 1/1 shown twice when you purchase it

Same behaviour could be seen during the quest "The Chill of Death" (quest=375) in Tirisfal Glades. Buying Coarse Thread leads to double player notification. But according to the info in description, both issues should have the same solution.

5 minutes ago, altronrain said:

Same behaviour could be seen during the quest "The Chill of Death" (quest=375) in Tirisfal Glades. Buying Coarse Thread leads to double player notification. But according to the info in description, both issues should have the same solution.

Have you tried commenting the send of packet?

Nope, but I'm more than sure that my mensioned quest has the same issue and solution

I’ll let you know tomorrow, thx for your feedback

Only respective sniffes give a solid ground to modify current protocol. While solution is efficient, it looks wrong at the same time. Try to buy an item with limited vendor quantity, for example the one from Tharynn Bouden (entry 66), and look at the item number present by the vendor.

Perhaps conditionally avoid to send the SMSG_QUESTUPDATE_ADD_ITEM packet after SMSG_BUY_ITEM is the proper way. I have no sniffes as well.

2 hours ago, Olion said:

Only respective sniffes give a solid ground to modify current protocol. While solution is efficient, it looks wrong at the same time. Try to buy an item with limited vendor quantity, for example the one from Tharynn Bouden (entry 66), and look at the item number present by the vendor.

Perhaps conditionally avoid to send the SMSG_QUESTUPDATE_ADD_ITEM packet after SMSG_BUY_ITEM is the proper way. I have no sniffes as well.

You are probably right.
it look wrong to me to, cause If it fit this behaviour, is not si clean in regular behaviour(i.e. A player buying things)

Unfortunately from what can i see no relation in the code base between the two event, so far i’m not sure you can easily check if one message has been sent.

but i have like 0 experience with protocol and opcodes so i was just trying to figure it out.

what i think is that probably is wrong that at Client Side the message it’s triggered with the opcode SMSG_BUY_ITEM

4 hours ago, Tuker said:

what i think is that probably is wrong that at Client Side the message it’s triggered with the opcode SMSG_BUY_ITEM

I'm sure the Blizz had the task of traffic minimizing in mind. At their position, it looked easily: search the traffic log (sniffes, to us) for repeating packet (opcode) patterns and modify the protocol implementation to reduce them.

On the contrary, the core implementation doesn't look very good. Player::StoreNewItem and Player::EquipNewItem both do ItemAddedQuestCheck(...) sending the SMSG_QUESTUPDATE_ADD_ITEM packet. We can either provide the two methods a flag to avoid ItemAddedQuestCheck (the signature change), or inline the corrected code from the methods right into Player::BuyItemFromVendor(...). I like the second option better, while the proper way may be even changing Player::StoreNewItem and Player::EquipNewItem as well as their callers.