[7884][SQLpatch] again Mana Tap

[Auntie Mangos]

• * What bug does the patch fix? What features does the patch add?
  It removes the Blood Elf racial Mana Tap no longer used also from playercreateinfo_spell table, I forgot when posted this patch
  * For which repository revision was the patch created?
  7501 (all)
  * Who has been writing this patch?
  Me but this is not such a patch
  

-- MaNGOS DB
DELETE FROM `playercreateinfo_spell` WHERE `Spell` = '28734';
-- interface cleanup by crackm
DELETE FROM `playercreateinfo_action` WHERE `action` = '28734';
UPDATE `playercreateinfo_action` SET `button` = '3' WHERE `race` = '10' AND `class` IN ('8', '9', '5', '2', '3') AND `button` = '4';
UPDATE `playercreateinfo_action` SET `button` = '4' WHERE `race` = '10' AND `class` = '4' AND `button` = '5';
-- Characters DB
DELETE FROM `character_spell` WHERE `spell` = '28734';
DELETE FROM `character_aura` WHERE `spell` = '28734';
DELETE FROM  `character_action` WHERE `action` = '28734' AND `type` = '0';

Mana Tap needs to be removed from code too. Current code still checks for Mana Tap's. Something like

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index bc1316f..2c5b14a 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -3730,26 +3730,6 @@ void Aura::HandleAuraModSilence(bool apply, bool Real)
                }
            }
        }
-
-        switch (GetId())
-        {
-            // Arcane Torrent (Energy)
-            case 25046:
-            {
-                Unit * caster = GetCaster();
-                if (!caster)
-                    return;
-
-                // Search Mana Tap auras on caster
-                Aura * dummy = caster->GetDummyAura(28734);
-                if (dummy)
-                {
-                    int32 bp = dummy->GetStackAmount() * 10;
-                    caster->CastCustomSpell(caster, 25048, &bp, NULL, NULL, true);
-                    caster->RemoveAurasDueToSpell(28734);
-                }
-            }
-        }
    }
    else
    {

[Serker]

Mana Tap needs to be removed from code too. Current code still checks for Mana Tap's. Something like

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index bc1316f..2c5b14a 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -3730,26 +3730,6 @@ void Aura::HandleAuraModSilence(bool apply, bool Real)
                }
            }
        }
-
-        switch (GetId())
-        {
-            // Arcane Torrent (Energy)
-            case 25046:
-            {
-                Unit * caster = GetCaster();
-                if (!caster)
-                    return;
-
-                // Search Mana Tap auras on caster
-                Aura * dummy = caster->GetDummyAura(28734);
-                if (dummy)
-                {
-                    int32 bp = dummy->GetStackAmount() * 10;
-                    caster->CastCustomSpell(caster, 25048, &bp, NULL, NULL, true);
-                    caster->RemoveAurasDueToSpell(28734);
-                }
-            }
-        }
    }
    else
    {

[Sephiroth1983]

Tested and working as intented.

[Sephiroth1983]

Updated first post with cleanup queries

[mokanina]

bumping. this should be reviewed too

[rastikzzz]

maybe you should write why it has to be removed.. eg. link to patch notes where it is said. maybe then it will be accepted

[crackm]

ok since I wrote some simular patch here some info:

These spell mana tap was removed on blizz since 3.0.2, its now a part of the spell Arcane Torrent.

Some sources: http://forums.worldofwarcraft.com/thread.html;jsessionid=57EB2471F82D6FB76DAE9DC03C1254F2.app23_02?topicId=9679949429&sid=1

http://www.wowhead.com/?spell=28734#comments <-- every poster since 3.0.2 says its removed.

The other possible sorces says the seam.

[mokanina]

az you can see here the spell mana tap is missing

http://www.wowhead.com/?spells=-4

[Mukwiesel]

I pushing this topic, because its an importent fix.

[ApoC]

Applied in [7884] and [7884]

Thank You both.