[patch] Speedup grid object search

[Thyros]

i use 8265

[Ambal]

i use 8265

Ok, Thyros, I'll try to upload updated patch today. Thanks for reporting.

[Ambal]

Patch updated to latest 8277+ revs.

[nanounico]

Ambal, i use your patch, but with 8 Cells, and 66 Yards

[Ambal]

Ambal, i use your patch, but with 8 Cells, and 66 Yards

Hm... is server stability much worse with MAX_NUMBER_OF_CELLS 16? :huh:

[cyrex]

Was testing but my testing PC just got burned. Need to work to buy new one damn it. Was looking to test this enhancement to stability. Sorry ambal.

[cozzmic]

Ambal maybe this test results aren't very objective....I need to say this patch has good influence on my server.

I'm using:

- Rev 8195

- OpenMP

- Interfaction

- Some custom code

- your Gridsearch

Well I am testing this patch with 90Yards and 16 cells in griddefines. I have to say this is working very nice! I have not that big server. 100 testers per day. But it has an uptime of 6 days now!! Sometime I have a lag-spike but thats not because of your patch. Unfortunately I had it before.

The cpu-usage is very stable. just between 20-25%!

So thanks for your work. You are on the roll!

[Thyros]

Ambal maybe this test results aren't very objective....I need to say this patch has good influence on my server.

I'm using:

- Rev 8195

- OpenMP

- Interfaction <- what is this?

- Some custom code <- and this?

- your Gridsearch

Well I am testing this patch with 90Yards and 16 cells in griddefines. I have to say this is working very nice! I have not that big server. 100 testers per day. But it has an uptime of 6 days now!! Sometime I have a lag-spike but thats not because of your patch. Unfortunately I had it before.

The cpu-usage is very stable. just between 20-25%!

So thanks for your work. You are on the roll!

can you me say what is interfaction?

[divisorxx]

I assume that it's an interfaction patch to allow something

[cozzmic]

can you me say what is interfaction?

Oh yeah sorry, it is the patch which lets Ally and Horde have better interaction which each other. Healing etc.It is also known as Ally horde in same group - Core modification.

[niggo76]

i dont want to be dumb but...how to apply this ?

I changed the txt file to patch file but if i say apply patch to my directory wheres the src folder, nothing happens, just 2 blank sides in the tortoisemerge

[Ambal]

I'll be out untill 12th of August. So are on your own updating patch to new revs. You can still post any patch related info Good luck everyone. See you

[cozzmic]

I'll be out untill 12th of August. So are on your own updating patch to new revs. You can still post any patch related info Good luck everyone. See you

I assume you're gonna be on holiday....in that case enjoy it! We see you back in two weeks! Bye!

[divisorxx]

Well tested with rev 8277 with MAX_NUMBER_OF_CELLS 8

CPU ussage reduce like a 7% with 600 testers, all Visibility.Distance... in 90... later i will put more data. Thanks+

Edit: No crash reported due to this.

[nanounico]

someone knows if work with 8342+??

[filo]

Yes its work on newest mangos revisions ;-).

I compiled it on rev 8664 successfully :cool:

[Ambal]

Ok, I'm back Will get in shape in few days to support patch further Hello to everyone )

[JordanMckeag]

Wow I was looking for something simlar to this

Now this is a good patch i am going to test it out soon

I notice the lag spikes now and again for some unknown reasons

[Power2All]

In file included from ../../../src/game/AchievementMgr.cpp:28:

../../../src/game/World.h: In static member function âstatic float World::GetMaxVisibleDistanceForCreature()â:

../../../src/game/World.h:493: error: âm_MaxVisibleDistanceForCreatureâ was not declared in this scope

../../../src/game/World.h: In static member function âstatic float World::GetMaxVisibleDistanceForPlayer()â:

../../../src/game/World.h:494: error: âm_MaxVisibleDistanceForPlayerâ was not declared in this scope

With latest mangos

[JordanMckeag]

wats the best settings do you reccomend to get the best peformance out of this

[Ambal]

whats the best settings do you reccomend to get the best peformance out of this

If you want performance, then choose visibility distance value between 66 and 90 yards. Also you can play with MAX_NUMBER_OF_CELLS (8 or 16) to see which one is better for performance/stability.

[cyrex]

I just patched with the default code and i got a lot better performance than without it. Less lag in general, more people can be on same zone without problem and even more people can cast spells on same zone without problem. At least i can see first hand a performance increase using the default patch without changing anything, i do not know if it is at 16 or 8.

[leak]

Tried backporting to 0.12

http://pastebin.com/m28813c44

Running fine with rev 944f5098 so far. Still suffering from GetInstance crashes alot (*sigh*) but they are not related i think.

I chose to run with same settings i had before, 8 cells and 66y everywhere. I can't say i notice a major performance increase but it looks like an improvement nevertheless.

Could someone go a little deeper into the whole cell theory how stuff is calculated, etc.(grids, cells, visibility)? The only thing i recall from some time ago is performance totally went down the drain when those MAX_NUMBER_OF_CELLS where changed to 4 and visibility was changed to 132y (commit 6909)

@ambal

Could you check if something on my backport is wrong? Had to cut out some things because they simply don't exist on 0.12 (something with perodicaura..)

[therapist]

M8 put this is under review

this should be applied i put it on standard settings and the server works perfectly no crashes with this on

[Sephiroth1983]

M8 put this is under review

this should be applied i put it on standard settings and the server works perfectly no crashes with this on

Then I can't wait for it to be accepted either.