[fix][dev]Fingers of Frost, Aura 262

[SeTm]

I think the patch is now ready to commit....?

No, many hacks..

Drop charges can be handled in proc system, how it done in patch on mangos.ru

[Wojta]

Ok, I will look at it

[Wojta]

No, many hacks..

Drop charges can be handled in proc system, how it done in patch on mangos.ru

Sorry, but....I dont see anything which drops charges in this patch. If you or anybody else know, please tell me...

Oh, i forgot, you cant see getmangos.ru patch: http://pastebin.ca/1662021

[KriM]

please update for the new rev=)

[Wojta]

please update for the new rev=)

for me it works on rev 8800 without conflicts...if you are using linux, there are maybe some wrong line endings...sorry, I dont know what to do with that, but i will try...

EDIT: Try this: http://pastebin.ca/1665458

[KriM]

for me it works on rev 8800 without conflicts...if you are using linux, there are maybe some wrong line endings...sorry, I dont know what to do with that, but i will try...

EDIT: Try this: http://pastebin.ca/1665458

the same errors=(

git apply ../../patch/frost.patch

../../patch/frost.patch:44: trailing whitespace.

break;

../../patch/frost.patch:52: trailing whitespace.

case 60503: // Taste for blood

../../patch/frost.patch:188: trailing whitespace.

m_caster->CastSpell(m_caster, 65156, true);

warning: 3 lines add whitespace errors.

p.s. yep, i'm using linux

[Snakeyes]

Hello, after some testing found two minor bugs

MaNGOS Rev. 8801

Patch Version: 5a

- Talents "Juggernaut" & "Warbringer" works, but if you try any maps changing(portals, ".tele" command ecc) seems this two talents doesnt work anymore; infact you cant use Charge in combat and with "Warbringer" you cant use for example Charge or Intervene in berserker stance.

With a relog, all works fine again.

- As i remember "Sudden Death" and "Taste for Blood" can stack, or not?.

Thx for your patch Wojta(and all contributors)

[Wojta]

Hello, after some testing found two minor bugs

MaNGOS Rev. 8801

Patch Version: 5a

- Talents "Juggernaut" & "Warbringer" works, but if you try any maps changing(portals, ".tele" command ecc) seems this two talents doesnt work anymore; infact you cant use Charge in combat and with "Warbringer" you cant use for example Charge or Intervene in berserker stance.

With a relog, all works fine again.

- As i remember "Sudden Death" and "Taste for Blood" can stack, or not?.

Thx for your patch Wojta(and all contributors)

Thanks for testing

1) Oh no....client flushes auras when it loads new map? why? Look like another hack needed.... any ideas?

2) They cant stack, they overwrites. I think it is not wrong, because I didnt edit this

the same errors=(

p.s. yep, i'm using linux

Wrong line endings. I´m coding in VS C++, anybody knows some software which removes this?

[Wojta]

V5b!

http://pastebin.ca/1666611

- Removed hack for Juggernaut/Warbringer!

Now it should work fine, and without hack - I watched to that all the time, but now i finally read the comment! Please, test, I cant do it by myself, because on my computer mangos always crashes(too old?), usually I am testing on my friends computer, but he isnt here now

PS: You can try this to remove "wrong" line endings

dos2unix -b patchname.diff

[Snakeyes]

Hello,

MaNGOS Rev. 8807

Patch Version: 5b

"Warbringer" & "Juggernaut" doesnt work anymore :confused:

[Wojta]

Hello,

MaNGOS Rev. 8807

Patch Version: 5b

"Warbringer" & "Juggernaut" doesnt work anymore :confused:

well, it wasnt soo good you can try reset talents and then learn Juggernaut/Warbringer - they should work, at least until relog. Sorry, I cant fix it now, I can only guess because I cant test it

[Snakeyes]

Already tried; created new char but nothing.

[Wojta]

Thats strange, I changed only part for Aura at relog/map change...

[Cobra101]

Hello,

MaNGOS Rev. 8807

Patch Version: 5b

"Warbringer" & "Juggernaut" doesnt work anymore :confused:

Compiling 8823 will test in a few, but I was using 8770 and those didn't work on their own anyway. They haven't for quite some time.

[zokuero]

Compiling 8823 will test in a few, but I was using 8770 and those didn't work on their own anyway. They haven't for quite some time.

tested, juggernaut still doesn't work

[Wojta]

You can use V5, in V5a and V5b I am just tried to remove ugly hack from player.cpp, on V5 it works fine

[Snakeyes]

You can use V5, in V5a and V5b I am just tried to remove ugly hack from player.cpp, on V5 it works fine

Yes, tested v5 and all works fine. ^^

[bulek]

BUMP! any news/updates?

[Haruzept]

i think it progs a little bit oft

[Wojta]

Current Status: Patch is working as it should, but I cant remove these hacks, so I think i cant be reviewed

Maybe somebody else knows...

[nikko]

This patch bugs Vanish http://www.wowhead.com/?spell=26889, when you use vanish in combat doesn't enter you in stealth only does vanish efect.

Before this patch vanish works ok, after this patch vanish fail.

Please find a solution.

[Wojta]

hmmm I dont know what this means...on my server, after my patch and patch for target type 104 it works fine... Can my patch affect this spell?

[fullburned]

This patch bugs Vanish http://www.wowhead.com/?spell=26889, when you use vanish in combat doesn't enter you in stealth only does vanish efect.

Before this patch vanish works ok, after this patch vanish fail.

Please find a solution.

Aw, I have the same bug but I'm not sure if this patch causes this. Will try soon without it=\\

At least I'm not alone:rolleyes:

[nikko]

Aw, I have the same bug but I'm not sure if this patch causes this. Will try soon without it=\\

At least I'm not alone:rolleyes:

I put this patch the last in my server and vanish fails after this, im 99,9% sure is that patch

[Wojta]

Ok, i will look at it... please tell me what do you see when you use vanish("Cant be used in combat", "out of range" etc)...

EDIT:

   //check caster for combat
    if(m_caster->isInCombat() && IsNonCombatSpell(m_spellInfo) && !m_caster->isIgnoreUnitState(m_spellInfo))
       return SPELL_FAILED_AFFECTING_COMBAT;

Looks like vanish is considered like non combat spell...

Maybe this part isnt needed at all, but I have to test...

Simple hot-fix is ...

   //check caster for combat
    if(m_caster->isInCombat() && IsNonCombatSpell(m_spellInfo) && m_spellInfo->Id != 18461 && !m_caster->isIgnoreUnitState(m_spellInfo))
       return SPELL_FAILED_AFFECTING_COMBAT;